Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Microsoft.Insights api version 2021-02-01-preview #13275

Merged
merged 8 commits into from
Mar 9, 2021
Merged

New Microsoft.Insights api version 2021-02-01-preview #13275

merged 8 commits into from
Mar 9, 2021

Conversation

avjerafi
Copy link
Contributor

@avjerafi avjerafi commented Mar 4, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @avjerafi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 4, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌LintDiff: 1 Errors, 6 Warnings failed [Detail]

    Rule Message
    R3023 - OperationsAPIImplementation Operations API must be implemented for '/providers/Microsoft.Insights/operations'.
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L36
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L337
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L365
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isWorkspaceAlertsStorageConfigured
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L414
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: checkWorkspaceAlertsStorageConfigured
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L419
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: skipQueryValidation
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L423
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoMitigate
    Location: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L427
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 6 Warnings warning [Detail]

    Rule Message
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L83:9
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L83:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L125:9
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L125:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L165:9
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L165:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L226:9
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L226:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L275:9
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L275:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: common-types/resource-management/v2/types.json#L644:5
    Old: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L624:5
    ️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 20 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules/{ruleName}' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L37:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/scheduledQueryRules' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L229:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L272:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LogSearchRuleResource' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LogSearchRuleResourcePatch' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Source' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Schedule' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'QueryType' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LogSearchRule' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LogSearchRulePatch' removed or renamed?
    New: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#L311:3
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L319:3
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 8 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'ScheduledQueryRuleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'ScheduledQueryRuleResourcePatch-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'ScheduledQueryRuleResourceCollection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️❌[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Code style issues found
    path: Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 4, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b3ee547. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
    • ️✔️@azure/arm-monitor [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/monitorManagementClient.js → ./dist/arm-monitor.js...
      cmderr	[npmPack] created ./dist/arm-monitor.js in 152ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b3ee547. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️monitor/mgmt/2020-10-01/insights [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/monitor/mgmt/2019-11-01-preview/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `MetricNamespace` in struct `RuleDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `Kind` in struct `ActivityLogAlertResource`
      info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
      info	[Changelog] - New field `Action` in struct `AlertRule`
      info	[Changelog] - New field `ProvisioningState` in struct `AlertRule`
      info	[Changelog] - New field `MetadataValues` in struct `TimeSeriesBaseline`
      info	[Changelog] - New field `CreatedWithAPIVersion` in struct `LogSearchRule`
      info	[Changelog] - New field `IsLegacyLogAnalyticsRule` in struct `LogSearchRule`
      info	[Changelog] - New field `DisplayName` in struct `LogSearchRule`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 29 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2019-06-01/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New anonymous field `*MetricAlertPropertiesPatch` in struct `MetricAlertResourcePatch`
      info	[Changelog] - New field `Kind` in struct `ActionGroupResource`
      info	[Changelog] - New field `Identity` in struct `ActionGroupResource`
      info	[Changelog] - New field `MetadataValues` in struct `TimeSeriesBaseline`
      info	[Changelog] - New field `Timestamps` in struct `Baseline`
      info	[Changelog] - New field `CreatedWithAPIVersion` in struct `LogSearchRule`
      info	[Changelog] - New field `IsLegacyLogAnalyticsRule` in struct `LogSearchRule`
      info	[Changelog] - New field `DisplayName` in struct `LogSearchRule`
      info	[Changelog] - New field `Kind` in struct `Resource`
      info	[Changelog] - New field `Etag` in struct `Resource`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 34 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2019-03-01/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `ProvisioningState` in struct `AlertRule`
      info	[Changelog] - New field `Action` in struct `AlertRule`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleMetricDataSource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
      info	[Changelog] - New anonymous field `*MetricAlertPropertiesPatch` in struct `MetricAlertResourcePatch`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleDataSource`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleDataSource`
      info	[Changelog] - New field `Kind` in struct `AlertRuleResource`
      info	[Changelog] - New field `Etag` in struct `AlertRuleResource`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 34 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-11-01-preview/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `*MetricAlertPropertiesPatch` in struct `MetricAlertResourcePatch`
      info	[Changelog] - New field `Kind` in struct `LogProfileResource`
      info	[Changelog] - New field `Etag` in struct `LogProfileResource`
      info	[Changelog] - New field `Kind` in struct `AlertRuleResource`
      info	[Changelog] - New field `Etag` in struct `AlertRuleResource`
      info	[Changelog] - New field `Etag` in struct `LogSearchRuleResource`
      info	[Changelog] - New field `Kind` in struct `LogSearchRuleResource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
      info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 30 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-09-01/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `Kind` in struct `ActionGroupResource`
      info	[Changelog] - New field `Etag` in struct `ActionGroupResource`
      info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
      info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
      info	[Changelog] - New field `Kind` in struct `ActivityLogAlertResource`
      info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
      info	[Changelog] - New field `ProvisioningState` in struct `AlertRule`
      info	[Changelog] - New field `Action` in struct `AlertRule`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleDataSource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleDataSource`
      info	[Changelog]
      info	[Changelog] Total 21 breaking change(s), 54 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-03-01/insights [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `Etag` in struct `LogProfileResource`
      info	[Changelog] - New field `Kind` in struct `Resource`
      info	[Changelog] - New field `Etag` in struct `Resource`
      info	[Changelog] - New field `Kind` in struct `ActionGroupResource`
      info	[Changelog] - New field `Etag` in struct `ActionGroupResource`
      info	[Changelog] - New field `Etag` in struct `AlertRuleResource`
      info	[Changelog] - New field `Kind` in struct `AlertRuleResource`
      info	[Changelog] - New field `Etag` in struct `LogSearchRuleResource`
      info	[Changelog] - New field `Kind` in struct `LogSearchRuleResource`
      info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
      info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
      info	[Changelog] - New field `Timestamps` in struct `Baseline`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 30 additive change(s).
      info	[Changelog]
    • ️✔️preview/monitor/mgmt/2017-05-01-preview/insights [View full logs]  [Release SDK Changes]
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleMetricDataSource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
      info	[Changelog] - New field `Timestamps` in struct `Baseline`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleDataSource`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleDataSource`
      info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
      info	[Changelog] - New field `Action` in struct `AlertRule`
      info	[Changelog] - New field `ProvisioningState` in struct `AlertRule`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b3ee547. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-03-09 09:34:05 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-monitor-generated"
      cmderr	[generate.py] 2021-03-09 09:34:05 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-03-09 09:34:05 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/monitor/azure-resourcemanager-monitor-generated --java.namespace=com.azure.resourcemanager.monitor.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [POM][Skip] pom already has module sdk/monitor
      cmderr	[generate.py] 2021-03-09 09:34:32 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-monitor-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG Got artifact_id: azure-resourcemanager-monitor-generated
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG Got artifact: azure-resourcemanager-monitor-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG Got artifact: azure-resourcemanager-monitor-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG Match jar package: azure-resourcemanager-monitor-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-09 09:37:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13275/azure-sdk-for-java/azure-resourcemanager-monitor-generated/azure-resourcemanager-monitor-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-monitor-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-monitor-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-monitor-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b3ee547. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model RuleDataSource has a new parameter resource_location
      info	[Changelog]   - Model RuleDataSource has a new parameter metric_namespace
      info	[Changelog]   - Model RuleDataSource has a new parameter legacy_resource_id
      info	[Changelog]   - Model MetricAlertResource has a new parameter is_migrated
      info	[Changelog]   - Model RuleMetricDataSource has a new parameter resource_location
      info	[Changelog]   - Model RuleMetricDataSource has a new parameter metric_namespace
      info	[Changelog]   - Model RuleMetricDataSource has a new parameter legacy_resource_id
      info	[Changelog]   - Model DataCollectionRuleResource has a new parameter kind
      info	[Changelog]   - Model DataCollectionRuleResource has a new parameter immutable_id
      info	[Changelog]   - Model Baseline has a new parameter error_type
      info	[Changelog]   - Model Baseline has a new parameter timestamps
      info	[Changelog]   - Model Baseline has a new parameter prediction_result_type
      info	[Changelog]   - Model DataCollectionRule has a new parameter immutable_id
      info	[Changelog]   - Model ExtensionDataSource has a new parameter input_data_sources
      info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter resource_location
      info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter metric_namespace
      info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter legacy_resource_id
      info	[Changelog]   - Model CalculateBaselineResponse has a new parameter internal_operation_id
      info	[Changelog]   - Model CalculateBaselineResponse has a new parameter statistics
      info	[Changelog]   - Model CalculateBaselineResponse has a new parameter error_type
      info	[Changelog]   - Model LogSearchRuleResource has a new parameter is_legacy_log_analytics_rule
      info	[Changelog]   - Model LogSearchRuleResource has a new parameter created_with_api_version
      info	[Changelog]   - Model LogSearchRuleResource has a new parameter display_name
      info	[Changelog]   - Model LogSearchRuleResource has a new parameter kind
      info	[Changelog]   - Model LogSearchRuleResource has a new parameter etag
      info	[Changelog]   - Model BaselineResponse has a new parameter internal_operation_id
      info	[Changelog]   - Model BaselineResponse has a new parameter error_type
      info	[Changelog]   - Model BaselineResponse has a new parameter metdata
      info	[Changelog]   - Model BaselineResponse has a new parameter prediction_result_type
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter created_with_api_version
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter display_name
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter is_legacy_log_analytics_rule
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter override_query_time_range
      info	[Changelog]   - Model DataCollectionRuleResourceProperties has a new parameter immutable_id
      info	[Changelog]   - Model AlertRuleResource has a new parameter action
      info	[Changelog]   - Model AlertRuleResource has a new parameter provisioning_state
      info	[Changelog]   - Model ActionGroupResource has a new parameter identity
      info	[Changelog]   - Model ActionGroupResource has a new parameter kind
      info	[Changelog]   - Model AlertRuleResourcePatch has a new parameter action
      info	[Changelog]   - Model AlertRuleResourcePatch has a new parameter provisioning_state
      info	[Changelog]   - Model MetricAlertResourcePatch has a new parameter is_migrated
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter is_legacy_log_analytics_rule
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter override_query_time_range
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter created_with_api_version
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter display_name
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter kind
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter etag
      info	[Changelog]   - Model TimeSeriesBaseline has a new parameter metadata_values
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter scopes of model MetricAlertResource is now required
      info	[Changelog]   - Operation ActivityLogAlertsOperations.create_or_update has a new signature
      info	[Changelog]   - Operation ActivityLogAlertsOperations.update has a new signature
      info	[Changelog]   - Operation SubscriptionDiagnosticSettingsOperations.list has a new signature
      info	[Changelog]   - Operation SubscriptionDiagnosticSettingsOperations.get has a new signature
      info	[Changelog]   - Operation SubscriptionDiagnosticSettingsOperations.delete has a new signature
      info	[Changelog]   - Operation SubscriptionDiagnosticSettingsOperations.create_or_update has a new signature
      info	[Changelog]   - Model ErrorResponse no longer has parameter target
      info	[Changelog]   - Model ErrorResponse no longer has parameter details
      info	[Changelog]   - Model ErrorResponse no longer has parameter additional_info
      info	[Changelog]   - Model BaselineResponse no longer has parameter metadata
      info	[Changelog]   - Model TimeSeriesBaseline no longer has parameter metadata
      info	[Changelog]   - Model PerfCounterDataSource has a new signature
      info	[Changelog]   - Model LogAnalyticsDestination has a new signature
      info	[Changelog]   - Model WindowsEventLogDataSource has a new signature
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b3ee547. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
    • ️✔️monitor [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN
      cmderr	[resource-manager] Using request for node-pre-gyp https download
      cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b3ee547. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ActivityLogAlertsOperations.update
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ActivityLogAlertsOperations.create_or_update has a new signature
      info	[Changelog]   - Model ErrorResponse no longer has parameter additional_info
      info	[Changelog]   - Model ErrorResponse no longer has parameter details
      info	[Changelog]   - Model ErrorResponse no longer has parameter target
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 4, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @avjerafi your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

    @openapi-workflow-bot
    Copy link

    Hi @avjerafi, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 4, 2021
    @avjerafi
    Copy link
    Contributor Author

    avjerafi commented Mar 8, 2021

    Removed the Operations endpoint I've added, because it turns out it is already implemented by another service within Microsoft.Insights provider, at:
    https://github.com/Azure/azure-rest-api-specs/tree/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01

    @avjerafi
    Copy link
    Contributor Author

    avjerafi commented Mar 8, 2021

    Please address the explanation I gave here earlier regarding the absence of an operations endpoint: it already exists and maintained elsewhere, and no changes are required for this new api version that I'm adding. I cannot and should not add the operations endpoint here. Please override the LintDiff failure result.

    Please let me know if there is anything else blocking the approval of this PR that I should/can address. It looks to me that none of the errors listed in the "SDK azure-sdk-for-net" has anything to do with my changes.

    @weidongxu-microsoft
    Copy link
    Member

    weidongxu-microsoft commented Mar 9, 2021

    @avjerafi

    Usually, all related json should be grouped in a single tag for completeness. This way, the operation endpoint will exist and be detected.

    Is there any reason why insights doing these kind of single json tag? Java SDK would need complete tag like "pacakge-2020-03" to function.

    @msyyc @ArcturusZhang Does Python or Go SDK has any comment on this kind of single json tag?

    ### Tag: package-2021-02-preview
    
    These settings apply only when `--tag=package-2021-02-preview` is specified on the command line.
    
    input-file:
    - Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json
    

    @weidongxu-microsoft
    Copy link
    Member

    @avjerafi

    If no objection from other SDK owner, I am OK with this.

    Let me know the target date of this swagger (i.e. when service onboard and you need the spec merged).

    @ArcturusZhang
    Copy link
    Member

    @avjerafi

    Usually, all related json should be grouped in a single tag for completeness. This way, the operation endpoint will exist and be detected.

    Is there any reason why insights doing these kind of single json tag? Java SDK would need complete tag like "pacakge-2020-03" to function.

    @msyyc @ArcturusZhang Does Python or Go SDK has any comment on this kind of single json tag?

    ### Tag: package-2021-02-preview
    
    These settings apply only when `--tag=package-2021-02-preview` is specified on the command line.
    
    input-file:
    - Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json
    

    Go SDK only releases a package with full functionalities in one RP, therefore we will not make a release on this tag.
    I would like to say we need to add this new swagger to one of the composite tag (a new one or exsiting one), but we could defer that until we get a release request. FYI @avjerafi

    @avjerafi
    Copy link
    Contributor Author

    avjerafi commented Mar 9, 2021

    @weidongxu-microsoft The target date for the swagger change is today. Thank you.

    @weidongxu-microsoft weidongxu-microsoft merged commit b3ee547 into Azure:master Mar 9, 2021
    This was referenced Mar 9, 2021
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    * Duplicated existing 2020-05-01-preview folder as the base for 2021-02-01-preview
    
    * Applied changes for 2021-02-01-preview
    
    * Added package tag in readme.md
    
    * Added operations to example payload
    
    * Fixed validation
    
    * Fixed prettier for listOperations
    
    * Removed operation endpoint
    
    * Appliod prettier fixes
    
    Co-authored-by: Avi Jerafi <avjerafi@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Duplicated existing 2020-05-01-preview folder as the base for 2021-02-01-preview
    
    * Applied changes for 2021-02-01-preview
    
    * Added package tag in readme.md
    
    * Added operations to example payload
    
    * Fixed validation
    
    * Fixed prettier for listOperations
    
    * Removed operation endpoint
    
    * Appliod prettier fixes
    
    Co-authored-by: Avi Jerafi <avjerafi@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-LintDiff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python CI-FixRequiredOnFailure
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants