Pprp #13294
Merged
Pprp #13294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @rapatank Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"Duplicate Schema named PrivateLinkResourceListResult -- properties.value.$ref: undefined => "#/components/schemas/schemas:164" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"Duplicate Schema named PrivateLinkResource -- properties.systemData: "description":"Metadata for the private link resource.", "$ref":"#/components/schemas/schemas:102" =>, allOf.0.$ref: undefined => "#/components/schemas/schemas:37" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"Duplicate Schema named Resource -- title: "Resource" =>, properties.location: undefined => "description":"Region where the EnterprisePolicy is located.", "readOnly":true, "$ref":"#/components/schemas/schemas:125" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"Schema 'TrackedResource' has a property 'location' that is conflicting with a property in the parent schema 'Resource' differs more than just description : [readOnly => '', x-ms-mutability => 'read, create']" |
|
"readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"Error: Plugin prechecker reported failure." |
| "readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"The schema 'keyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"The schema 'EnterprisePolicyList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"The schema 'ErrorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"powerplatform/resource-manager/readme.md", "tag":"package-2020-10-30-preview", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
raych1
reviewed
Mar 5, 2021
.gitignore
Outdated
| *.d.ts.map | ||
| /azure-rest-api-specs |
There was a problem hiding this comment.
Can you exclude this file since the change is personal related?
|
Hi @rapatank, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @rapatank, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
raych1
reviewed
Mar 8, 2021
| @@ -279,6 +284,7 @@ | |||
| "properties": { | |||
| "id": { | |||
| "type": "string", | |||
| "pattern": "^/subscriptions/[^/]*/resourceGroups/[^/]*/providers/Microsoft.(ClassicNetwork|Network)/virtualNetworks/[^/]*/subnets/[^/]*$", | |||
There was a problem hiding this comment.
This regex allows double slashes? e.g. /subscriptions//resourceGroups/...
There was a problem hiding this comment.
Actually, this is the same as the patterns other RPs have defined. Examples:
azure-rest-api-specs\specification\redis\resource-manager\Microsoft.Cache\stable\2017-02-01\redis.json
azure-rest-api-specs\specification\apimanagement\resource-manager\Microsoft.ApiManagement\preview\2019-12-01-preview\apimdeployment.json
raych1
added
the
Reviewed-ChangesRequested
|
@rapatank , can you fix the CI check errors? |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-BreakingChange-Go
and removed
CI-FixRequiredOnFailure
labels
raych1
added
the
Approved-BreakingChange
raych1
reviewed
Mar 8, 2021
...ce-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/privateEndpointConnection.json
Show resolved
Hide resolved
raych1
approved these changes
Mar 8, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Update to use common type. * Update .gitignore * Update .gitignore * Revert "Update to use common type." This reverts commit ad02e06. * Delete .gitignore * Updating the models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.