latest master #13300
Merged
latest master #13300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed property. (#13185) * SettingFolder Structure. * Updating SMS communication Swagger json for 1:N , customer content feature. * Updating with review comments. * adding Idempotency header. * Updating name for Idempodency field. * Merging N:1 Changes * fixing integer issue * Updating Read me * fixing lint issue. * Reverting change * Fixing Model issue. * Updating Case for repeatablity header. * Example update in sendjson. * Review comments. * camelCase issue in Send.json. * Fixing example Model. * Model issue fix. * apiversion param issue * Model issue * Model validation. * Review comments. * Addressing API review comments: consolidating to 202Accepted response. * review comments. * review comments * placing response header at right place. * review comments * Modifying wire objects to format [Resource][Method] and adding a flag to response * Review comments * Fixing swagger validations. * review comments. * review comments. * review comments. * review comments. * Swagger validation. * review comments. * review comments * Fix Avocado * Fixing endpoint stuff * review comments * review comments * fix spell * fixes * prettierfix * fix * Revert "fix" This reverts commit 341eaf6. * review comments * review comments * removing acs * Updating swagger for require EnableDelivery report option. * prettier run. Co-authored-by: Ankita Mathur <ankitam@microsoft.com>
* Move to a new API version. * added changes from stable apiVersion * Add nova.json * Add parameters to repair method on cassandraClusters. * Change fetchNodeStatus to be async POST There appears to be no way to document the results of an async POST operation actually completing. * Add 200 status code to fetchNodeStatus to see if it will make the Python SDK properly generate polling. * Fixed the fetchNodeStatus endpoint. It was actually missing x-ms-long-running-operation. Removed the 200 status result I had put in before. * Add async response path for fetchNodeStatus. * Make linter happy. * Rename nova.json to managedCassandra.json * Rename operationIds to be plural. Change status code for repair disabled to 412 (Precondition not met) * Fix javaScript SDK build (which is broken by have */ in descriptions) * added changes from stable apiVersion * Added lenient deduplication to make linter happy * Move fetchNodeStatus back since apparently the SDK generation handles this. * Fix inconsistencies between GA and preview previous API versions for cosmos-db.json. * Add response body to PATCH for clusters and datacenters. * Add provisioningState, to dc examples, remove 412 code, fix a couple descriptions. Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>
* [Graph RBAC] Add top to users op * make it optional * adding x-ms-parameter-location: method
* update python config guide * track1 and track2
* Fix Threat Intelligence Swagger Correctness S360 * Add custom word
* Swagger correctness for Workspaces * Workspaces 2020-08-01
* Swagger correctness issue fix(Additional Property not allowed) * Added custom-word * Removing unused properrty * Ignored Tera * Reverting not related changes * RoundTrip additional property and object additional property S360 fix by adding defaults and renaming respectively * Removed default * Removing some default in older version * Fixed model validation errors and added few more defaults * Fixed Sementic errors * Lint fix * Updated systemData * Description Fix * Fixed spell check * Spell check fix
* Copy existing version to new directory * Update API Version * Introduce new SKU tier enum values * Fix linting issue - introduce required new default property SystemData * Update Readme.md (cherry picked from commit c434161) * update api version to right format * renamed folder * Add swagger file for new resource type Microsoft.PowerBIDedicated/autoScaleVCores * Update powerbidedicated.json Add Mode property * Update powerbidedicated.json Fix words Co-authored-by: Shane Zou <xinzo@microsoft.com>
…to add version preview/2020-07-01-preview (#9805)
… Swagger we checked in on Friday. (#13200)
* ADP: fix cli codegen * Move directive
* Add DocumentExtractionSkill * Fix braces * Update searchservice.json * Add DocumentExtractionSkill to 2020-06-03 * Update searchservice.json * Update searchservice.json * Update searchservice.json
* Add Microsoft.IoTSecurity provider * Run prettier * Add MD * rename files * update MD * resolve the Avocado * Remove unused files * Add operations API * update operations.json * update markdown * remove dot * re-use types * remove comma * Remove duplicated common types * Use ProxyResource * Remove IoT prefix * Add example * undo changes * Run prettier * Use capital letter * run prettier * Add sites, sensors and onPremiseSensors resources * update markdowns * run prettier * Fix broken parameter * Re-trigger Validations * Add systemData * Run prettier * add systemData * Run prettier * Align changes * Undo Microsoft.Security changes * Add systemData to example * Fix PR comments * Update example Co-authored-by: Orel Kayam <orkayam@microsoft.com>
…table/2020-01-01 (#12912) * fixing swagger correctness for OBJECT_ADDITIONAL_PROPERTIES, INVALID_TYPE * resolving validation error - Swagger Correctness fix * correcting validation error - swagger corretness fix * reverting back changes - swagger correctness * reverting some changes as it might require new versioning * changing example and bringing api specs to parity * fixing the comments in PR and added the recommendation plus some validation fixes * prettier fix * model validation fix * model validation fix * fixing lintdiff error * removing the package lock file * Revert "removing the package lock file" This reverts commit 1548442. * reverting previous commit i Please enter the commit message for your changes. Lines starting
…table/2020-03-01 (#12914) * fixing existing api version swagger correctness * fixing the example * fixing arm error in validation - reverting changes as needs to be included in new version * moving the breaking changes to new version * changing example file and bringing api spec in parity with the existing api functionality * adding prettier check validation fix * fixing model validation * cert or pem content is byte format * prettier validation fix * removing lintdiff errors * adding a format type for cert
…ion preview/2020-09-01 (#13213) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Release of Device Update for IoT Hub data plane specification. * Fixing prettier issues. * Fixing spellcheck issues. * Fixing spellcheck in spec examples. Co-authored-by: David Pokluda <david.pokluda@microsoft.com>
* Add SystemData * Make systemdata readonly * Fix typo Co-authored-by: Srinivaas Ganesan <srganesa@microsoft.com>
* [DataFactory]: Add CMK Properties * Prettier validation * Model Identity Type as string * RemoveEnumChanges * Add UAMI to Identity
…ion preview/2020-03-01-preview (#13215) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Release of Device Update for IoT Hub control plane specification. * Fixing prettier issues. * Updating control plane swagger * Update deviceupdate.json * Update deviceupdate.json * Update deviceupdate.json * Update deviceupdate.json * add the multiapi section * Update Accounts_Delete.json * Update Instances_Delete.json Co-authored-by: David Pokluda <david.pokluda@microsoft.com> Co-authored-by: Alexander Batishchev <abatishchev@gmail.com> Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
* Adds base for updating Microsoft.Devices from version preview/2020-08-31-preview to version 2021-02-01-preview * Updates readme * Updates API version in new specs and examples * Update iothub.json Added new Routing Source: DeviceConnectionStateEvents * Update iothub.json Review Comments * Update iothub.json changing modelAsString to false for ResourceIdentityType
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* Update python track2 sdk for deviceupdate * fix
* Added subscriptionId and resourceGroupName in properties to enable cross-sub restore * fix for preview version
xiangyan99
requested review from
brjohnstmsft,
dkulkarni-ms,
grizzlytheodore,
haagha,
heaths,
hectorhdzg,
hyonholee,
jsntcy,
Kishp01,
kjeur,
lmazuel,
lzchen,
madewithsmiles,
MehaKaushik,
MikhailTryakhov,
Mohit-Chakraborty,
MS-syh2qs,
msyyc,
qiaozha,
ramthi,
Sandido,
shurd,
trask,
yangyuan and
yugangw-msft
as code owners
|
Hi, @xiangyan99 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Swagger pipeline started successfully, please wait for status update in this comment. |
1 similar comment
|
Swagger pipeline started successfully, please wait for status update in this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.