[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakuncha
requested review from
ArcturusZhang,
jsntcy,
msyyc and
qiaozha
as code owners
|
Hi, @vakuncha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L35 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1675 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1722 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1825 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1902 |
|
| The operation 'TagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L572 |
|
| The operation 'SubAccountTagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1242 |
|
| The child tracked resource, 'tagRules' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1356 |
|
| The child tracked resource, 'singleSignOnConfigurations' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1356 |
|
| The child tracked resource, 'accounts' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1356 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"logz/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"logz/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"logz/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"logz/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @vakuncha, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 8, 2021
chunyu3
approved these changes
Mar 9, 2021
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
wait Kaihui Sun to fix the python-track2-sdk failure. |
|
For python, it is fake breaking change. Please ignore it. |
This was referenced Mar 15, 2021
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
…iew/2020-10-01-preview (Azure#13317) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * migrated logz from logz repo to main repo * changing double preview to preview * Fixing spell check * copying elastic readme and modifying * Added system data for tag rules * changed orerations reuslt and systemd ata * fix python.md Co-authored-by: 00Kai0 <sunkaihuisos@gmail.com>
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…iew/2020-10-01-preview (Azure#13317) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * migrated logz from logz repo to main repo * changing double preview to preview * Fixing spell check * copying elastic readme and modifying * Added system data for tag rules * changed orerations reuslt and systemd ata * fix python.md Co-authored-by: 00Kai0 <sunkaihuisos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.