Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datadog] Add 2021-03-01 stable version #13330

Merged
merged 13 commits into from
Mar 15, 2021
Merged

Conversation

limingu
Copy link
Member

@limingu limingu commented Mar 9, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @limingu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 9, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 4 Warnings warning [Detail]

    Rule Message
    ⚠️ R4021 - DescriptionAndTitleMissing 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1182
    ⚠️ R4021 - DescriptionAndTitleMissing 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1710
    ⚠️ R4021 - DescriptionAndTitleMissing 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1871
    ⚠️ R4021 - DescriptionAndTitleMissing 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1950
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 43 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L56:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L56:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: common-types/resource-management/v2/types.json#L317:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1265:9
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: common-types/resource-management/v2/types.json#L298:11
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1256:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L108:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L108:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L153:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L153:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L201:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L201:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L253:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L253:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L298:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L298:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L346:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L346:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Datadog/stable/2021-03-01/datadog.json#L394:13
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L394:13
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"datadog/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"datadog/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"datadog/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"datadog/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 9, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91885e6. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /MarketplaceAgreements/put/MarketplaceAgreements_CreateOrUpdate
      cmderr	[Autorest]     - name: /MarketplaceAgreements/get/MarketplaceAgreements_List
      cmderr	[Autorest]     - name: /Monitors/put/Monitors_Create
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_Get
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_List
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_ListByResourceGroup
      cmderr	[Autorest]     - name: /Monitors/patch/Monitors_Update
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_GetDefaultKey
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListApiKeys
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListHosts
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListLinkedResources
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListMonitoredResources
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_RefreshSetPasswordLink
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_SetDefaultKey
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/put/SingleSignOnConfigurations_CreateOrUpdate
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_Get
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_List
      cmderr	[Autorest]     - name: /TagRules/put/TagRules_CreateOrUpdate
      cmderr	[Autorest]     - name: /TagRules/get/TagRules_Get
      cmderr	[Autorest]     - name: /TagRules/get/TagRules_List
      cmderr	[Autorest]     - name: /Monitors/delete/Monitors_Delete
      cmderr	[Autorest] --------------------------------------------------------
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Datadog [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-datadog [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model DatadogAgreementResource has a new parameter system_data
      info	[Changelog]   - Model DatadogMonitorResource has a new parameter system_data
      info	[Changelog]   - Model MonitoringTagRules has a new parameter system_data
      info	[Changelog]   - Model DatadogSingleSignOnResource has a new parameter system_data
      info	[Changelog]   - Added operation MonitorsOperations.create
      info	[Changelog]   - Added operation MonitorsOperations.delete
      info	[Changelog]   - Added operation SingleSignOnConfigurationsOperations.create_or_update
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation TagRulesOperations.list has a new signature
      info	[Changelog]   - Operation TagRulesOperations.get has a new signature
      info	[Changelog]   - Operation SingleSignOnConfigurationsOperations.list has a new signature
      info	[Changelog]   - Operation SingleSignOnConfigurationsOperations.get has a new signature
      info	[Changelog]   - Operation MonitorsOperations.set_default_key has a new signature
      info	[Changelog]   - Operation MonitorsOperations.refresh_set_password_link has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list_monitored_resources has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list_linked_resources has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list_hosts has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list_by_resource_group has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list_api_keys has a new signature
      info	[Changelog]   - Operation MonitorsOperations.get_default_key has a new signature
      info	[Changelog]   - Operation MonitorsOperations.get has a new signature
      info	[Changelog]   - Operation MarketplaceAgreementsOperations.list has a new signature
      info	[Changelog]   - Operation MarketplaceAgreementsOperations.create_or_update has a new signature
      info	[Changelog]   - Operation MonitorsOperations.list has a new signature
      info	[Changelog]   - Operation MonitorsOperations.update has a new signature
      info	[Changelog]   - Operation Operations.list has a new signature
      info	[Changelog]   - Operation TagRulesOperations.create_or_update has a new signature
      info	[Changelog]   - Removed operation MonitorsOperations.begin_delete
      info	[Changelog]   - Removed operation MonitorsOperations.begin_create
      info	[Changelog]   - Removed operation SingleSignOnConfigurationsOperations.begin_create_or_update
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91885e6. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
    • ️✔️datadog [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-datadog [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model MonitoringTagRules has a new parameter system_data
      info	[Changelog]   - Model DatadogSingleSignOnResource has a new parameter system_data
      info	[Changelog]   - Model DatadogMonitorResource has a new parameter system_data
      info	[Changelog]   - Model DatadogAgreementResource has a new parameter system_data
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
    • ️✔️@azure/arm-datadog [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/microsoftDatadogClient.js → ./dist/arm-datadog.js...
      cmderr	[npmPack] created ./dist/arm-datadog.js in 325ms
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-03-15 03:22:16 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datadog;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-03-15 03:22:16 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-03-15 03:22:16 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.20 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datadog/azure-resourcemanager-datadog --java.namespace=com.azure.resourcemanager.datadog   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datadog
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Skip] pom already has module azure-resourcemanager-datadog
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Skip] pom already has module sdk/datadog
      cmderr	[generate.py] 2021-03-15 03:22:51 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-datadog [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG Got artifact_id: azure-resourcemanager-datadog
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG Match jar package: azure-resourcemanager-datadog-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-03-15 03:25:33 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13330/azure-sdk-for-java/azure-resourcemanager-datadog/azure-resourcemanager-datadog-1.0.0-beta.2.jar\" -o azure-resourcemanager-datadog-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datadog -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datadog-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 91885e6. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datadog/mgmt/2021-03-01/datadog [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/datadog/mgmt/2020-02-01-preview/datadog [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @limingu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @limingu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @limingu limingu assigned allenjzhang and unassigned ruowan Mar 9, 2021
    @allenjzhang
    Copy link
    Member

    @ArcturusZhang, can you review Go breaking changes? Please merge if it's good from GO and TF perspective.

    @ArcturusZhang
    Copy link
    Member

    @limingu Did we get the signoff from ARM yet? If this has already been signed off by ARM in private repo, please provide a link for the private PR. Otherwise we need to wait for ARM's feedback

    @ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 12, 2021
    @limingu
    Copy link
    Member Author

    limingu commented Mar 15, 2021

    @limingu Did we get the signoff from ARM yet? If this has already been signed off by ARM in private repo, please provide a link for the private PR. Otherwise we need to wait for ARM's feedback

    This is the PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/3255. It has been signed off from ARM.

    @ruowan
    Copy link
    Member

    ruowan commented Mar 15, 2021

    Merged the PR, the private PR has been signed off and merged.

    @ruowan ruowan merged commit 91885e6 into Azure:master Mar 15, 2021
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    * [Datadog] Add 2021-03-01 stable version
    
    * Update readme
    
    * Fix
    
    * Update
    
    * Fix
    
    * Update
    
    * Prettier
    
    * Revert preview version
    
    * Update versions
    
    * Update
    
    * Add validation for monitor resource name
    
    * Fix LintDiff
    
    * Revert
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * [Datadog] Add 2021-03-01 stable version
    
    * Update readme
    
    * Fix
    
    * Update
    
    * Fix
    
    * Update
    
    * Prettier
    
    * Revert preview version
    
    * Update versions
    
    * Update
    
    * Add validation for monitor resource name
    
    * Fix LintDiff
    
    * Revert
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go CI-BreakingChange-Python WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants