Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go sdk config for network and storagecache #13383

Merged
merged 1 commit into from
Mar 11, 2021
Merged

add go sdk config for network and storagecache #13383

merged 1 commit into from
Mar 11, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Mar 11, 2021 •
edited by yungezz
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@njuCZ njuCZ requested a review from ArcturusZhang as a code owner March 11, 2021 03:33
@openapi-workflow-bot
Copy link

Hi, @njuCZ Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 11, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 11, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d950655. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
cmderr	[npmPack] created ./dist/arm-network.js in 2.4s
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d950655. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/network/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d950655. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
warn		specification/network/resource-manager/readme.md skipped due to azure-cli-extensions not found in swagger-to-sdk
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /AscOperations/get/AscOperations_Get
cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate
cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate_ldap_only
cmderr	[Autorest]     - name: /Caches/get/Caches_Get
cmderr	[Autorest]     - name: /Caches/get/Caches_List
cmderr	[Autorest]     - name: /Caches/get/Caches_ListByResourceGroup
cmderr	[Autorest]     - name: /Caches/patch/Caches_Update
cmderr	[Autorest]     - name: /Caches/patch/Caches_Update_ldap_only
cmderr	[Autorest]     - name: /Caches/post/Caches_DebugInfo
cmderr	[Autorest]     - name: /Caches/post/Caches_Flush
cmderr	[Autorest]     - name: /Caches/post/Caches_Start
cmderr	[Autorest]     - name: /Caches/post/Caches_Stop
cmderr	[Autorest]     - name: /Caches/post/Caches_UpgradeFirmware
cmderr	[Autorest]     - name: /Caches/delete/Caches_Delete
cmderr	[Autorest]     - name: /Skus/get/Skus_List
cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate
cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate_BlobNfs
cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate_NoJunctions
cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_Get
cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_List
cmderr	[Autorest]     - name: /StorageTargets/post/Caches_DnsRefresh
cmderr	[Autorest]     - name: /StorageTargets/delete/StorageTargets_Delete
cmderr	[Autorest]     - name: /UsageModels/get/UsageModels_List
cmderr	[Autorest] --------------------------------------------------------
    • ️✔️storagecache [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d950655. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d950655. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/storagecache/resource-manager/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ServiceEndpointPolicy has a new parameter kind
info	[Changelog]   - Model VirtualNetworkGateway has a new parameter virtual_network_extended_location
info	[Changelog]   - Model VirtualNetworkGateway has a new parameter v_net_extended_location_resource_id
info	[Changelog]   - Model FirewallPolicy has a new parameter insights
info	[Changelog]   - Model FirewallPolicy has a new parameter snat
info	[Changelog]   - Model LoadBalancerBackendAddress has a new parameter subnet
info	[Changelog]   - Model VpnClientConfiguration has a new parameter vpn_authentication_types
info	[Changelog]   - Model VpnConnection has a new parameter traffic_selector_policies
info	[Changelog]   - Added operation VpnLinkConnectionsOperations.begin_get_ike_sas
info	[Changelog]   - Added operation VpnLinkConnectionsOperations.begin_reset_connection
info	[Changelog]   - Added operation VirtualNetworkGatewayConnectionsOperations.begin_reset_connection
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model VirtualNetworkGateway no longer has parameter virtual_network_extended_location_resource_id
info	[Changelog]   - Model VirtualNetworkGateway no longer has parameter extended_location
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d950655. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-11 06:07:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated"
cmderr	[generate.py] 2021-03-11 06:07:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-11 06:07:19 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-11 06:10:35 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Got artifact_id: azure-resourcemanager-network-generated
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-11 06:18:01 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13383/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-03-11 06:20:11 DEBUG Got artifact_id: azure-resourcemanager-storagecache
cmderr	[Inst] 2021-03-11 06:20:11 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-11 06:20:11 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.3.jar
cmderr	[Inst] 2021-03-11 06:20:11 DEBUG Match jar package: azure-resourcemanager-storagecache-1.0.0-beta.3.jar
cmderr	[Inst] 2021-03-11 06:20:11 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13383/azure-sdk-for-java/azure-resourcemanager-storagecache/azure-resourcemanager-storagecache-1.0.0-beta.3.jar\" -o azure-resourcemanager-storagecache-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagecache -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagecache-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Mar 11, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @ArcturusZhang ArcturusZhang merged commit d950655 into Azure:master Mar 11, 2021
    This was referenced Mar 11, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    This was referenced Mar 11, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    @njuCZ @MirzaSikander
    add go sdk config for network and storagecache (Azure#13383)
    3802bac
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @njuCZ @mkarmark
    add go sdk config for network and storagecache (Azure#13383)
    5d152f0
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @njuCZ @ArcturusZhang