Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Data Share : Update readme.md tag to the latest package 2020-09-01 #13430

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Azure Data Share : Update readme.md tag to the latest package 2020-09-01 #13430

merged 1 commit into from
Mar 16, 2021

Conversation

ahermas
Copy link
Contributor

@ahermas ahermas commented Mar 15, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ahermas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 15, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 15, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3f3a82e. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datashare/mgmt/2019-11-01/datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `FillGapWithZero` in struct `OperationMetaMetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️preview/datashare/mgmt/2018-11-01-preview/datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `FillGapWithZero` in struct `OperationMetaMetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3f3a82e. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Accounts/put/Accounts_Create
      cmderr	[Autorest]     - name: /Accounts/get/Accounts_Get
      cmderr	[Autorest]     - name: /Accounts/get/Accounts_ListByResourceGroup
      cmderr	[Autorest]     - name: /Accounts/get/Accounts_ListBySubscription
      cmderr	[Autorest]     - name: /Accounts/patch/Accounts_Update
      cmderr	[Autorest]     - name: /DataSetMappings/put/DataSetMappings_SqlDB_Create
      cmderr	[Autorest]     - name: /DataSetMappings/put/DataSetMappings_SqlDW_Create
      cmderr	[Autorest]     - name: /DataSetMappings/put/DataSetMappings_SqlDWDataSetToAdlsGen2File_Create
      cmderr	[Autorest]     - name: /DataSetMappings/put/DataSetMappings_SynapseWorkspaceSqlPoolTable_Create
      cmderr	[Autorest]     - name: /Shares/put/Shares_Create
      cmderr	[Autorest]     - name: /Shares/get/Shares_Get
      cmderr	[Autorest]     - name: /Shares/get/Shares_ListByAccount
      cmderr	[Autorest]     - name: /Shares/post/Shares_ListSynchronizationDetails
      cmderr	[Autorest]     - name: /Shares/post/Shares_ListSynchronizations
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_Create
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_KustoCluster_Create
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_KustoDatabase_Create
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_SqlDBTable_Create
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_SqlDWTable_Create
      cmderr	[Autorest]     - name: /DataSets/put/DataSets_SynapseWorkspaceSqlPoolTable_Create
      cmderr	[Autorest]     - name: /DataSets/get/DataSets_Get
      cmderr	[Autorest]     - name: /DataSets/get/DataSets_ListByShare
      cmderr	[Autorest]     - name: /DataSets/delete/DataSets_Delete
      cmderr	[Autorest]     - name: /Invitations/put/Invitations_Create
      cmderr	[Autorest]     - name: /Invitations/get/Invitations_Get
      cmderr	[Autorest]     - name: /Invitations/get/Invitations_ListByShare
      cmderr	[Autorest]     - name: /Invitations/delete/Invitations_Delete
      cmderr	[Autorest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_GetByShare
      cmderr	[Autorest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_ListByShare
      cmderr	[Autorest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Adjust
      cmderr	[Autorest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Reinstate
      cmderr	[Autorest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Revoke
      cmderr	[Autorest]     - name: /Shares/delete/Shares_Delete
      cmderr	[Autorest]     - name: /ShareSubscriptions/put/ShareSubscriptions_Create
      cmderr	[Autorest]     - name: /ShareSubscriptions/get/ShareSubscriptions_Get
      cmderr	[Autorest]     - name: /ShareSubscriptions/get/ShareSubscriptions_ListByAccount
      cmderr	[Autorest]     - name: /ShareSubscriptions/post/ShareSubscriptions_CancelSynchronization
      cmderr	[Autorest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSourceShareSynchronizationSettings
      cmderr	[Autorest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizationDetails
      cmderr	[Autorest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizations
      cmderr	[Autorest]     - name: /ShareSubscriptions/post/ShareSubscriptions_Synchronize
      cmderr	[Autorest]     - name: /ShareSubscriptions/delete/ShareSubscriptions_Delete
      cmderr	[Autorest]     - name: /SynchronizationSettings/put/SynchronizationSettings_Create
      cmderr	[Autorest]     - name: /SynchronizationSettings/get/SynchronizationSettings_Get
      cmderr	[Autorest]     - name: /SynchronizationSettings/get/SynchronizationSettings_ListByShare
      cmderr	[Autorest]     - name: /SynchronizationSettings/delete/SynchronizationSettings_Delete
      cmderr	[Autorest]     - name: /Triggers/put/Triggers_Create
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_Get
      cmderr	[Autorest]     - name: /Triggers/get/Triggers_ListByShareSubscription
      cmderr	[Autorest]     - name: /Triggers/delete/Triggers_Delete
      cmderr	[Autorest]     - name: /Accounts/delete/Accounts_Delete
      cmderr	[Autorest]     - name: /ConsumerInvitations/get/ConsumerInvitations_Get
      cmderr	[Autorest]     - name: /ConsumerInvitations/get/ConsumerInvitations_ListInvitations
      cmderr	[Autorest]     - name: /ConsumerInvitations/post/ConsumerInvitations_RejectInvitation
      cmderr	[Autorest]     - name: /ConsumerSourceDataSets/get/ConsumerSourceDataSets_ListByShareSubscription
      cmderr	[Autorest]     - name: /DataSetMappings/put/DataSetMappings_Create
      cmderr	[Autorest]     - name: /DataSetMappings/get/DataSetMappings_Get
      cmderr	[Autorest]     - name: /DataSetMappings/get/DataSetMappings_ListByShareSubscription
      cmderr	[Autorest]     - name: /DataSetMappings/delete/DataSetMappings_Delete
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️datashare [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3f3a82e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-datashare [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Trigger has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FileDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FolderDataSet has a new parameter system_data
      info	[Changelog]   - Model ShareSubscription has a new parameter system_data
      info	[Changelog]   - Model ShareSubscription has a new parameter expiration_date
      info	[Changelog]   - Model SqlDBTableDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model ConsumerSourceDataSet has a new parameter system_data
      info	[Changelog]   - Model BlobContainerDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FileSystemDataSet has a new parameter system_data
      info	[Changelog]   - Model ProviderShareSubscription has a new parameter system_data
      info	[Changelog]   - Model ProviderShareSubscription has a new parameter expiration_date
      info	[Changelog]   - Model ADLSGen1FileDataSet has a new parameter system_data
      info	[Changelog]   - Model Account has a new parameter system_data
      info	[Changelog]   - Model DataSetMapping has a new parameter system_data
      info	[Changelog]   - Model KustoClusterDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model SqlDWTableDataSet has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FolderDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model SynchronizationSetting has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FileDataSet has a new parameter system_data
      info	[Changelog]   - Model ProxyDto has a new parameter system_data
      info	[Changelog]   - Model BlobFolderDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model KustoDatabaseDataSet has a new parameter system_data
      info	[Changelog]   - Model BlobDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model ADLSGen2FileSystemDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model BlobContainerDataSet has a new parameter system_data
      info	[Changelog]   - Model ADLSGen1FolderDataSet has a new parameter system_data
      info	[Changelog]   - Model SqlDWTableDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model Invitation has a new parameter system_data
      info	[Changelog]   - Model Invitation has a new parameter expiration_date
      info	[Changelog]   - Model OperationMetaMetricSpecification has a new parameter fill_gap_with_zero
      info	[Changelog]   - Model SqlDBTableDataSet has a new parameter system_data
      info	[Changelog]   - Model KustoDatabaseDataSetMapping has a new parameter system_data
      info	[Changelog]   - Model KustoClusterDataSet has a new parameter system_data
      info	[Changelog]   - Model BlobFolderDataSet has a new parameter system_data
      info	[Changelog]   - Model DefaultDto has a new parameter system_data
      info	[Changelog]   - Model ScheduledSynchronizationSetting has a new parameter system_data
      info	[Changelog]   - Model DataSet has a new parameter system_data
      info	[Changelog]   - Model BlobDataSet has a new parameter system_data
      info	[Changelog]   - Model ScheduledTrigger has a new parameter system_data
      info	[Changelog]   - Model ConsumerInvitation has a new parameter system_data
      info	[Changelog]   - Model ConsumerInvitation has a new parameter expiration_date
      info	[Changelog]   - Model Share has a new parameter system_data
      info	[Changelog]   - Added operation ProviderShareSubscriptionsOperations.adjust
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ShareSubscriptionsOperations.create has a new signature
      info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
      info	[Changelog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
      info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation DataSetsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation InvitationsOperations.list_by_share has a new signature
      info	[Changelog]   - Operation ProviderShareSubscriptionsOperations.reinstate has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronization_details has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation SharesOperations.list_synchronizations has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.create has a new signature
      info	[Changelog]   - Operation ShareSubscriptionsOperations.list_by_account has a new signature
      info	[Changelog]   - Operation SharesOperations.list_by_account has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3f3a82e. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataShare [View full logs]  [Release SDK Changes]
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 15, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @ahermas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ChenTanyi

    @ahermas
    Copy link
    Contributor Author

    ahermas commented Mar 15, 2021

    I'm raising this PR so to unblock the publishing of the .net sdks for Azure Data Share 2020-09-01 which is currently blocked till this fix goes in.
    Azure/azure-sdk-for-net#18870

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Python WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants