Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LOR extension for CDN custom domain enable/disable https endpoint #13718

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

magodo
Copy link
Contributor

@magodo magodo commented Mar 30, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @magodo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 30, 2021

    Swagger Validation Report

    ️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-04-15/cdn.json#L1586:7
    Old: Microsoft.Cdn/stable/2019-04-15/cdn.json#L1586:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-04-15/cdn.json#L1650:7
    Old: Microsoft.Cdn/stable/2019-04-15/cdn.json#L1649:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-06-15/cdn.json#L1586:7
    Old: Microsoft.Cdn/stable/2019-06-15/cdn.json#L1586:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-06-15/cdn.json#L1650:7
    Old: Microsoft.Cdn/stable/2019-06-15/cdn.json#L1649:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-12-31/cdn.json#L2054:7
    Old: Microsoft.Cdn/stable/2019-12-31/cdn.json#L2054:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2019-12-31/cdn.json#L2118:7
    Old: Microsoft.Cdn/stable/2019-12-31/cdn.json#L2117:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2020-03-31/cdn.json#L2054:7
    Old: Microsoft.Cdn/stable/2020-03-31/cdn.json#L2054:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2020-03-31/cdn.json#L2118:7
    Old: Microsoft.Cdn/stable/2020-03-31/cdn.json#L2117:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2020-04-15/cdn.json#L2054:7
    Old: Microsoft.Cdn/stable/2020-04-15/cdn.json#L2054:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2020-04-15/cdn.json#L2118:7
    Old: Microsoft.Cdn/stable/2020-04-15/cdn.json#L2117:7
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>,
    properties: "name":"x-ms-enum":"name":"DeliveryRuleAction",
    "modelAsString":true,
    "$ref":"#/components/schemas/DeliveryRuleAction",
    "description":"The name of the action for the delivery rule." =>,
    required: ["name"] =>,
    type: undefined => "string",
    enum: undefined => ["CacheExpiration",
    "CacheKeyQueryString",
    "ModifyRequestHeader",
    "ModifyResponseHeader",
    "UrlRedirect",
    "UrlRewrite",
    "UrlSigning",
    "OriginGroupOverride"],
    x-ms-enum: undefined => "name":"DeliveryRuleAction",
    "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-04",
    "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>,
    properties: "name":"x-ms-enum":"name":"DeliveryRuleAction",
    "modelAsString":true,
    "$ref":"#/components/schemas/DeliveryRuleAction",
    "description":"The name of the action for the delivery rule." =>,
    required: ["name"] =>,
    type: undefined => "string",
    enum: undefined => ["CacheExpiration",
    "CacheKeyQueryString",
    "ModifyRequestHeader",
    "ModifyResponseHeader",
    "UrlRedirect",
    "UrlRewrite",
    "UrlSigning"],
    x-ms-enum: undefined => "name":"DeliveryRuleAction",
    "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2020-04",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-12",
    "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>,
    properties: "name":"x-ms-enum":"name":"DeliveryRuleAction",
    "modelAsString":true,
    "$ref":"#/components/schemas/DeliveryRuleAction",
    "description":"The name of the action for the delivery rule." =>,
    required: ["name"] =>,
    type: undefined => "string",
    enum: undefined => ["CacheExpiration",
    "CacheKeyQueryString",
    "ModifyRequestHeader",
    "ModifyResponseHeader",
    "UrlRedirect",
    "UrlRewrite",
    "OriginGroupOverride"],
    x-ms-enum: undefined => "name":"DeliveryRuleAction",
    "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-12",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>,
    properties: "name":"x-ms-enum":"name":"DeliveryRuleAction",
    "modelAsString":true,
    "$ref":"#/components/schemas/DeliveryRuleAction",
    "description":"The name of the action for the delivery rule." =>,
    required: ["name"] =>,
    type: undefined => "string",
    enum: undefined => ["CacheExpiration",
    "CacheKeyQueryString",
    "ModifyRequestHeader",
    "ModifyResponseHeader",
    "UrlRedirect",
    "UrlRewrite"],
    x-ms-enum: undefined => "name":"DeliveryRuleAction",
    "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-04",
    "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>,
    properties: "name":"x-ms-enum":"name":"DeliveryRuleAction",
    "modelAsString":true,
    "$ref":"#/components/schemas/DeliveryRuleAction",
    "description":"The name of the action for the delivery rule." =>,
    required: ["name"] =>,
    type: undefined => "string",
    enum: undefined => ["CacheExpiration",
    "CacheKeyQueryString",
    "ModifyRequestHeader",
    "ModifyResponseHeader",
    "UrlRedirect",
    "UrlRewrite"],
    x-ms-enum: undefined => "name":"DeliveryRuleAction",
    "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"cdn/resource-manager/readme.md",
    "tag":"package-2019-04",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 30, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - 11.0.0
    +	Removed operation CustomDomainsOperations.disable_custom_https
    +	Removed operation CustomDomainsOperations.enable_custom_https
    azure-sdk-for-go - cdn/mgmt/2020-09-01/cdn - v55.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    +	Function `LogAnalyticsClient.GetLogAnalyticsMetricsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string, []string, []string)` to `(context.Context, string, string, []LogMetric, date.Time, date.Time, LogMetricsGranularity, []string, []string, []LogMetricsGroupBy, []string, []string)`
    +	Function `LogAnalyticsClient.GetLogAnalyticsMetrics` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string, []string, []string)` to `(context.Context, string, string, []LogMetric, date.Time, date.Time, LogMetricsGranularity, []string, []string, []LogMetricsGroupBy, []string, []string)`
    +	Function `LogAnalyticsClient.GetLogAnalyticsRankingsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, []string, int32, date.Time, date.Time, []string)` to `(context.Context, string, string, []LogRanking, []LogRankingMetric, int32, date.Time, date.Time, []string)`
    +	Function `LogAnalyticsClient.GetLogAnalyticsRankings` parameter(s) have been changed from `(context.Context, string, string, []string, []string, int32, date.Time, date.Time, []string)` to `(context.Context, string, string, []LogRanking, []LogRankingMetric, int32, date.Time, date.Time, []string)`
    +	Function `LogAnalyticsClient.GetWafLogAnalyticsMetricsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, WafGranularity, []WafAction, []WafRankingGroupBy, []WafRuleType)`
    +	Function `LogAnalyticsClient.GetWafLogAnalyticsMetrics` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, WafGranularity, []WafAction, []WafRankingGroupBy, []WafRuleType)`
    +	Function `LogAnalyticsClient.GetWafLogAnalyticsRankingsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, int32, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, int32, []WafRankingType, []WafAction, []WafRuleType)`
    +	Function `LogAnalyticsClient.GetWafLogAnalyticsRankings` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, int32, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, int32, []WafRankingType, []WafAction, []WafRuleType)`
    +	Function `RuleSetsClient.CreatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, RuleSet)` to `(context.Context, string, string, string)`
    +	Function `RuleSetsClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, RuleSet)` to `(context.Context, string, string, string)`
    azure-sdk-for-go - cdn/mgmt/2020-04-15/cdn - v55.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    azure-sdk-for-go - cdn/mgmt/2019-06-15/cdn - v55.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    azure-sdk-for-go - cdn/mgmt/2019-04-15/cdn - v55.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    +	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    ️✔️azure-sdk-for-go - cdn/mgmt/2017-10-12/cdn - v55.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2017-04-02/cdn - v55.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2016-10-02/cdn - v55.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2016-04-02/cdn - v55.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2015-06-01/cdn - v55.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b0eec0c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CustomDomainsOperations.begin_enable_custom_https
      info	[Changelog]   - Added operation CustomDomainsOperations.begin_disable_custom_https
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation CustomDomainsOperations.disable_custom_https
      info	[Changelog]   - Removed operation CustomDomainsOperations.enable_custom_https
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b0eec0c. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-01 05:51:12 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cdn-generated"
      cmderr	[generate.py] 2021-06-01 05:51:12 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-06-01 05:51:12 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cdn/azure-resourcemanager-cdn-generated --java.namespace=com.azure.resourcemanager.cdn.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [POM][Skip] pom already has module azure-resourcemanager-cdn-generated
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-01 05:52:06 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-cdn-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Got artifact_id: azure-resourcemanager-cdn-generated
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Got artifact: azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG Match jar package: azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-01 05:56:21 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13718/azure-sdk-for-java/azure-resourcemanager-cdn-generated/azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cdn-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cdn-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b0eec0c. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cdn/mgmt/2020-09-01/cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog] - New function `PossibleLogMetricsGranularityValues() []LogMetricsGranularity`
      info	[Changelog] - New function `PossibleWafMetricValues() []WafMetric`
      info	[Changelog] - New function `PossibleLogMetricsGroupByValues() []LogMetricsGroupBy`
      info	[Changelog] - New function `PossibleWafRankingTypeValues() []WafRankingType`
      info	[Changelog] - New function `PossibleWafRuleTypeValues() []WafRuleType`
      info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PossibleWafActionValues() []WafAction`
      info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
      info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `ManagedRuleSetDefinition`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 65 additive change(s).
      info	[Changelog]
    • ️✔️cdn/mgmt/2020-04-15/cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
      info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️cdn/mgmt/2019-06-15/cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
      info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️cdn/mgmt/2019-04-15/cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
      info	[Changelog] - Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
      info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️cdn/mgmt/2017-10-12/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2017-04-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2016-10-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2016-04-02/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cdn/mgmt/2015-06-01/cdn [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b0eec0c. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Cdn [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b0eec0c. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
    • ️✔️@azure/arm-cdn [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/cdnManagementClient.js → ./dist/arm-cdn.js...
      cmderr	[npmPack] created ./dist/arm-cdn.js in 967ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b0eec0c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @jianyexi
    Copy link
    Contributor

    jianyexi commented Apr 1, 2021

    @PhoenixHe-msft could you help with the SDK Automation failure

    @jianyexi
    Copy link
    Contributor

    jianyexi commented Apr 9, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @ghost
    Copy link

    ghost commented Apr 25, 2021

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @magodo
    Copy link
    Contributor Author

    magodo commented Apr 26, 2021

    @jianyexi Anything need to do to make this PR merged?

    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ghost
    Copy link

    ghost commented May 30, 2021

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @magodo
    Copy link
    Contributor Author

    magodo commented Jun 1, 2021

    @jianyexi

    @jianyexi
    Copy link
    Contributor

    jianyexi commented Jun 1, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jianyexi
    Copy link
    Contributor

    jianyexi commented Jun 1, 2021

    I will merge it once the CI passed

    @jianyexi jianyexi added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 1, 2021
    @jianyexi jianyexi merged commit b0eec0c into Azure:master Jun 1, 2021
    This was referenced Jun 1, 2021
    @magodo
    Copy link
    Contributor Author

    magodo commented Jun 3, 2021

    @ShirleyJ27 could you please submit a SDK release request for this change, especially for the Go SDK?

    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants