-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LOR extension for CDN custom domain enable/disable https endpoint #13718
Conversation
Hi, @magodo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2020-09", "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>, properties: "name":"x-ms-enum":"name":"DeliveryRuleAction", "modelAsString":true, "$ref":"#/components/schemas/DeliveryRuleAction", "description":"The name of the action for the delivery rule." =>, required: ["name"] =>, type: undefined => "string", enum: undefined => ["CacheExpiration", "CacheKeyQueryString", "ModifyRequestHeader", "ModifyResponseHeader", "UrlRedirect", "UrlRewrite", "UrlSigning", "OriginGroupOverride"], x-ms-enum: undefined => "name":"DeliveryRuleAction", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2020-09", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2020-04", "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>, properties: "name":"x-ms-enum":"name":"DeliveryRuleAction", "modelAsString":true, "$ref":"#/components/schemas/DeliveryRuleAction", "description":"The name of the action for the delivery rule." =>, required: ["name"] =>, type: undefined => "string", enum: undefined => ["CacheExpiration", "CacheKeyQueryString", "ModifyRequestHeader", "ModifyResponseHeader", "UrlRedirect", "UrlRewrite", "UrlSigning"], x-ms-enum: undefined => "name":"DeliveryRuleAction", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2020-04", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-12", "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>, properties: "name":"x-ms-enum":"name":"DeliveryRuleAction", "modelAsString":true, "$ref":"#/components/schemas/DeliveryRuleAction", "description":"The name of the action for the delivery rule." =>, required: ["name"] =>, type: undefined => "string", enum: undefined => ["CacheExpiration", "CacheKeyQueryString", "ModifyRequestHeader", "ModifyResponseHeader", "UrlRedirect", "UrlRewrite", "OriginGroupOverride"], x-ms-enum: undefined => "name":"DeliveryRuleAction", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-12", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-06", "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>, properties: "name":"x-ms-enum":"name":"DeliveryRuleAction", "modelAsString":true, "$ref":"#/components/schemas/DeliveryRuleAction", "description":"The name of the action for the delivery rule." =>, required: ["name"] =>, type: undefined => "string", enum: undefined => ["CacheExpiration", "CacheKeyQueryString", "ModifyRequestHeader", "ModifyResponseHeader", "UrlRedirect", "UrlRewrite"], x-ms-enum: undefined => "name":"DeliveryRuleAction", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-06", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-04", "details":"Duplicate Schema named DeliveryRuleAction -- discriminator: "propertyName":"name" =>, properties: "name":"x-ms-enum":"name":"DeliveryRuleAction", "modelAsString":true, "$ref":"#/components/schemas/DeliveryRuleAction", "description":"The name of the action for the delivery rule." =>, required: ["name"] =>, type: undefined => "string", enum: undefined => ["CacheExpiration", "CacheKeyQueryString", "ModifyRequestHeader", "ModifyResponseHeader", "UrlRedirect", "UrlRewrite"], x-ms-enum: undefined => "name":"DeliveryRuleAction", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"cdn/resource-manager/readme.md", "tag":"package-2019-04", "details":"Error: Plugin prechecker reported failure." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
@PhoenixHe-msft could you help with the SDK Automation failure |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
@jianyexi Anything need to do to make this PR merged? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I will merge it once the CI passed |
@ShirleyJ27 could you please submit a SDK release request for this change, especially for the Go SDK? |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.