-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anf 10997 NetApp Files update swagger rest api to 2021-02-01 #13814
Anf 10997 NetApp Files update swagger rest api to 2021-02-01 #13814
Conversation
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
/azp run |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Azure Pipelines successfully started running 2 pipeline(s). |
...cation/netapp/resource-manager/Microsoft.NetApp/stable/2021-02-01/examples/Accounts_Get.json
Show resolved
Hide resolved
Note VolumeBackupStatus_Get had to be renamed to Backups_GetStatus on request form Azure CLI team. They demand it be change as it cannot be grouped with backup operations in the CLI due the the operation id. |
specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-02-01/netapp.json
Outdated
Show resolved
Hide resolved
/azp run |
…3814) * Add api-version 2021-02-01 folder * apply udpates * Update readme * update backaupStatus operationid * Update account encryption settings * Pretty * Fix plural * Add x-ms-pageable to AccountBackups_List * change next link * remove tag from backup proxy resource * revert change to 2020-12 * remove tag from backup proxy resource * Add x-ms-pageable to AccountBackups_List * Pretty * Add Snapshotpolicy to volumePatch * Add Snapshotpolicy to volumeupdate example file * Change subscription id in example * Change subscription id in example * pretty * Remove AccountEncryption proptery, some non funcitonal validation warning fixes * Fix example for backupoperators and securityoperators * Remove readme.azureresourceschema.md * Adding tags back to backuppatch, removing needs breaking change reivew * fix prettier Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.