Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix extended location parameter hierarchy #13864

Merged

Conversation

litchiyangMSFT
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @litchiyangMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 9, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2021-02-01/network.json#L221
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces'
    Location: Microsoft.Network/stable/2021-02-01/vmssNetworkInterface.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/networkInterfaces'
    Location: Microsoft.Network/stable/2021-02-01/vmssNetworkInterface.json#L97
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}'
    Location: Microsoft.Network/stable/2021-02-01/vmssNetworkInterface.json#L150
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}/ipConfigurations'
    Location: Microsoft.Network/stable/2021-02-01/vmssNetworkInterface.json#L221
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration"
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 9, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from ae669863e95fe07b2ef55d4643007f8524c20845. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-21 02:04:55 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated"
      cmderr	[generate.py] 2021-04-21 02:04:55 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-04-21 02:04:55 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.24 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-04-21 02:08:13 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Got artifact_id: azure-resourcemanager-network-generated
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-21 02:14:40 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13864/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from ae669863e95fe07b2ef55d4643007f8524c20845. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model LoadBalancingRule has a new parameter backend_address_pools
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter nat_rules
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter extended_location
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter enable_bgp_route_translation_for_nat
      info	[Changelog]   - Model VirtualHub has a new parameter preferred_routing_gateway
      info	[Changelog]   - Model NetworkInterfaceIPConfiguration has a new parameter gateway_load_balancer
      info	[Changelog]   - Model FrontendIPConfiguration has a new parameter gateway_load_balancer
      info	[Changelog]   - Model BackendAddressPool has a new parameter tunnel_interfaces
      info	[Changelog]   - Model VirtualNetworkGatewayConnection has a new parameter egress_nat_rules
      info	[Changelog]   - Model VirtualNetworkGatewayConnection has a new parameter ingress_nat_rules
      info	[Changelog]   - Model CustomIpPrefix has a new parameter child_custom_ip_prefixes
      info	[Changelog]   - Model CustomIpPrefix has a new parameter failed_reason
      info	[Changelog]   - Model CustomIpPrefix has a new parameter custom_ip_prefix_parent
      info	[Changelog]   - Model CustomIpPrefix has a new parameter authorization_message
      info	[Changelog]   - Model CustomIpPrefix has a new parameter signed_message
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter peering_sync_level
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter remote_virtual_network_address_space
      info	[Changelog]   - Model VirtualNetwork has a new parameter flow_timeout_in_minutes
      info	[Changelog]   - Added operation LoadBalancersOperations.begin_swap_public_ip_addresses
      info	[Changelog]   - Added operation group VirtualNetworkGatewayNatRulesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation VirtualNetworkPeeringsOperations.begin_create_or_update has a new signature
      info	[Changelog]   - Model VirtualNetworkGateway no longer has parameter virtual_network_extended_location
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ae669863e95fe07b2ef55d4643007f8524c20845. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ae669863e95fe07b2ef55d4643007f8524c20845. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
    • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
      cmderr	[npmPack] created ./dist/arm-network.js in 3s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from ae669863e95fe07b2ef55d4643007f8524c20845. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @lirenhe
    Copy link
    Member

    lirenhe commented Apr 12, 2021

    @litchiyangMSFT, it looks this is a breaking change compared with the latest API version, please go through the breaking change review process.

    @openapi-workflow-bot
    Copy link

    Hi @litchiyangMSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @lirenhe
    Copy link
    Member

    lirenhe commented Apr 21, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe lirenhe merged commit 4d7132d into Azure:network-february-release Apr 21, 2021
    lirenhe pushed a commit that referenced this pull request May 11, 2021
    * Adds base for updating Microsoft.Network from version stable/2020-11-01 to version 2021-02-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * init (#13496)
    
    Co-authored-by: matyang222 <matthew.yang@microsoft.com>
    
    * Swagger change for CustomIpPrefix. Adding four new attributes.  (#13456)
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add
    
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    
    * typo: paramter in applicationGateway.json (#13538)
    
    * VPN NAT for Virtual Network Gateway feature changes(networkFeb) (#13481)
    
    * commit1
    
    * commit2
    
    * resolving comments
    
    * pythonMd
    
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    
    * fix virtual network resource (#13570)
    
    * Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (#13519)
    
    * Added a new feature FlowTimeoutInMinutes under Virtual Network Properties
    
    * Updated the type from string to integer, added a non-null example
    
    * Added missing format for 'integer' type
    
    * Add new failedMessage property for CustomIpPrefix (#13607)
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add
    
    * add failedreason property
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add failedreason property
    
    * update
    
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    
    * Added Preferred Routing Gateway Support (#13611)
    
    * Feature: Address space update in peered vNets (#13521)
    
    * Adding new fields and operation to support the address space update in peered vNets
    
    Adding new fields and operation to support the address space update in peered vNets
    
    * Adding the new query param in the example
    
    As per the review comment, adding the new query param in the example request response of swagger.
    
    * Adding the new query param in examples
    
    Adding the new query param in examples
    
    * Restricting the sync param
    
    Restricting the sync param to hold only true as value. We never need to send false.
    
    Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
    
    * Remove max file size limit enforcement as it is done in NRP (#13679)
    
    * Tesha/fix waf policy examples crs version (#13697)
    
    * Remove max file size limit enforcement as it is done in NRP
    
    * Update the CRS version in the examples to reflect latest
    
    * Fix (#13734)
    
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    
    * Swagger for NRP's VipSwap operation (#13639)
    
    * Swagger for NRP's VipSwap operation
    
    * Fixing validation errors
    
    * minor fix
    
    * Adding api version
    
    * Remove required (#13969)
    
    Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
    
    * Hotfix extended location parameter hierarchy (#13864)
    
    * add to feb branch
    
    * delete project name reference
    
    * expose two new client cert properties: validatedCertData, clientCertIssuerDN (#13989)
    
    * adding workloadType property for Baremetal scenarios (#14101)
    
    * Added bastion sku (#14248)
    
    * fix nrp resources based on s360 checks (#14219)
    
    * Adding Azure Network Manager association to the EffectiveNetworkSecurityGroups API (#14265)
    
    * Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation
    
    * Adding example for networkManager response in the EffectiveNSG call
    
    * Add deleteOption to PublicIPAddress (#14343)
    
    * Add deleteOption to PublicIPAddress
    
    * run validators
    
    Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
    
    Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com>
    Co-authored-by: matyang222 <matthew.yang@microsoft.com>
    Co-authored-by: Tom Li <weihengli.tj@gmail.com>
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    Co-authored-by: Nick Schonning <nschonni@gmail.com>
    Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com>
    Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
    Co-authored-by: arvenka <arvenka@microsoft.com>
    Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
    Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
    Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
    Co-authored-by: shnaya434 <67019054+shnaya434@users.noreply.github.com>
    Co-authored-by: William Ehrich <wdehrich@gmail.com>
    Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
    Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
    Co-authored-by: biaogao <biga@microsoft.com>
    Co-authored-by: bhbhise <83041483+bhbhise@users.noreply.github.com>
    Co-authored-by: mscorp-buchen <78105006+mscorp-buchen@users.noreply.github.com>
    Co-authored-by: Arpit Agarwal <83313290+aragar740@users.noreply.github.com>
    Co-authored-by: basharg <basharg@microsoft.com>
    Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Adds base for updating Microsoft.Network from version stable/2020-11-01 to version 2021-02-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * init (Azure#13496)
    
    Co-authored-by: matyang222 <matthew.yang@microsoft.com>
    
    * Swagger change for CustomIpPrefix. Adding four new attributes.  (Azure#13456)
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add
    
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    
    * typo: paramter in applicationGateway.json (Azure#13538)
    
    * VPN NAT for Virtual Network Gateway feature changes(networkFeb) (Azure#13481)
    
    * commit1
    
    * commit2
    
    * resolving comments
    
    * pythonMd
    
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    
    * fix virtual network resource (Azure#13570)
    
    * Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (Azure#13519)
    
    * Added a new feature FlowTimeoutInMinutes under Virtual Network Properties
    
    * Updated the type from string to integer, added a non-null example
    
    * Added missing format for 'integer' type
    
    * Add new failedMessage property for CustomIpPrefix (Azure#13607)
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add
    
    * add failedreason property
    
    * update swagger
    
    * fix apiversion
    
    * fix
    
    * add failedreason property
    
    * update
    
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    
    * Added Preferred Routing Gateway Support (Azure#13611)
    
    * Feature: Address space update in peered vNets (Azure#13521)
    
    * Adding new fields and operation to support the address space update in peered vNets
    
    Adding new fields and operation to support the address space update in peered vNets
    
    * Adding the new query param in the example
    
    As per the review comment, adding the new query param in the example request response of swagger.
    
    * Adding the new query param in examples
    
    Adding the new query param in examples
    
    * Restricting the sync param
    
    Restricting the sync param to hold only true as value. We never need to send false.
    
    Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
    
    * Remove max file size limit enforcement as it is done in NRP (Azure#13679)
    
    * Tesha/fix waf policy examples crs version (Azure#13697)
    
    * Remove max file size limit enforcement as it is done in NRP
    
    * Update the CRS version in the examples to reflect latest
    
    * Fix (Azure#13734)
    
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    
    * Swagger for NRP's VipSwap operation (Azure#13639)
    
    * Swagger for NRP's VipSwap operation
    
    * Fixing validation errors
    
    * minor fix
    
    * Adding api version
    
    * Remove required (Azure#13969)
    
    Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
    
    * Hotfix extended location parameter hierarchy (Azure#13864)
    
    * add to feb branch
    
    * delete project name reference
    
    * expose two new client cert properties: validatedCertData, clientCertIssuerDN (Azure#13989)
    
    * adding workloadType property for Baremetal scenarios (Azure#14101)
    
    * Added bastion sku (Azure#14248)
    
    * fix nrp resources based on s360 checks (Azure#14219)
    
    * Adding Azure Network Manager association to the EffectiveNetworkSecurityGroups API (Azure#14265)
    
    * Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation
    
    * Adding example for networkManager response in the EffectiveNSG call
    
    * Add deleteOption to PublicIPAddress (Azure#14343)
    
    * Add deleteOption to PublicIPAddress
    
    * run validators
    
    Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
    
    Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com>
    Co-authored-by: matyang222 <matthew.yang@microsoft.com>
    Co-authored-by: Tom Li <weihengli.tj@gmail.com>
    Co-authored-by: Weiheng Li <weihl@microsoft.com>
    Co-authored-by: Nick Schonning <nschonni@gmail.com>
    Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com>
    Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
    Co-authored-by: arvenka <arvenka@microsoft.com>
    Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
    Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
    Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
    Co-authored-by: shnaya434 <67019054+shnaya434@users.noreply.github.com>
    Co-authored-by: William Ehrich <wdehrich@gmail.com>
    Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
    Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
    Co-authored-by: biaogao <biga@microsoft.com>
    Co-authored-by: bhbhise <83041483+bhbhise@users.noreply.github.com>
    Co-authored-by: mscorp-buchen <78105006+mscorp-buchen@users.noreply.github.com>
    Co-authored-by: Arpit Agarwal <83313290+aragar740@users.noreply.github.com>
    Co-authored-by: basharg <basharg@microsoft.com>
    Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants