[Hub Generated] Public private branch 'add-ingressStartAt' #13932

riserrad · 2021-04-14T16:18:45Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

remove .npmrc

fix prettier

riserrad · 2021-04-14T16:18:46Z

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/3012

openapi-workflow-bot · 2021-04-14T16:18:48Z

Hi, @riserrad Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-04-14T16:18:48Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-14T16:18:50Z

Swagger Validation Report

️❌BreakingChange: 14 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2020-05-15/timeseriesinsights.json compared with base:stable/2020-05-15/timeseriesinsights.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1414:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1411:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1944:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1916:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1414:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1411:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1414:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1411:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1944:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1916:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1944:9 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1916:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'kind' that was not found in the old version. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L209:13 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L209:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'kind' that was not found in the old version. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L492:13 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L489:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'kind' that was not found in the old version. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1410:5 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1407:5
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'kind' that was not found in the old version. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1439:5 Old: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L1434:5

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- timeseriesinsights/resource-manager/readme.md tag:package-2020-05-15
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- timeseriesinsights/resource-manager/readme.md tag:package-2020-05-15

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Environments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L140
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'EventSources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L418
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ReferenceDataSets_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L665
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'AccessPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L912
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Environments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L74
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'EventSources_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L350
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ReferenceDataSets_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L600
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'AccessPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L847
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Environments_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L183
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'EventSources_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L461

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

timeseriesinsights/resource-manager/readme.md#package-2020-05-15

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"timeseriesinsights/resource-manager/readme.md",
"tag":"package-2020-05-15",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"timeseriesinsights/resource-manager/readme.md",
"tag":"package-2020-05-15",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"timeseriesinsights/resource-manager/readme.md",
"tag":"package-2020-05-15",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-14T16:18:51Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - timeseriesinsights/mgmt/2020-05-15/timeseriesinsights - Approved - v55.1.0

+	Field `CreationTime` of struct `Gen1EnvironmentResourceProperties` has been removed
+	Field `ProvisioningState` of struct `Gen1EnvironmentResourceProperties` has been removed
+	Function `EnvironmentsClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, EnvironmentUpdateParameters)` to `(context.Context, string, string, BasicEnvironmentUpdateParameters)`
+	Function `EnvironmentsClient.Update` parameter(s) have been changed from `(context.Context, string, string, EnvironmentUpdateParameters)` to `(context.Context, string, string, BasicEnvironmentUpdateParameters)`
+	Function `EventSourcesClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, EventSourceUpdateParameters)` to `(context.Context, string, string, string, BasicEventSourceUpdateParameters)`
+	Function `EventSourcesClient.Update` parameter(s) have been changed from `(context.Context, string, string, string, EventSourceUpdateParameters)` to `(context.Context, string, string, string, BasicEventSourceUpdateParameters)`

️✔️azure-sdk-for-go - timeseriesinsights/mgmt/2017-11-15/timeseriesinsights - Approved - v55.1.0
️✔️azure-sdk-for-go - preview/timeseriesinsights/mgmt/2018-08-15-preview/timeseriesinsights - Approved - v55.1.0
️✔️azure-sdk-for-go - preview/timeseriesinsights/mgmt/2017-02-28-preview/timeseriesinsights - Approved - v55.1.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-timeseriesinsights - 1.0.0

+	Parameter kind of model EnvironmentUpdateParameters is now required
+	Parameter kind of model EventHubEventSourceUpdateParameters is now required
+	Parameter kind of model EventSourceUpdateParameters is now required
+	Parameter kind of model Gen1EnvironmentUpdateParameters is now required
+	Parameter kind of model Gen2EnvironmentUpdateParameters is now required
+	Parameter kind of model IoTHubEventSourceUpdateParameters is now required

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 7355875. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.5.0/node_modules/@octokit/request/dist-node/index.js:76:23
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

️✔️Az.TimeSeriesInsights [View full logs]

Az.TimeSeriesInsights.0.1.0.nupkg

error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.TimeSeriesInsights

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7355875. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️timeseriesinsights/mgmt/2020-05-15/timeseriesinsights [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 30 items here, please refer to log for details.

info	[Changelog] - New function `EnvironmentUpdateParameters.AsBasicEnvironmentUpdateParameters() (BasicEnvironmentUpdateParameters, bool)`
info	[Changelog] - New function `*EventHubEventSourceResourceProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `EnvironmentUpdateParameters.AsEnvironmentUpdateParameters() (*EnvironmentUpdateParameters, bool)`
info	[Changelog] - New function `*EventHubEventSourceCreationProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleKindBasicEnvironmentUpdateParametersValues() []KindBasicEnvironmentUpdateParameters`
info	[Changelog] - New function `EventHubEventSourceUpdateParameters.AsIoTHubEventSourceUpdateParameters() (*IoTHubEventSourceUpdateParameters, bool)`
info	[Changelog] - New function `EventSourceUpdateParameters.AsIoTHubEventSourceUpdateParameters() (*IoTHubEventSourceUpdateParameters, bool)`
info	[Changelog] - New function `EventSourceUpdateParameters.AsEventHubEventSourceUpdateParameters() (*EventHubEventSourceUpdateParameters, bool)`
info	[Changelog] - New function `Gen1EnvironmentUpdateParameters.AsBasicEnvironmentUpdateParameters() (BasicEnvironmentUpdateParameters, bool)`
info	[Changelog] - New function `IoTHubEventSourceUpdateParameters.AsEventSourceUpdateParameters() (*EventSourceUpdateParameters, bool)`
info	[Changelog] - New function `Gen2EnvironmentUpdateParameters.AsEnvironmentUpdateParameters() (*EnvironmentUpdateParameters, bool)`
info	[Changelog] - New function `*EventHubEventSourceCommonProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `IngressStartAtProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceCommonProperties`
info	[Changelog] - New field `Kind` in struct `Gen2EnvironmentUpdateParameters`
info	[Changelog] - New field `Kind` in struct `EnvironmentUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceResourceProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceCommonProperties`
info	[Changelog] - New field `Kind` in struct `EventHubEventSourceUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventSourceCommonProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceCreationProperties`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `AzureEventSourceProperties`
info	[Changelog] - New field `Kind` in struct `IoTHubEventSourceUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `EventHubEventSourceResourceProperties`
info	[Changelog] - New field `Kind` in struct `Gen1EnvironmentUpdateParameters`
info	[Changelog] - New anonymous field `*IngressStartAtProperties` in struct `IoTHubEventSourceCreationProperties`
info	[Changelog] - New field `Kind` in struct `EventSourceUpdateParameters`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 62 additive change(s).
info	[Changelog]

️✔️timeseriesinsights/mgmt/2017-11-15/timeseriesinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/timeseriesinsights/mgmt/2018-08-15-preview/timeseriesinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/timeseriesinsights/mgmt/2017-02-28-preview/timeseriesinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7355875. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/timeseriesinsights/resource-manager/readme.md

️✔️@azure/arm-timeseriesinsights [View full logs] [Release SDK Changes]

azure-arm-timeseriesinsights-1.2.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/timeSeriesInsightsClient.js → ./dist/arm-timeseriesinsights.js...
cmderr	[npmPack] created ./dist/arm-timeseriesinsights.js in 420ms

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 7355875. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-timeseriesinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model EventSourceCreateOrUpdateParameters has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter io_thub_event_source_resource_type
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter time
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter type
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter event_hub_event_source_resource_type
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter time
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation EnvironmentsOperations.update has a new signature
info	[Changelog]   - Operation EventSourcesOperations.update has a new signature
info	[Changelog]   - Model EnvironmentUpdateParameters has a new required parameter kind
info	[Changelog]   - Model IoTHubEventSourceUpdateParameters has a new required parameter kind
info	[Changelog]   - Model EventSourceUpdateParameters has a new required parameter kind
info	[Changelog]   - Model EventHubEventSourceUpdateParameters has a new required parameter kind

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 7355875. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-timeseriesinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCreationProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCreationProperties has a new parameter time
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model EventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter type_properties_ingress_start_at_type
info	[Changelog]   - Model IoTHubEventSourceResource has a new parameter time
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter type
info	[Changelog]   - Model AzureEventSourceProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCreationProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCreationProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceCommonProperties has a new parameter time
info	[Changelog]   - Model EventHubEventSourceResourceProperties has a new parameter type
info	[Changelog]   - Model EventHubEventSourceResourceProperties has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter time
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter type_properties_ingress_start_at_type
info	[Changelog]   - Model EventHubEventSourceResource has a new parameter time
info	[Changelog]   - Model IoTHubEventSourceResourceProperties has a new parameter type
info	[Changelog]   - Model IoTHubEventSourceResourceProperties has a new parameter time
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter kind of model Gen2EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model IoTHubEventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model Gen1EnvironmentUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventHubEventSourceUpdateParameters is now required
info	[Changelog]   - Parameter kind of model EventSourceUpdateParameters is now required

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7355875. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️timeseriesinsights [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

riserrad · 2021-04-14T17:16:54Z

Hi - about this Python SDK failure: it seems to be happening at an unchanged portion of the spec, and we don't have a python SDK.

Changing this would require some other validations and we don't want to do that for this GA api-version.

Can we disregard this warning for this change?

zhenglaizhang · 2021-04-16T02:42:19Z

Hi - about this Python SDK failure: it seems to be happening at an unchanged portion of the spec, and we don't have a python SDK.

Changing this would require some other validations and we don't want to do that for this GA api-version.

Can we disregard this warning for this change?

@msyyc pls help double check the python sdk failure

zhenglaizhang · 2021-04-16T02:43:22Z

@riserrad it's suggested to fix the lintdiff warning here to keep high quality #13932 (comment)

riserrad · 2021-04-16T04:14:54Z

@riserrad it's suggested to fix the lintdiff warning here to keep high quality #13932 (comment)

Sure @zhenglaizhang - I just added a description to the field, according to the warning's instruction.

riserrad · 2021-04-20T19:49:54Z

Hi - about this Python SDK failure: it seems to be happening at an unchanged portion of the spec, and we don't have a python SDK.
Changing this would require some other validations and we don't want to do that for this GA api-version.
Can we disregard this warning for this change?

@msyyc pls help double check the python sdk failure

Hi @msyyc , @zhenglaizhang - following up on this to have this PR checked in if possible.

openapi-workflow-bot · 2021-04-21T02:56:10Z

Hi @riserrad, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

zhenglaizhang · 2021-04-21T02:57:49Z

Hi @riserrad you are adding one optional property and making this public, pls go through breaking change review process per #13932 (comment)

riserrad · 2021-04-28T23:35:57Z

Hi @riserrad you are adding one optional property and making this public, pls go through breaking change review process per #13932 (comment)

Started the process. Given the current schedule, we're going to attend the Office Hours meeting in May 10th.

riserrad · 2021-05-21T21:52:16Z

Hi @zhenglaizhang - do you have an ETA of when this is going to be merged?

Thanks

zhenglaizhang · 2021-05-28T13:44:11Z

Hi @msyyc the sdk python track 2 failed, could you help take a look?

zhenglaizhang · 2021-05-28T14:00:26Z

/azp run

azure-pipelines · 2021-05-28T14:02:26Z

Azure Pipelines successfully started running 1 pipeline(s).

msyyc · 2021-06-02T05:09:29Z

For python, I have helped to fix the failure and the breaking change is expected

zhenglaizhang · 2021-06-09T08:57:48Z

Hi @ArcturusZhang pls help double check if go sdk breaking change is expected.

…'add-ingressStartAt' (#1762) Create to sync Azure/azure-rest-api-specs#13932 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/timeseriesinsights?expand=1)

* add ingressStartAt * prettier * add a new example * Delete .npmrc remove .npmrc * fix prettier fix prettier * put readonly back for kind * Adding descriptin to ingressStartAt * fix failure for python track2 * Removing readonly from kind Co-authored-by: Go Blue <zth@umich.edu> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

GoBlueCats added 6 commits February 18, 2021 17:35

add ingressStartAt

9f5c255

prettier

8a2a18a

add a new example

a84b339

Delete .npmrc

35d8a02

remove .npmrc

fix prettier

7922cce

fix prettier

put readonly back for kind

829c04c

openapi-assignment-bot bot assigned raych1 Apr 14, 2021

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Go labels Apr 14, 2021

openapi-sdkautomation bot mentioned this pull request Apr 14, 2021

[AutoPR Az.TimeSeriesInsights] [Hub Generated] Public private branch 'add-ingressStartAt' AzureSDKAutomation/azure-powershell#318

Closed

raych1 assigned zhenglaizhang and unassigned raych1 Apr 15, 2021

Adding descriptin to ingressStartAt

b99f990

zhenglaizhang added the BreakingChangeReviewRequired label Apr 21, 2021

ghost removed the no-recent-activity label May 16, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 17, 2021

JeffreyRichter approved these changes May 17, 2021

View reviewed changes

openapi-sdkautomation bot mentioned this pull request May 28, 2021

[AutoPR azure-mgmt-timeseriesinsights] [Hub Generated] Public private branch 'add-ingressStartAt' AzureSDKAutomation/azure-sdk-for-python#5778

Closed

fix failure for python track2

344f64a

openapi-sdkautomation bot mentioned this pull request Jun 2, 2021

[AutoPR track2_azure-mgmt-timeseriesinsights] [Hub Generated] Public private branch 'add-ingressStartAt' AzureSDKAutomation/azure-sdk-for-python#5827

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Jun 2, 2021

Removing readonly from kind

60587c8

ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 15, 2021

zhenglaizhang added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 15, 2021

zhenglaizhang merged commit 7355875 into master Jun 15, 2021

JackTn deleted the published/GoBlueCats/azure-rest-api-specs-pr/add-ingressStartAt branch June 16, 2022 00:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Public private branch 'add-ingressStartAt' #13932

[Hub Generated] Public private branch 'add-ingressStartAt' #13932

riserrad commented Apr 14, 2021 •

edited

Loading

riserrad commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

Breaking Changes Tracking

riserrad commented Apr 14, 2021

zhenglaizhang commented Apr 16, 2021

zhenglaizhang commented Apr 16, 2021

riserrad commented Apr 16, 2021

riserrad commented Apr 20, 2021

openapi-workflow-bot bot commented Apr 21, 2021

zhenglaizhang commented Apr 21, 2021

riserrad commented Apr 28, 2021

riserrad commented May 21, 2021

zhenglaizhang commented May 28, 2021

zhenglaizhang commented May 28, 2021

azure-pipelines bot commented May 28, 2021

msyyc commented Jun 2, 2021

zhenglaizhang commented Jun 9, 2021

[Hub Generated] Public private branch 'add-ingressStartAt' #13932

[Hub Generated] Public private branch 'add-ingressStartAt' #13932

Conversation

riserrad commented Apr 14, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

riserrad commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-workflow-bot bot commented Apr 14, 2021

openapi-pipeline-app bot commented Apr 14, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 14, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

riserrad commented Apr 14, 2021

zhenglaizhang commented Apr 16, 2021

zhenglaizhang commented Apr 16, 2021

riserrad commented Apr 16, 2021

riserrad commented Apr 20, 2021

openapi-workflow-bot bot commented Apr 21, 2021

zhenglaizhang commented Apr 21, 2021

riserrad commented Apr 28, 2021

riserrad commented May 21, 2021

zhenglaizhang commented May 28, 2021

zhenglaizhang commented May 28, 2021

azure-pipelines bot commented May 28, 2021

msyyc commented Jun 2, 2021

zhenglaizhang commented Jun 9, 2021

riserrad commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 14, 2021 •

edited

Loading