Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview #13992

Merged
merged 30 commits into from
Apr 20, 2021
Merged

Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview #13992

merged 30 commits into from
Apr 20, 2021

Conversation

NarayanThiru
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…ration-2021-05-01-preview' of https://github.com/Azure/azure-rest-api-specs into dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview
@openapi-workflow-bot
Copy link

Hi, @NarayanThiru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @NarayanThiru NarayanThiru assigned chunyu3 and unassigned jianyexi Apr 16, 2021
    @NarayanThiru NarayanThiru added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 16, 2021
    @openapi-workflow-bot
    Copy link

    Hi @NarayanThiru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 17, 2021
    @NarayanThiru
    Copy link
    Member Author

    Hi @chunyu3 , we have the ARM sign off. Can you please help merge this?

    @chunyu3 chunyu3 merged commit 083256c into Azure:dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview Apr 20, 2021
    jianyexi pushed a commit that referenced this pull request May 19, 2021
    …5 01 preview (#14302)
    
    * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add Extensions Async API and other fixes (#13709)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Revert "Add Extensions Async API and other fixes (#13709)" (#13972)
    
    This reverts commit b78af6e.
    
    * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (#13992)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Remove extensions resource in the route of ListAsyncOperations at Cluster scope
    
    * Remove extension parameter in the spec
    
    * Remove extension parameter from route of ListAsycOperations
    
    * Add Origin property to Available Operations response body
    
    * Make Identity property nullable
    
    * Add Get, List Extension Types (#13562)
    
    * Add Get, List Extension Types
    
    * style check fixes
    
    * - update spec
    - rename and update example files
    - fix validation errors
    
    * fix examples
    
    * - update readme.md
    - generate example files with oav
    - try to fix some new validation errors
    
    * more validation fixes
    
    * add ExtensionTypeVersion_List
    
    * - update readme for SDKs
    - update examples
    
    * fix typo and linting
    
    * rename ExtensionTypeVersions_List
    
    * - address comments
    - update list extension versions based on location
    
    * fix list versions route
    
    * fix tag and unused parameters in spec file
    
    * fix autorest validatoin errors
    
    * udpate readme
    
    * update readme
    
    * try to fix sdk validation warnings
    
    * - prettier fix
    - revert changes to types.json
    
    * fix pageable missing itemName
    
    Co-authored-by: Carlo Cardella <carloc@microsoft.com>
    Co-authored-by: chunyu3 <chunyu@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …5 01 preview (Azure#14302)
    
    * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add Extensions Async API and other fixes (Azure#13709)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972)
    
    This reverts commit b78af6e.
    
    * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Remove extensions resource in the route of ListAsyncOperations at Cluster scope
    
    * Remove extension parameter in the spec
    
    * Remove extension parameter from route of ListAsycOperations
    
    * Add Origin property to Available Operations response body
    
    * Make Identity property nullable
    
    * Add Get, List Extension Types (Azure#13562)
    
    * Add Get, List Extension Types
    
    * style check fixes
    
    * - update spec
    - rename and update example files
    - fix validation errors
    
    * fix examples
    
    * - update readme.md
    - generate example files with oav
    - try to fix some new validation errors
    
    * more validation fixes
    
    * add ExtensionTypeVersion_List
    
    * - update readme for SDKs
    - update examples
    
    * fix typo and linting
    
    * rename ExtensionTypeVersions_List
    
    * - address comments
    - update list extension versions based on location
    
    * fix list versions route
    
    * fix tag and unused parameters in spec file
    
    * fix autorest validatoin errors
    
    * udpate readme
    
    * update readme
    
    * try to fix sdk validation warnings
    
    * - prettier fix
    - revert changes to types.json
    
    * fix pageable missing itemName
    
    Co-authored-by: Carlo Cardella <carloc@microsoft.com>
    Co-authored-by: chunyu3 <chunyu@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants