Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add acr managed identity properties to web app #14187

Merged

Conversation

SorenMaagaard
Copy link
Contributor

@SorenMaagaard SorenMaagaard commented Apr 29, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@SorenMaagaard SorenMaagaard requested a review from naveedaz as a code owner April 29, 2021 09:18
@openapi-workflow-bot
Copy link

Hi, @SorenMaagaard Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 29, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-10",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 29, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/web/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.WebSites [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-web [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Model LoginScopes no longer has parameter system_data
      info	[Changelog]   - Model AppServicePlan no longer has parameter system_data
      info	[Changelog]   - Model VnetRoute no longer has parameter system_data
      info	[Changelog]   - Model Certificate no longer has parameter system_data
      info	[Changelog]   - Model RelayServiceConnectionEntity no longer has parameter system_data
      info	[Changelog]   - Model ProcessInfo no longer has parameter system_data
      info	[Changelog]   - Model SlotConfigNamesResource no longer has parameter system_data
      info	[Changelog]   - Model DomainPatchResource no longer has parameter system_data
      info	[Changelog]   - Model MigrateMySqlStatus no longer has parameter system_data
      info	[Changelog]   - Model CustomOpenIdConnectProvider no longer has parameter system_data
      info	[Changelog]   - Model ResourceHealthMetadata no longer has parameter system_data
      info	[Changelog]   - Model VnetValidationFailureDetails no longer has parameter system_data
      info	[Changelog]   - Model DetectorDefinition no longer has parameter system_data
      info	[Changelog]   - Model Login no longer has parameter system_data
      info	[Changelog]   - Model StaticSitesWorkflowPreviewRequest no longer has parameter system_data
      info	[Changelog]   - Model HybridConnectionLimits no longer has parameter system_data
      info	[Changelog]   - Model RenewCertificateOrderRequest no longer has parameter system_data
      info	[Changelog]   - Model CertificateOrderAction no longer has parameter system_data
      info	[Changelog]   - Model SiteConfigResource no longer has parameter system_data
      info	[Changelog]   - Model PushSettings no longer has parameter system_data
      info	[Changelog]   - Model RecommendationRule no longer has parameter system_data
      info	[Changelog]   - Model ApiKVReference no longer has parameter location
      info	[Changelog]   - Model StaticSiteUserARMResource no longer has parameter system_data
      info	[Changelog]   - Model AppServiceCertificatePatchResource no longer has parameter system_data
      info	[Changelog]   - Model AllowedAudiencesValidation no longer has parameter system_data
      info	[Changelog]   - Model PrivateAccess no longer has parameter system_data
      info	[Changelog]   - Model ForwardProxy no longer has parameter system_data
      info	[Changelog]   - Model ClientRegistration no longer has parameter system_data
      info	[Changelog]   - Model CertificatePatchResource no longer has parameter system_data
      info	[Changelog]   - Model Identifier no longer has parameter system_data
      info	[Changelog]   - Model LoginRoutes no longer has parameter system_data
      info	[Changelog]   - Model ContinuousWebJob no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectoryLogin no longer has parameter system_data
      info	[Changelog]   - Model VnetGateway no longer has parameter system_data
      info	[Changelog]   - Model ProcessModuleInfo no longer has parameter system_data
      info	[Changelog]   - Model StringDictionary no longer has parameter system_data
      info	[Changelog]   - Model PremierAddOnOffer no longer has parameter system_data
      info	[Changelog]   - Model BillingMeter no longer has parameter system_data
      info	[Changelog]   - Model SitePatchResource no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectLogin no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectConfig no longer has parameter system_data
      info	[Changelog]   - Model SlotDifference no longer has parameter system_data
      info	[Changelog]   - Model ProxyOnlyResource no longer has parameter system_data
      info	[Changelog]   - Model Usage no longer has parameter system_data
      info	[Changelog]   - Model MSDeploy no longer has parameter system_data
      info	[Changelog]   - Model JwtClaimChecks no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectClientCredential no longer has parameter system_data
      info	[Changelog]   - Model WebSiteInstanceStatus no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteUserInvitationRequestResource no longer has parameter system_data
      info	[Changelog]   - Model AppRegistration no longer has parameter system_data
      info	[Changelog]   - Model DeletedAppRestoreRequest no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectoryRegistration no longer has parameter system_data
      info	[Changelog]   - Model NetworkFeatures no longer has parameter system_data
      info	[Changelog]   - Model DeletedSite no longer has parameter system_data
      info	[Changelog]   - Model AppServicePlanPatchResource no longer has parameter system_data
      info	[Changelog]   - Model Domain no longer has parameter system_data
      info	[Changelog]   - Model WorkerPoolResource no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteARMResource no longer has parameter system_data
      info	[Changelog]   - Model IdentityProviders no longer has parameter system_data
      info	[Changelog]   - Model DiagnosticAnalysis no longer has parameter system_data
      info	[Changelog]   - Model DomainOwnershipIdentifier no longer has parameter system_data
      info	[Changelog]   - Model AppServiceCertificateOrder no longer has parameter system_data
      info	[Changelog]   - Model CertificateEmail no longer has parameter system_data
      info	[Changelog]   - Model HttpSettings no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectory no longer has parameter system_data
      info	[Changelog]   - Model BlobStorageTokenStore no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteFunctionOverviewARMResource no longer has parameter system_data
      info	[Changelog]   - Model DiagnosticCategory no longer has parameter system_data
      info	[Changelog]   - Model FileSystemTokenStore no longer has parameter system_data
      info	[Changelog]   - Model SiteExtensionInfo no longer has parameter system_data
      info	[Changelog]   - Model Recommendation no longer has parameter system_data
      info	[Changelog]   - Model VnetValidationTestFailure no longer has parameter system_data
      info	[Changelog]   - Model ReissueCertificateOrderRequest no longer has parameter system_data
      info	[Changelog]   - Model PremierAddOnPatchResource no longer has parameter system_data
      info	[Changelog]   - Model PremierAddOn no longer has parameter system_data
      info	[Changelog]   - Model Site no longer has parameter system_data
      info	[Changelog]   - Model SiteAuthSettings no longer has parameter system_data
      info	[Changelog]   - Model BackupRequest no longer has parameter system_data
      info	[Changelog]   - Model StaticSitePatchResource no longer has parameter system_data
      info	[Changelog]   - Model HttpSettingsRoutes no longer has parameter system_data
      info	[Changelog]   - Model MigrateMySqlRequest no longer has parameter system_data
      info	[Changelog]   - Model ResourceMetricDefinition no longer has parameter system_data
      info	[Changelog]   - Model SitePhpErrorLogFlag no longer has parameter system_data
      info	[Changelog]   - Model CsmPublishingCredentialsPoliciesEntity no longer has parameter system_data
      info	[Changelog]   - Model StaticSitesWorkflowPreview no longer has parameter system_data
      info	[Changelog]   - Model VnetParameters no longer has parameter system_data
      info	[Changelog]   - Model BackupItem no longer has parameter system_data
      info	[Changelog]   - Model Nonce no longer has parameter system_data
      info	[Changelog]   - Model SiteSourceControl no longer has parameter system_data
      info	[Changelog]   - Model Deployment no longer has parameter system_data
      info	[Changelog]   - Model Facebook no longer has parameter system_data
      info	[Changelog]   - Model StorageMigrationResponse no longer has parameter system_data
      info	[Changelog]   - Model TriggeredJobHistory no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteResetPropertiesARMResource no longer has parameter system_data
      info	[Changelog]   - Model TwitterRegistration no longer has parameter system_data
      info	[Changelog]   - Model GitHub no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteUserInvitationResponseResource no longer has parameter system_data
      info	[Changelog]   - Model VnetInfo no longer has parameter system_data
      info	[Changelog]   - Model HybridConnectionKey no longer has parameter system_data
      info	[Changelog]   - Model AuthPlatform no longer has parameter system_data
      info	[Changelog]   - Model Twitter no longer has parameter system_data
      info	[Changelog]   - Model ProcessThreadInfo no longer has parameter system_data
      info	[Changelog]   - Model SiteLogsConfig no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteCustomDomainOverviewARMResource no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectoryValidation no longer has parameter system_data
      info	[Changelog]   - Model User no longer has parameter system_data
      info	[Changelog]   - Model CookieExpiration no longer has parameter system_data
      info	[Changelog]   - Model SourceControl no longer has parameter system_data
      info	[Changelog]   - Model SwiftVirtualNetwork no longer has parameter system_data
      info	[Changelog]   - Model Resource no longer has parameter system_data
      info	[Changelog]   - Removed operation WebAppsOperations.copy_slot_slot
      info	[Changelog]   - Removed operation WebAppsOperations.update_swift_virtual_network_connection
      info	[Changelog]   - Removed operation WebAppsOperations.copy_production_slot
      info	[Changelog]   - Removed operation WebAppsOperations.create_or_update_swift_virtual_network_connection
      info	[Changelog]   - Removed operation WebAppsOperations.update_swift_virtual_network_connection_slot
      info	[Changelog]   - Removed operation WebAppsOperations.create_or_update_swift_virtual_network_connection_slot
      info	[Changelog]   - Model AppServiceEnvironmentResource has a new signature
      info	[Changelog]   - Model DetectorInfo has a new signature
      info	[Changelog]   - Model AppServiceEnvironmentPatchResource has a new signature
      info	[Changelog]   - Model AppServiceEnvironment has a new signature
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-web [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Model PrivateAccess no longer has parameter system_data
      info	[Changelog]   - Model BackupRequest no longer has parameter system_data
      info	[Changelog]   - Model CertificateOrderAction no longer has parameter system_data
      info	[Changelog]   - Model StaticSitesWorkflowPreviewRequest no longer has parameter system_data
      info	[Changelog]   - Model HttpSettings no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectClientCredential no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteARMResource no longer has parameter system_data
      info	[Changelog]   - Model VnetInfo no longer has parameter system_data
      info	[Changelog]   - Model ApiKVReference no longer has parameter location
      info	[Changelog]   - Model SiteLogsConfig no longer has parameter system_data
      info	[Changelog]   - Model SourceControl no longer has parameter system_data
      info	[Changelog]   - Model Resource no longer has parameter system_data
      info	[Changelog]   - Model DiagnosticCategory no longer has parameter system_data
      info	[Changelog]   - Model WebSiteInstanceStatus no longer has parameter system_data
      info	[Changelog]   - Model ClientRegistration no longer has parameter system_data
      info	[Changelog]   - Model WebJob no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteBuildARMResource no longer has parameter system_data
      info	[Changelog]   - Model TriggeredJobRun no longer has parameter system_data
      info	[Changelog]   - Model RelayServiceConnectionEntity no longer has parameter system_data
      info	[Changelog]   - Model ContinuousWebJob no longer has parameter system_data
      info	[Changelog]   - Model VnetRoute no longer has parameter system_data
      info	[Changelog]   - Model VnetValidationFailureDetails no longer has parameter system_data
      info	[Changelog]   - Model MigrateMySqlStatus no longer has parameter system_data
      info	[Changelog]   - Model ResourceMetricDefinition no longer has parameter system_data
      info	[Changelog]   - Model DetectorResponse no longer has parameter system_data
      info	[Changelog]   - Model BillingMeter no longer has parameter system_data
      info	[Changelog]   - Model Certificate no longer has parameter system_data
      info	[Changelog]   - Model CookieExpiration no longer has parameter system_data
      info	[Changelog]   - Model IdentityProviders no longer has parameter system_data
      info	[Changelog]   - Model Facebook no longer has parameter system_data
      info	[Changelog]   - Model TopLevelDomain no longer has parameter system_data
      info	[Changelog]   - Model BlobStorageTokenStore no longer has parameter system_data
      info	[Changelog]   - Model RecommendationRule no longer has parameter system_data
      info	[Changelog]   - Model VnetValidationTestFailure no longer has parameter system_data
      info	[Changelog]   - Model GitHub no longer has parameter system_data
      info	[Changelog]   - Model SiteAuthSettings no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteCustomDomainOverviewARMResource no longer has parameter system_data
      info	[Changelog]   - Model ProxyOnlyResource no longer has parameter system_data
      info	[Changelog]   - Model MSDeployLog no longer has parameter system_data
      info	[Changelog]   - Model AuthPlatform no longer has parameter system_data
      info	[Changelog]   - Model SlotConfigNamesResource no longer has parameter system_data
      info	[Changelog]   - Model ApplicationStackResource no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectoryValidation no longer has parameter system_data
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter system_data
      info	[Changelog]   - Model SwiftVirtualNetwork no longer has parameter system_data
      info	[Changelog]   - Model LoginScopes no longer has parameter system_data
      info	[Changelog]   - Model SiteSourceControl no longer has parameter system_data
      info	[Changelog]   - Model BackupItem no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteResetPropertiesARMResource no longer has parameter system_data
      info	[Changelog]   - Model Login no longer has parameter system_data
      info	[Changelog]   - Model CertificateEmail no longer has parameter system_data
      info	[Changelog]   - Model Recommendation no longer has parameter system_data
      info	[Changelog]   - Model DiagnosticAnalysis no longer has parameter system_data
      info	[Changelog]   - Model SlotDifference no longer has parameter system_data
      info	[Changelog]   - Model RenewCertificateOrderRequest no longer has parameter system_data
      info	[Changelog]   - Model VnetGateway no longer has parameter system_data
      info	[Changelog]   - Model HybridConnectionLimits no longer has parameter system_data
      info	[Changelog]   - Model AppRegistration no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectConfig no longer has parameter system_data
      info	[Changelog]   - Model Domain no longer has parameter system_data
      info	[Changelog]   - Model DomainPatchResource no longer has parameter system_data
      info	[Changelog]   - Model Site no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectoryRegistration no longer has parameter system_data
      info	[Changelog]   - Model CsmPublishingCredentialsPoliciesCollection no longer has parameter system_data
      info	[Changelog]   - Model AppServiceCertificateOrderPatchResource no longer has parameter system_data
      info	[Changelog]   - Model LoginRoutes no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectLogin no longer has parameter system_data
      info	[Changelog]   - Model HttpSettingsRoutes no longer has parameter system_data
      info	[Changelog]   - Model OpenIdConnectRegistration no longer has parameter system_data
      info	[Changelog]   - Model AzureActiveDirectory no longer has parameter system_data
      info	[Changelog]   - Model CsmPublishingCredentialsPoliciesEntity no longer has parameter system_data
      info	[Changelog]   - Model StorageMigrationResponse no longer has parameter system_data
      info	[Changelog]   - Model DiagnosticDetectorResponse no longer has parameter system_data
      info	[Changelog]   - Model HostNameBinding no longer has parameter system_data
      info	[Changelog]   - Model MigrateMySqlRequest no longer has parameter system_data
      info	[Changelog]   - Model ProcessModuleInfo no longer has parameter system_data
      info	[Changelog]   - Model StringDictionary no longer has parameter system_data
      info	[Changelog]   - Model GeoRegion no longer has parameter system_data
      info	[Changelog]   - Model Google no longer has parameter system_data
      info	[Changelog]   - Model SnapshotRestoreRequest no longer has parameter system_data
      info	[Changelog]   - Model FileSystemTokenStore no longer has parameter system_data
      info	[Changelog]   - Model TriggeredWebJob no longer has parameter system_data
      info	[Changelog]   - Model HybridConnectionKey no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteFunctionOverviewARMResource no longer has parameter system_data
      info	[Changelog]   - Model MSDeploy no longer has parameter system_data
      info	[Changelog]   - Model StorageMigrationOptions no longer has parameter system_data
      info	[Changelog]   - Model AllowedAudiencesValidation no longer has parameter system_data
      info	[Changelog]   - Model DeletedAppRestoreRequest no longer has parameter system_data
      info	[Changelog]   - Model ForwardProxy no longer has parameter system_data
      info	[Changelog]   - Model Usage no longer has parameter system_data
      info	[Changelog]   - Model MSDeployStatus no longer has parameter system_data
      info	[Changelog]   - Model DeletedSite no longer has parameter system_data
      info	[Changelog]   - Model VnetParameters no longer has parameter system_data
      info	[Changelog]   - Model StaticSitePatchResource no longer has parameter system_data
      info	[Changelog]   - Model WorkerPoolResource no longer has parameter system_data
      info	[Changelog]   - Model SiteAuthSettingsV2 no longer has parameter system_data
      info	[Changelog]   - Model CustomOpenIdConnectProvider no longer has parameter system_data
      info	[Changelog]   - Model StaticSiteUserInvitationRequestResource no longer has parameter system_data
      info	[Changelog]   - Model StaticSitesWorkflowPreview no longer has parameter system_data
      info	[Changelog]   - Model SitePatchResource no longer has parameter system_data
      info	[Changelog]   - Model ConnectionStringDictionary no longer has parameter system_data
      info	[Changelog]   - Model PushSettings no longer has parameter system_data
      info	[Changelog]   - Model TokenStore no longer has parameter system_data
      info	[Changelog]   - Model AppServiceEnvironment has a new signature
      info	[Changelog]   - Model DetectorInfo has a new signature
      info	[Changelog]   - Model AppServiceEnvironmentPatchResource has a new signature
      info	[Changelog]   - Model AppServiceEnvironmentResource has a new signature
      info	[Changelog]   - Removed operation WebAppsOperations.create_or_update_swift_virtual_network_connection_slot
      info	[Changelog]   - Removed operation WebAppsOperations.begin_copy_production_slot
      info	[Changelog]   - Removed operation WebAppsOperations.update_swift_virtual_network_connection
      info	[Changelog]   - Removed operation WebAppsOperations.create_or_update_swift_virtual_network_connection
      info	[Changelog]   - Removed operation WebAppsOperations.begin_copy_slot
      info	[Changelog]   - Removed operation WebAppsOperations.update_swift_virtual_network_connection_slot
      info	[Changelog]   - Removed operation StaticSitesOperations.delete_static_site
      info	[Changelog]   - Removed operation StaticSitesOperations.delete_static_site_build
      info	[Changelog]   - Removed operation StaticSitesOperations.detach_static_site
      info	[Changelog]   - Removed operation StaticSitesOperations.create_or_update_static_site_custom_domain
      info	[Changelog]   - Removed operation StaticSitesOperations.create_or_update_static_site
      info	[Changelog]   - Removed operation StaticSitesOperations.delete_static_site_custom_domain
      info	[Changelog]   - Removed operation StaticSitesOperations.validate_custom_domain_can_be_added_to_static_site
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-17 02:11:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-appservice-generated"
      cmderr	[generate.py] 2021-05-17 02:11:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-05-17 02:11:23 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appservice/azure-resourcemanager-appservice-generated --java.namespace=com.azure.resourcemanager.appservice.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/web/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [POM][Skip] pom already has module azure-resourcemanager-appservice-generated
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-17 02:15:07 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-appservice-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Got artifact_id: azure-resourcemanager-appservice-generated
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Got artifact: azure-resourcemanager-appservice-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Got artifact: azure-resourcemanager-appservice-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Got artifact: azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG Match jar package: azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-17 02:22:17 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14187/azure-sdk-for-java/azure-resourcemanager-appservice-generated/azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appservice-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️web/mgmt/2020-12-01/web [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New function `*RemotePrivateEndpointConnection.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PossibleStagingEnvironmentPolicyValues() []StagingEnvironmentPolicy`
      info	[Changelog] - New function `AppsClient.CreateOrUpdateSwiftVirtualNetworkConnectionWithCheckSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New struct `ArmPlan`
      info	[Changelog] - New struct `RemotePrivateEndpointConnection`
      info	[Changelog] - New struct `RemotePrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `ResponseMessageEnvelopeRemotePrivateEndpointConnection`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `StaticSite`
      info	[Changelog] - New field `StagingEnvironmentPolicy` in struct `StaticSite`
      info	[Changelog] - New field `AllowConfigFileUpdates` in struct `StaticSite`
      info	[Changelog] - New field `VirtualNetworkSubnetID` in struct `SitePatchResourceProperties`
      info	[Changelog] - New field `VirtualNetworkSubnetID` in struct `SiteProperties`
      info	[Changelog] - New field `AcrUserManagedIdentityID` in struct `SiteConfig`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `SiteConfig`
      info	[Changelog] - New field `AcrUseManagedIdentityCreds` in struct `SiteConfig`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 23 additive change(s).
      info	[Changelog]
    • ️✔️web/mgmt/2020-09-01/web [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `AcrUseManagedIdentityCreds` in struct `SiteConfig`
      info	[Changelog] - New field `AcrUserManagedIdentityID` in struct `SiteConfig`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️web/mgmt/2020-06-01/web [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `AcrUserManagedIdentityID` in struct `SiteConfig`
      info	[Changelog] - New field `AcrUseManagedIdentityCreds` in struct `SiteConfig`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️web/mgmt/2019-08-01/web [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️web/mgmt/2018-02-01/web [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️web/mgmt/2016-09-01/web [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/web/mgmt/2015-08-01-preview/web [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8a59901. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/web/resource-manager/readme.md
    • ️✔️@azure/arm-appservice [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/webSiteManagementClient.js → ./dist/arm-appservice.js...
      cmderr	[npmPack] created ./dist/arm-appservice.js in 1.7s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8a59901. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 29, 2021
    @ghost
    Copy link

    ghost commented Apr 29, 2021

    Thank you for your contribution SorenMaagaard! We will review the pull request and get back to you soon.

    @SorenMaagaard
    Copy link
    Contributor Author

    It seems like a regression. It was added to version 2019-08-01 in this PR: #10215
    but never to never versions.

    @weidongxu-microsoft
    Copy link
    Member

    @naveedaz Could you confirm that these are missed properties?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Python customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants