Fixed .Net SDK code generation issue. #14205

KalpeshChavan12 · 2021-04-30T12:46:57Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-04-30T12:47:00Z

Hi, @KalpeshChavan12 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-04-30T12:47:01Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-preview-2021-04",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-preview-2021-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-preview-2020-07",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-preview-2020-07",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2020-04",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2020-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2018-06-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"maintenance/resource-manager/readme.md",
"tag":"package-2018-06-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-30T12:47:02Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-30T12:47:02Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 95be8ad. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️maintenance [View full logs] [Release Schema Changes]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 95be8ad. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-maintenance [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model MaintenanceConfiguration no longer has parameter install_patches
info	[Changelog]   - Removed operation ConfigurationAssignmentsOperations.get_parent
info	[Changelog]   - Removed operation ConfigurationAssignmentsOperations.get
info	[Changelog]   - Removed operation group ConfigurationAssignmentsWithinSubscriptionOperations

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 95be8ad. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-maintenance [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model ApplyUpdate has a new parameter system_data
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter start_date_time
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter visibility
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter time_zone
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter system_data
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter expiration_date_time
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter recur_every
info	[Changelog]   - Model MaintenanceConfiguration has a new parameter duration
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model ConfigurationAssignment has a new parameter system_data
info	[Changelog]   - Added operation ApplyUpdatesOperations.list
info	[Changelog]   - Added operation group ApplyUpdateForResourceGroupOperations
info	[Changelog]   - Added operation group PublicMaintenanceConfigurationsOperations
info	[Changelog]   - Added operation group MaintenanceConfigurationsForResourceGroupOperations

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 95be8ad. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️maintenance/mgmt/2020-04-01/maintenance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/maintenance/mgmt/2018-06-01-preview/maintenance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

KalpeshChavan12 · 2021-04-30T13:37:14Z

/azp run unifiedPipeline

azure-pipelines · 2021-04-30T13:37:20Z

No pipelines are associated with this pull request.

KalpeshChavan12 · 2021-04-30T18:11:59Z

@chiragg4u

Can you please review PR

Regards
Kalpesh Chavan

KalpeshChavan12 · 2021-04-30T20:30:33Z

Hi @qianwens

Can you please review PR, No ARM signoff required for PR. can you please review and merge PR.

Regards
Kalpesh Chavan

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

Fixed .Net SDK code generation issue.

2fc338f

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 30, 2021

KalpeshChavan12 marked this pull request as ready for review April 30, 2021 13:54

openapi-assignment-bot bot assigned qianwens Apr 30, 2021

JeffreyRichter approved these changes Apr 30, 2021

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 30, 2021

qianwens merged commit 95be8ad into Azure:master May 6, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Fixed .Net SDK code generation issue. (Azure#14205)

fb019b6

Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed .Net SDK code generation issue. #14205

Fixed .Net SDK code generation issue. #14205

KalpeshChavan12 commented Apr 30, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

KalpeshChavan12 commented Apr 30, 2021

azure-pipelines bot commented Apr 30, 2021

KalpeshChavan12 commented Apr 30, 2021

KalpeshChavan12 commented Apr 30, 2021

Fixed .Net SDK code generation issue. #14205

Fixed .Net SDK code generation issue. #14205

Conversation

KalpeshChavan12 commented Apr 30, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Apr 30, 2021

openapi-pipeline-app bot commented Apr 30, 2021 • edited Loading

Swagger Generation Artifacts

KalpeshChavan12 commented Apr 30, 2021

azure-pipelines bot commented Apr 30, 2021

KalpeshChavan12 commented Apr 30, 2021

KalpeshChavan12 commented Apr 30, 2021

KalpeshChavan12 commented Apr 30, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 30, 2021 •

edited

Loading