Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute 2021 03 release #14223

Merged
merged 11 commits into from
May 12, 2021
Merged

Compute 2021 03 release #14223

merged 11 commits into from
May 12, 2021

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented May 3, 2021

Copied from : #14121

This PR is to release the new version of Compute, 2021-03-01.

This release consists of these PR, all of which have been reviewed before:

Deep Deletion: #13657
Scheduled Events: #13351
PatchSetting Assessment mode: #13468
Network Interface Config :#13449 (Required and received ARM signoff)
Patchsetting Description : #13509
RestorePoint: #13219 (Required and received ARM signoff)
UserData: #13220
#14191
#14197

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @ghost ghost added the Compute label May 3, 2021
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    * Deep deletion feature
    
    * Deep deletion cleanup
    
    * Deep deletion cleanup 2
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⌛[Staging] SDK Breaking Change Tracking pending [Detail]
    ️⚠️ azure-sdk-for-net warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from aa62339. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from aa62339. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-18 02:19:14 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-06-18 02:19:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-06-18 02:19:14 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-18 02:20:55 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-06-18 02:25:18 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14223/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from aa62339. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
      cmderr	[npmPack] created ./dist/arm-compute.js in 1.6s
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from aa62339. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from aa62339. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    Sandido added 3 commits May 4, 2021 14:16
    * Scheduled Events feature
    
    * Scheduled Events feature example
    * PatchSetting assessment feature
    
    * PatchSetting assessment feature cleanup
    
    * Patchsetting example
    
    * Patchsetting example 2
    
    * Patchsetting example 3
    
    * Patchsetting example 4
    
    * Patchsetting example 5
    @openapi-workflow-bot
    Copy link

    Hi @Sandido, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Sandido added 2 commits May 4, 2021 15:54
    * Restore point and User Data features
    
    * Restore Point cleanup
    
    * Restore point ex 1
    
    * restore point ex2
    
    * restore point ex 3
    
    * REstore point ex 4
    
    * restore point ex 5
    
    * restore point ex 6
    
    * restore point ex 7
    
    * restore point ex 8
    
    * restore point ex 9
    
    * restore point ex 10
    
    * restore point ex 11
    
    * restore point readme
    
    * user data feature cloudservice
    
    * user data ex 1
    
    * user data ex 2
    
    * user data ex 3
    
    * user data ex 4
    
    * user data ex 5
    This was referenced May 12, 2021
    @RAY-316
    Copy link
    Contributor

    RAY-316 commented Jun 18, 2021

    /azp run

    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * initial copy of files
    
    * API version updates
    
    * Deep deletion feature (Azure#14232)
    
    * Deep deletion feature
    
    * Deep deletion cleanup
    
    * Deep deletion cleanup 2
    
    * Scheduled Events feature (Azure#14233)
    
    * Scheduled Events feature
    
    * Scheduled Events feature example
    
    * PatchSetting Assessment Mode Windows + Linux (Azure#14234)
    
    * PatchSetting assessment feature
    
    * PatchSetting assessment feature cleanup
    
    * Patchsetting example
    
    * Patchsetting example 2
    
    * Patchsetting example 3
    
    * Patchsetting example 4
    
    * Patchsetting example 5
    
    * Add network interface config schema to VM Network profile (Azure#14235)
    
    * NIC feature
    
    * NIC example
    
    * Restore point and User Data features (Azure#14243)
    
    * Restore point and User Data features
    
    * Restore Point cleanup
    
    * Restore point ex 1
    
    * restore point ex2
    
    * restore point ex 3
    
    * REstore point ex 4
    
    * restore point ex 5
    
    * restore point ex 6
    
    * restore point ex 7
    
    * restore point ex 8
    
    * restore point ex 9
    
    * restore point ex 10
    
    * restore point ex 11
    
    * restore point readme
    
    * user data feature cloudservice
    
    * user data ex 1
    
    * user data ex 2
    
    * user data ex 3
    
    * user data ex 4
    
    * user data ex 5
    
    * Fix broken links (Azure#14244)
    
    * Remove unnecessary examples
    
    * fix conflict
    
    Co-authored-by: arcturusZhang <ufo54153@gmail.com>
    @JackTn JackTn deleted the compute-2021-03-release branch August 17, 2021 06:06
    @JackTn JackTn restored the compute-2021-03-release branch August 19, 2021 02:39
    @cataggar cataggar deleted the compute-2021-03-release branch October 26, 2021 21:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go Compute
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants