[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #14451

samsaha-ms · 2021-05-18T10:52:21Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-05-18T10:52:23Z

Hi, @samsaha-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-05-18T10:52:23Z

Swagger Validation Report

️❌BreakingChange: 11 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- current:preview/2020-10-01-preview/logz.json compared with base:preview/2020-10-01-preview/logz.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1355:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1403:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1462:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1513:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1558:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1614:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1662:5
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'singleSignOnUrl' in response that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1871:7 Old: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1508:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'provisioningState' in response that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2158:7 Old: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1791:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'singleSignOnUrl' that was not found in the old version. New: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1871:7 Old: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1508:7

️⚠️LintDiff: 4 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- logz/resource-manager/readme.md tag:package-2020-10-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- logz/resource-manager/readme.md tag:package-2020-10-01-preview

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1685
⚠️ R4021 - DescriptionAndTitleMissing	'provisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2159
⚠️ R4021 - DescriptionAndTitleMissing	'role' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2397
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: MainAccount_VMHosts_Update Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1710

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L35
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2042
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2089
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2195
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L2272
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'TagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L572
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'SubAccountTagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1242
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'tagRules' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1718
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'singleSignOnConfigurations' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1718
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'accounts' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Logz/preview/2020-10-01-preview/logz.json#L1718

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

logz/resource-manager/readme.md#package-2020-10-01-preview

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-18T10:52:24Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-18T10:52:24Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-logz - first release

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 0142a08. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-logz [View full logs] [Release SDK Changes]
- azure_mgmt_logz-1.0.0b1-py2.py3-none-any.whl
- azure-mgmt-logz-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0142a08. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-21 02:43:49 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-logz"
cmderr	[generate.py] 2021-05-21 02:43:49 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-21 02:43:49 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/logz/azure-resourcemanager-logz --java.namespace=com.azure.resourcemanager.logz   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/logz/resource-manager/readme.md
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [POM][Skip] pom already has module azure-resourcemanager-logz
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-21 02:44:23 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-05-21 02:45:45 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-logz [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-05-21 02:47:03 DEBUG Got artifact_id: azure-resourcemanager-logz
cmderr	[Inst] 2021-05-21 02:47:03 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-21 02:47:03 DEBUG Got artifact: azure-resourcemanager-logz-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-21 02:47:03 DEBUG Match jar package: azure-resourcemanager-logz-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-21 02:47:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14451/azure-sdk-for-java/azure-resourcemanager-logz/azure-resourcemanager-logz-1.0.0-beta.1.jar\" -o azure-resourcemanager-logz-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-logz -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-logz-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0142a08. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/logz/mgmt/2020-10-01-preview/logz [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️⌛ azure-sdk-for-js pending [Detail]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0142a08. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0142a08. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/logz/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Monitors/put/Monitors_Create
cmderr	[Autorest]     - name: /Monitors/get/Monitors_Get
cmderr	[Autorest]     - name: /Monitors/get/Monitors_List
cmderr	[Autorest]     - name: /Monitors/get/Monitors_ListByResourceGroup
cmderr	[Autorest]     - name: /Monitors/patch/Monitors_Update
cmderr	[Autorest]     - name: /Monitors/post/MainAccount_VMHosts_Update
cmderr	[Autorest]     - name: /Monitors/post/MonitoredResources_List
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_List
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_Payload
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_Update
cmderr	[Autorest]     - name: /SingleSignOn/put/SingleSignOnConfigurations_CreateOrUpdate
cmderr	[Autorest]     - name: /SingleSignOn/get/SingleSignOnConfigurations_Get
cmderr	[Autorest]     - name: /SingleSignOn/get/SingleSignOnConfigurations_List
cmderr	[Autorest]     - name: /SubAccount/put/subAccount_Create
cmderr	[Autorest]     - name: /SubAccount/get/SubAccount_Get
cmderr	[Autorest]     - name: /SubAccount/get/SubAccount_List
cmderr	[Autorest]     - name: /SubAccount/patch/SubAccount_Update
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_MonitoredResources_List
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_List
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_Payload
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_Update
cmderr	[Autorest]     - name: /SubAccountTagRules/put/SubAccountTagRules_CreateOrUpdate
cmderr	[Autorest]     - name: /SubAccountTagRules/get/SubAccountTagRules_Get
cmderr	[Autorest]     - name: /SubAccountTagRules/get/SubAccountTagRules_List
cmderr	[Autorest]     - name: /SubAccountTagRules/delete/TagRules_Delete
cmderr	[Autorest]     - name: /SubAccount/delete/SubAccount_Delete
cmderr	[Autorest]     - name: /TagRules/put/TagRules_CreateOrUpdate
cmderr	[Autorest]     - name: /TagRules/get/TagRules_Get
cmderr	[Autorest]     - name: /TagRules/get/TagRules_List
cmderr	[Autorest]     - name: /TagRules/delete/TagRules_Delete
cmderr	[Autorest]     - name: /Monitors/delete/Monitors_Delete
cmderr	[Autorest] --------------------------------------------------------

️✔️logz [View full logs] [Release Azure CLI Changes]
- logz-0.1.0-py3-none-any.whl
- logz-0.1.0.zip

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-18T10:54:30Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

samsaha-ms · 2021-05-18T11:35:14Z

Changes has been already approved in private repo.
https://github.com/Azure/azure-rest-api-specs-pr/pull/3618
https://github.com/Azure/azure-rest-api-specs-pr/pull/3776

openapi-workflow-bot · 2021-05-18T11:36:47Z

Hi, @samsaha-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @zhenglaizhang

samsaha-ms · 2021-05-19T16:41:08Z

Hi @ruowan, kindly help in merging this PR.

openapi-workflow-bot · 2021-05-20T02:27:23Z

Hi @samsaha-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

ruowan · 2021-05-20T02:28:01Z

Hi, Your PR has breaking change, could you pls go through breaking change review process.

…zure#14451)

openapi-pipeline-app bot added the NewApiVersionRequired label May 18, 2021

Updating the Microsoft.Logz.io to consume changes in private repo.

7f4c330

samsaha-ms force-pushed the dev-logz-Microsoft.Logz-2020-10-01-preview branch from e94c33c to 7f4c330 Compare May 18, 2021 11:28

samsaha-ms marked this pull request as ready for review May 18, 2021 11:33

openapi-assignment-bot bot assigned zhenglaizhang May 18, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 18, 2021

zhenglaizhang assigned ruowan and unassigned zhenglaizhang May 19, 2021

jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 19, 2021

ruowan added the BreakingChangeReviewRequired label May 20, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 21, 2021

JeffreyRichter approved these changes May 21, 2021

View reviewed changes

ruowan merged commit 0142a08 into Azure:master May 21, 2021

samsaha-ms deleted the dev-logz-Microsoft.Logz-2020-10-01-preview branch May 21, 2021 03:14

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Updating the Microsoft.Logz.io to consume changes in private repo. (A…

ff7496b

…zure#14451)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #14451

[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #14451

samsaha-ms commented May 18, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 18, 2021

openapi-pipeline-app bot commented May 18, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 18, 2021

openapi-pipeline-app bot commented May 18, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 18, 2021

samsaha-ms commented May 18, 2021

openapi-workflow-bot bot commented May 18, 2021

samsaha-ms commented May 19, 2021

openapi-workflow-bot bot commented May 20, 2021

ruowan commented May 20, 2021

[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #14451

[Hub Generated] Review request for Microsoft.Logz to add version preview/2020-10-01-preview #14451

Conversation

samsaha-ms commented May 18, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 18, 2021

openapi-pipeline-app bot commented May 18, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented May 18, 2021

openapi-pipeline-app bot commented May 18, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 18, 2021

samsaha-ms commented May 18, 2021

openapi-workflow-bot bot commented May 18, 2021

samsaha-ms commented May 19, 2021

openapi-workflow-bot bot commented May 20, 2021

ruowan commented May 20, 2021

samsaha-ms commented May 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2021 •

edited

Loading