Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Track2 SDK change breaking PR checks #14558

Merged
merged 1 commit into from
May 28, 2021
Merged

Revert Track2 SDK change breaking PR checks #14558

merged 1 commit into from
May 28, 2021

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented May 26, 2021

This is intended to fix the PR checks that are now broken in this folder. The checks were broken by this PR: https://github.com/Azure/azure-rest-api-specs/pull/14507/files

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @ghost ghost added the Compute label May 26, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-03-01
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 21.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d7dc5fb. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d7dc5fb. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-28 01:47:20 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
cmderr	[generate.py] 2021-05-28 01:47:20 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-28 01:47:20 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-28 01:48:48 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-05-28 01:52:46 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
cmderr	[Inst] 2021-05-28 01:52:46 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-28 01:52:46 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-05-28 01:52:46 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-28 01:52:46 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-28 01:52:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14558/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d7dc5fb. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
cmderr	[npmPack] created ./dist/arm-compute.js in 1.6s
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d7dc5fb. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `NetworkAPIVersion` in struct `VirtualMachineScaleSetUpdateNetworkProfile`
info	[Changelog] - New field `NetworkAPIVersion` in struct `NetworkProfile`
info	[Changelog] - New field `NetworkInterfaceConfigurations` in struct `NetworkProfile`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 343 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `RequestRateByIntervalInput`
info	[Changelog] - New field `GroupByUserAgent` in struct `RequestRateByIntervalInput`
info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput`
info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
info	[Changelog]
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d7dc5fb. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @Sandido Sandido requested a review from msyyc May 26, 2021 19:32
    @Sandido Sandido added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 26, 2021
    This was referenced May 26, 2021
    Closed
    Closed
    Closed
    Closed
    @ArcturusZhang ArcturusZhang mentioned this pull request May 27, 2021
    Closed
    26 tasks
    @Sandido Sandido removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 27, 2021
    @Sandido
    Copy link
    Member Author

    Sandido commented May 27, 2021

    @ArcturusZhang , @yungezz , please review this PR as per the email thread about it titled "RE: .Net SDK PR Check failure: DUplicateModel collision, unable to resolve."

    @msyyc msyyc merged commit d7dc5fb into master May 28, 2021
    This was referenced May 28, 2021
    Closed
    Closed
    Closed
    Closed
    This was referenced May 28, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @Sandido Sandido deleted the adsandor/ReadMeRevert branch June 7, 2021 20:16
    @heaths heaths mentioned this pull request Jun 16, 2021
    Merged
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @Sandido @mkarmark
    Revert change breaking PR checks (Azure#14558)
    b4645db
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    @dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

    @grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore grizzlytheodore is a code owner

    @haagha haagha Awaiting requested review from haagha haagha is a code owner

    @hyonholee hyonholee Awaiting requested review from hyonholee

    @madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

    @MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

    Assignees

    @yungezz yungezz

    Labels
    CI-BreakingChange-Go Compute
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @Sandido @msyyc @yungezz