Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maesqui/verifiable credential pics issuance #14633

Conversation

mauesrog
Copy link

@mauesrog mauesrog commented Jun 2, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

LukeSlev and others added 30 commits April 29, 2021 11:37
* Update preview api to disable broken properties and to add property that is working

* Update managed cluster description
* Add New Data Model RuleCollection to NetworkManager

* fix typo

* test

* test

* Fix discriminator

* fix type

* Fix discriminator

* Fix type

* fix type

* Fix type

* Fix discriminator

* Fix discriminator

* fix type

* fix type

* Fix bug

* Fix type

* Fix format

* Fix name

* Fix name

* fix spell

* fix description

* Fix spell

* change to kind

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* Fix post body

* Fix as comments

* fix bug

* fix bug

* fix bug

* fix bug

* fix bug

* fix bug

* change rule kind

* Fix as comments

* Fix as comments

* update lastest version

* Update type

* Update Skiptoken

* Fix discription

* Fix NG

* Fix NG

* add more example
* Update readme.python.md

* Update readme.python.md
* Remove all schema readme

* process new rp

* Remove after_scripts
…version stable/2021-04-01 (#13890)

* Adds base for updating Microsoft.AlertsManagement from version stable/2019-06-01 to version 2021-04-01

* Updates readme

* Updates API version in new specs and examples

* first commit

* some fixes

* try without alert management

* revert change to name of namespace

* Resolve lintdiff issues

* remove the copy of files and reference alert managment previous version

* update description of subscriptionId to solve error

* attemp to remove AlertsManagement from the package

* revert (put back AlertsManagment)
* add tags for go SDK release v54.0.0

* add a new tag
* Standardized Errors, sample list.

* removing from master from now as this is just a proposal

* FRv2.1 GA Initial commit.

Co-authored-by: Sandeep Parab <rparab@ntdev.microsoft.com>
…ble/2020-09-01.12.0 (#14170)

* [Batch] Update RemoveNodes description to include max nodes/request

* Added suppressions to readme
…4168)

* Unify names

* Update tag

* Update due to review meeting

* update example description

Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>
* Add new 1.0.0 version for IoT Central API

* fix swagger style

* fix wrong json file name

* remove unused examples

* revert back email format

* remove non-used examples

* update with latest examples

* update preview from 2019-10-28-preview to 2021-04-30-preview

* remove extra ---

* update version from 1.0.0 to 1.0

* rollback collections for common entities

* update _id to Id, update _name to Name from operation, add sdk generation

* fix go sdk file

* remove go sdk

* updatedevicve_templateId to deviceTemplateId

* Add query parameter based versioning, remove resource schema

* fix example docs reference

* fix typo in comments

* renaming execute to run for command operations

* add api-version to samples files, fix devices_update missining issue

* add devices_update.json for 1.0

* fix rerun_id, add missing parameters to examples for preview, fix command comments from execute to run

* fix annoymous type issues
* base for Microsoft.Resources 2021-04-01

* update readme

* update api version

* API changes for S2S

* readme

Co-authored-by: Wendy Chang <wendychang@gmail.com>
…o-Restore. (#14013)

* Added Recoverable Servers API and GeoRestore API.

* Fixed spell check and prettier

* Fixed readme.md file issue and changed the postgreSQL to restore.

* Fixed duplicate schema issue.

* Fixed the mismatch with namespace names.

* change the tag name from georestore to servers

* Fixed the SDK validation issues.

* Fixed objects w.r.t preview version

* Fixed operation required properties.

* Included 2020-04-10 in the SDK versions

* Change the folder path.
* add missing multiapi entry

* fix one output-folder
* add new API

* ad name to enum

* updatre defenition names

* update readme

* update readme

* update readme path files

* fix errors

* add missing connectors

* execute validation

* execute pre

* update readme

* add description ans x-ms-enum

* update description

* update properties

* add description

* rename enum - fix new error that didnt display until now

* rename enum unser x-ms-enum property
…n preview/2.0, preview/2.0, preview/2.0, preview/2.0, preview/2.0, preview/2.0 and preview/2.0 (#13921)

* Copy Creator API 1.0 to 2.0

* draft of planB

* adding ontology properties; adding DataUpload

* updated alias apis

* put v1 API back so diffing is easier

* reapplying v2 so diffs are easier

* remove type from datasetsources

* incorporate suggestions from review board

* adding ontology field

* Update alias v2 apis.

* fix conversion descriptions, update alias

* Fix the alias file.

* Add get details example.

* fix casing on headers; mapData more consistent

* minor comment and linting fixes

* Adds base for updating Microsoft.Maps/Alias from version preview/1.0 to version 2.0

* Updates readme

* Updates API version in new specs and examples

* Add baseline from preview/1.0

* update api-version in examples

* add v2 files to readme

* fix avacado errors

* Adding string length limit to the descriptions for feature state.

Adding string length limit to the descriptions for feature state.

* Adding ontology element to the WFS resopnse examples.

Adding ontology element to the WFS resopnse examples.

* Updating length to 1000 from 1024.

Updating length to 1000 from 1024.

* Update dataset v2 descriptions and examples.

* Update the examples to have the right details.

* reran linter; added spellcheck words

* more linting: 202 description alignment

* fixed example linting for alias, data, dataset

* example linting changes for conv, fs, tileset

* change featurestateset patch to put

* autorest linting fixes

* Reverting FeatureState body to include array to match V1 body and response.

* adding missing operationIds

* added examples; more linting

* remove x-ms-long-running

* Update alias documentation for resourceId -> creatorDataItemId change

Co-authored-by: Robert Johnson <rojohn@microsoft.com>
Co-authored-by: Subbarayudu Kamma <skamma@microsoft.com>
* Update attribute name for message metadata

* Apply Prettier

* Prettier fix

Co-authored-by: Po Tsang <tsangpo@microsoft.com>
…rtualNetwork (#14018)

* Add CreateOrUpdateSwiftVirtualNetworkConnectionWithCheck, and site-level virtualNetworkSubnetId field

* Add site-level virtualNetworkSubnetId field

* Tabs vs spaces

* Removing the new property since it's technically a 'breaking change'

* Add changes needed for correct .NET SDK generation issues. Reference PR: Azure/azure-sdk-for-net#20300

* Fix prettier issue.

* Remove breaking changes other than property order changes

* Make it pretty again

* Added new properties SiteConfig.PublicNetworkAccess and Site.virtualNetworkSubnetId to enable azure policy

* Fix prettier and spellcheck issue

* Fix spellcheck issue

* Add virtualNetworkSubnetId prperty to Site objec tmodel

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
* Fix CI for EG data-plane

* Update readme.md
…to add version stable/2021-01-01 (#14130)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-12-01 to version 2021-01-01

* Updates readme

* Updates API version in new specs and examples

* Adding user data flags

* Wrong word

Co-authored-by: jmccarthy <jmccarthy@microsoft.com>
Co-authored-by: Ben Viglietta <benvi@ntdev.microsoft.com>
Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
…ationStores (#14083)

* add fillGapWithZero property

* move new property to the end
* fix changeableAttributes property for Manifest and Repository

* separate resource type attributes

Signed-off-by: GitHub <noreply@github.com>

* fix patch schema

Signed-off-by: GitHub <noreply@github.com>

* address comment
This was referenced Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.