-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureStack][Admin API] Adding azurestack AKS admin spec #14700
Conversation
Hi, @Bhuvaneswari-Santharam Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
...nerservice/Microsoft.ContainerService.Admin/preview/2019-11-01/examples/Operations/List.json
Outdated
Show resolved
Hide resolved
...nerservice/Microsoft.ContainerService.Admin/preview/2019-11-01/examples/Operations/List.json
Outdated
Show resolved
Hide resolved
...er/containerservice/Microsoft.ContainerService.Admin/preview/2019-11-01/managedclusters.json
Outdated
Show resolved
Hide resolved
...er/containerservice/Microsoft.ContainerService.Admin/preview/2019-11-01/managedclusters.json
Outdated
Show resolved
Hide resolved
@leni-msft Could you please review this PR? |
Hi, @Bhuvaneswari-Santharam your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft |
@bganapa please fix the lint warnings, per ARM requirements |
@leni-msft - All the lint warning are fixed. Could you please review? |
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board. |
Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently. Please create new branch with this recommendation for review to be continued. |
@chiragg4u This is a new RP spec. There is no existing API spec for this RP. The RP is specific to Azure Stack Operator and wont be deployed in azure |
@chiragg4u could you review the PR |
Hi, @Bhuvaneswari-Santharam. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @Bhuvaneswari-Santharam. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
...inerservice/Microsoft.ContainerService.Admin/preview/2019-11-01-preview/managedClusters.json
Outdated
Show resolved
Hide resolved
...inerservice/Microsoft.ContainerService.Admin/preview/2019-11-01-preview/managedClusters.json
Outdated
Show resolved
Hide resolved
...ce/Microsoft.ContainerService.Admin/preview/2019-11-01-preview/examples/Operations/List.json
Outdated
Show resolved
Hide resolved
Hi, @Bhuvaneswari-Santharam your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Default branch of the spec repo has been updated as main, I have updated the PR to target main branch |
Hi @Bhuvaneswari-Santharam, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@jianyexi Could you pls help review this PR and merge? |
@chiragg4u could you review it ? |
@chiragg4u This is a new API Spec. The API surface is exposed only for AzureStack Operator (differentiated with .Admin in the namespace). these are not exposed in Azure. Appreciate your review and approval on this PR as we are looking to ship the powershell interface. The PR earlier got closed by bot for inactivity. |
@chiragg4u Could you pls review? |
...ger/containerservice/Microsoft.ContainerService.Admin/stable/2019-11-01/managedClusters.json
Show resolved
Hide resolved
...ger/containerservice/Microsoft.ContainerService.Admin/stable/2019-11-01/managedClusters.json
Show resolved
Hide resolved
@jianyexi could you pls merge this PR? |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.