Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureStack][Admin API] Adding azurestack AKS admin spec #14700

Merged
merged 12 commits into from
Aug 25, 2021

Conversation

Bhuvaneswari-Santharam
Copy link
Member

@Bhuvaneswari-Santharam Bhuvaneswari-Santharam commented Jun 7, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Bhuvaneswari-Santharam Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 7, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerservice/readme.md",
    "tag":"package-2019-11-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerservice/readme.md",
    "tag":"package-2019-11-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerservice/readme.md",
    "tag":"package-2019-11-01",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"azsadmin/resource-manager/containerservice/readme.md",
    "tag":"package-2019-11-01",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 7, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @bganapa bganapa self-assigned this Jun 7, 2021
    @bganapa bganapa changed the title Adding azirestack AKS admin spec [AzureStack][Admin API] Adding azurestack AKS admin spec Jun 7, 2021
    @bganapa
    Copy link
    Member

    bganapa commented Jun 9, 2021

    @leni-msft Could you please review this PR?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 9, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @Bhuvaneswari-Santharam your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft

    @leniatgh
    Copy link
    Contributor

    @bganapa please fix the lint warnings, per ARM requirements

    @Bhuvaneswari-Santharam
    Copy link
    Member Author

    @leni-msft - All the lint warning are fixed. Could you please review?

    @chiragg4u
    Copy link
    Contributor

    Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

    @chiragg4u
    Copy link
    Contributor

    Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.

    Please create new branch with this recommendation for review to be continued.

    @bganapa
    Copy link
    Member

    bganapa commented Jun 16, 2021

    @chiragg4u This is a new RP spec. There is no existing API spec for this RP. The RP is specific to Azure Stack Operator and wont be deployed in azure

    @leniatgh leniatgh assigned jianyexi and unassigned leniatgh Jun 21, 2021
    @jianyexi
    Copy link
    Contributor

    @chiragg4u could you review the PR

    @ghost
    Copy link

    ghost commented Jul 18, 2021

    Hi, @Bhuvaneswari-Santharam. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Aug 2, 2021

    Hi, @Bhuvaneswari-Santharam. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @bganapa bganapa reopened this Aug 13, 2021
    @ghost ghost removed the no-recent-activity label Aug 13, 2021
    @zhenglaizhang zhenglaizhang changed the base branch from master to main August 13, 2021 03:34
    @openapi-workflow-bot
    Copy link

    Hi, @Bhuvaneswari-Santharam your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @zhenglaizhang
    Copy link
    Contributor

    Default branch of the spec repo has been updated as main, I have updated the PR to target main branch

    @openapi-workflow-bot
    Copy link

    Hi @Bhuvaneswari-Santharam, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @bganapa
    Copy link
    Member

    bganapa commented Aug 16, 2021

    @jianyexi Could you pls help review this PR and merge?

    @jianyexi
    Copy link
    Contributor

    @chiragg4u could you review it ?

    @bganapa
    Copy link
    Member

    bganapa commented Aug 17, 2021

    @chiragg4u This is a new API Spec. The API surface is exposed only for AzureStack Operator (differentiated with .Admin in the namespace). these are not exposed in Azure. Appreciate your review and approval on this PR as we are looking to ship the powershell interface. The PR earlier got closed by bot for inactivity.

    @bganapa
    Copy link
    Member

    bganapa commented Aug 19, 2021

    @chiragg4u Could you pls review?

    @pilor pilor self-requested a review August 20, 2021 17:27
    @pilor pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Aug 20, 2021
    @bganapa
    Copy link
    Member

    bganapa commented Aug 24, 2021

    @jianyexi could you pls merge this PR?

    @jianyexi jianyexi merged commit 3e8800d into Azure:main Aug 25, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants