Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed resource type definition for Microsoft.ApiManagement/service/apis/schemas #14769

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

yingru97
Copy link
Contributor

@yingru97 yingru97 commented Jun 11, 2021

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: Bugfix of existing spec
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@yingru97 yingru97 requested a review from solankisamir as a code owner June 11, 2021 00:09
@openapi-workflow-bot
Copy link

Hi, @DreamlessA Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 11, 2021

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4977:9
    Old: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4977:9
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4988:5
    Old: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4988:5
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'value' renamed or removed?
    Old: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4989:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'definitions' renamed or removed?
    Old: Microsoft.ApiManagement/preview/2021-01-01-preview/definitions.json#L4989:7
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"apimanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the API Management label Jun 11, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 11, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - apimanagement/mgmt/2020-12-01/apimanagement - v55.2.0
    +	Field `ActionLog` of struct `OperationResultContract` has been removed
    +	Field `Branch` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `CommitID` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `ConfigurationChangeDate` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `Error` of struct `OperationResultContract` has been removed
    +	Field `IsExport` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `IsGitEnabled` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `IsSynced` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `ResultInfo` of struct `OperationResultContract` has been removed
    +	Field `Started` of struct `OperationResultContract` has been removed
    +	Field `Status` of struct `OperationResultContract` has been removed
    +	Field `SyncDate` of struct `TenantConfigurationSyncStateContract` has been removed
    +	Field `Updated` of struct `OperationResultContract` has been removed
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2019-12-01/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2019-01-01/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2018-01-01/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2017-03-01/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2016-10-10/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - apimanagement/mgmt/2016-07-07/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - preview/apimanagement/mgmt/2019-12-01-preview/apimanagement - v55.2.0
    ️✔️azure-sdk-for-go - preview/apimanagement/mgmt/2018-06-01-preview/apimanagement - v55.2.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-apimanagement - 2.0.0
    +	Model SchemaContract no longer has parameter definitions
    +	Model SchemaContract no longer has parameter value
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 2b0b50e. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByApi' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityState' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    • Microsoft.Azure.Management.ApiManagement [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Customization/Models/SchemaContract.cs(23,33): error CS0428: Cannot convert method group 'Value' to non-delegate type 'string'. Did you intend to invoke the method? [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Microsoft.Azure.Management.ApiManagement.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from 2b0b50e. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.5.0/node_modules/@octokit/request/dist-node/index.js:76:23
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️apimanagement/mgmt/2020-12-01/apimanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - New function `*TenantConfigurationSyncStateContract.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `TenantConfigurationSyncStateContract.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `OperationResultContractProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*OperationResultContract.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `OperationResultContractProperties`
      info	[Changelog] - New struct `TenantConfigurationSyncStateContractProperties`
      info	[Changelog] - New anonymous field `*OperationResultContractProperties` in struct `OperationResultContract`
      info	[Changelog] - New field `Name` in struct `OperationResultContract`
      info	[Changelog] - New field `Type` in struct `OperationResultContract`
      info	[Changelog] - New anonymous field `*TenantConfigurationSyncStateContractProperties` in struct `TenantConfigurationSyncStateContract`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 10 additive change(s).
      info	[Changelog]
    • ️✔️apimanagement/mgmt/2019-12-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2019-01-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2018-01-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2017-03-01/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2016-10-10/apimanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️apimanagement/mgmt/2016-07-07/apimanagement [View full logs
      info	[Changelog] No exported changes
      error	Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
      error	The following packages are still pending:
      error		apimanagement/mgmt/2020-12-01/apimanagement
      error		apimanagement/mgmt/2019-12-01/apimanagement
      error		apimanagement/mgmt/2019-01-01/apimanagement
      error		apimanagement/mgmt/2018-01-01/apimanagement
      error		apimanagement/mgmt/2017-03-01/apimanagement
      error		apimanagement/mgmt/2016-10-10/apimanagement
      error		apimanagement/mgmt/2016-07-07/apimanagement
      error		preview/apimanagement/mgmt/2019-12-01-preview/apimanagement
      error		preview/apimanagement/mgmt/2018-06-01-preview/apimanagement
    • ️✔️preview/apimanagement/mgmt/2019-12-01-preview/apimanagement
    • ️✔️preview/apimanagement/mgmt/2018-06-01-preview/apimanagement
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2b0b50e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-apimanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ApiUpdateContract has a new parameter contact
      info	[Changelog]   - Model ApiUpdateContract has a new parameter license
      info	[Changelog]   - Model ApiUpdateContract has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiContractProperties has a new parameter contact
      info	[Changelog]   - Model ApiContractProperties has a new parameter license
      info	[Changelog]   - Model ApiContractProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiManagementServiceBaseProperties has a new parameter public_ip_address_id
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter contact
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter license
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiContract has a new parameter contact
      info	[Changelog]   - Model ApiContract has a new parameter license
      info	[Changelog]   - Model ApiContract has a new parameter terms_of_service_url
      info	[Changelog]   - Model OperationResultContract has a new parameter name
      info	[Changelog]   - Model OperationResultContract has a new parameter type
      info	[Changelog]   - Model OperationResultContract has a new parameter operation_result_contract_id
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter contact
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter license
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model AdditionalLocation has a new parameter public_ip_address_id
      info	[Changelog]   - Model SchemaContract has a new parameter document
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter contact
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter license
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiManagementServiceUpdateParameters has a new parameter public_ip_address_id
      info	[Changelog]   - Model HostnameConfiguration has a new parameter certificate_status
      info	[Changelog]   - Model HostnameConfiguration has a new parameter certificate_source
      info	[Changelog]   - Model TenantConfigurationSyncStateContract has a new parameter last_operation_id
      info	[Changelog]   - Model ParameterContract has a new parameter schema_id
      info	[Changelog]   - Model ParameterContract has a new parameter type_name
      info	[Changelog]   - Model ApiManagementServiceResource has a new parameter public_ip_address_id
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ApiSchemaOperations.create_or_update has a new signature
      info	[Changelog]   - Operation ApiSchemaOperations.create_or_update has a new signature
      info	[Changelog]   - Model SchemaContract no longer has parameter value
      info	[Changelog]   - Model SchemaContract no longer has parameter definitions
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2b0b50e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-apimanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ApiManagementServiceBaseProperties has a new parameter public_ip_address_id
      info	[Changelog]   - Model ApiContractProperties has a new parameter license
      info	[Changelog]   - Model ApiContractProperties has a new parameter contact
      info	[Changelog]   - Model ApiContractProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiManagementServiceUpdateProperties has a new parameter public_ip_address_id
      info	[Changelog]   - Model SchemaContract has a new parameter document
      info	[Changelog]   - Model OperationResultContract has a new parameter id_properties_id
      info	[Changelog]   - Model OperationResultContract has a new parameter name
      info	[Changelog]   - Model OperationResultContract has a new parameter type
      info	[Changelog]   - Model AdditionalLocation has a new parameter public_ip_address_id
      info	[Changelog]   - Model ApiContractUpdateProperties has a new parameter license
      info	[Changelog]   - Model ApiContractUpdateProperties has a new parameter contact
      info	[Changelog]   - Model ApiContractUpdateProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model ParameterContract has a new parameter schema_id
      info	[Changelog]   - Model ParameterContract has a new parameter type_name
      info	[Changelog]   - Model ApiManagementServiceUpdateParameters has a new parameter public_ip_address_id
      info	[Changelog]   - Model ApiManagementServiceProperties has a new parameter public_ip_address_id
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter license
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter contact
      info	[Changelog]   - Model ApiCreateOrUpdateParameter has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter license
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter contact
      info	[Changelog]   - Model ApiTagResourceContractProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter license
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter contact
      info	[Changelog]   - Model ApiEntityBaseContract has a new parameter terms_of_service_url
      info	[Changelog]   - Model TenantConfigurationSyncStateContract has a new parameter last_operation_id
      info	[Changelog]   - Model ApiUpdateContract has a new parameter license
      info	[Changelog]   - Model ApiUpdateContract has a new parameter contact
      info	[Changelog]   - Model ApiUpdateContract has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiCreateOrUpdateProperties has a new parameter license
      info	[Changelog]   - Model ApiCreateOrUpdateProperties has a new parameter contact
      info	[Changelog]   - Model ApiCreateOrUpdateProperties has a new parameter terms_of_service_url
      info	[Changelog]   - Model ApiManagementServiceResource has a new parameter public_ip_address_id
      info	[Changelog]   - Model HostnameConfiguration has a new parameter certificate_status
      info	[Changelog]   - Model HostnameConfiguration has a new parameter certificate_source
      info	[Changelog]   - Model ApiContract has a new parameter license
      info	[Changelog]   - Model ApiContract has a new parameter contact
      info	[Changelog]   - Model ApiContract has a new parameter terms_of_service_url
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model SchemaContract no longer has parameter definitions
      info	[Changelog]   - Model SchemaContract no longer has parameter value
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2b0b50e. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
      cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    • ️✔️@azure/arm-apimanagement [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
      cmderr	[npmPack] created ./dist/arm-apimanagement.js in 1.3s
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2b0b50e. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️apimanagement [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @DreamlessA, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    …is/schemas (Azure#14769)
    
    * fixed ApiManagement/service/apis/schemas
    
    * updated schema/document definition
    
    Co-authored-by: Alan Feng <alanfeng@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …is/schemas (Azure#14769)
    
    * fixed ApiManagement/service/apis/schemas
    
    * updated schema/document definition
    
    Co-authored-by: Alan Feng <alanfeng@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    API Management Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants