[Hub Generated] Review request for Microsoft.Media to add version stable/2021-06-01 Part-1 #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to version 2021-06-01
…files except encoding.
|
Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1209 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1303 |
|
The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1351 |
| Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L797 |
|
| Guid used in model definition 'MediaServiceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L584 |
|
| Guid used in model definition 'UserAssignedManagedIdentity' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L610 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useSystemAssignedIdentity Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L654 |
|
| 'UserAssignedManagedIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L608 |
|
| 'ResourceIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L648 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| Since operation 'Assets_GetEncryptionKey' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Media/stable/2021-06-01/AssetsAndAssetFilters.json#L836 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L290 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1112 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1165 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1209 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1259 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1303 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1351 |
|
| The summary and description values should not be same. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1408 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Media/stable/2021-06-01/Accounts.json#L1165 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 102 Errors, 168 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/AccountFilters.json compared with base:stable/2020-05-01/AccountFilters.json
- current:stable/2021-06-01/AccountFilters.json compared with base:preview/2019-05-01-preview/AccountFilters.json
- current:stable/2021-06-01/Accounts.json compared with base:stable/2021-05-01/Accounts.json
- current:stable/2021-06-01/Accounts.json compared with base:preview/2019-05-01-preview/Accounts.json
- current:stable/2021-06-01/AssetsAndAssetFilters.json compared with base:stable/2020-05-01/AssetsAndAssetFilters.json
- current:stable/2021-06-01/AssetsAndAssetFilters.json compared with base:preview/2019-05-01-preview/AssetsAndAssetFilters.json
- current:stable/2021-06-01/ContentKeyPolicies.json compared with base:stable/2020-05-01/ContentKeyPolicies.json
- current:stable/2021-06-01/ContentKeyPolicies.json compared with base:preview/2019-05-01-preview/ContentKeyPolicies.json
- current:stable/2021-06-01/StreamingPoliciesAndStreamingLocators.json compared with base:stable/2020-05-01/StreamingPoliciesAndStreamingLocators.json
- current:stable/2021-06-01/StreamingPoliciesAndStreamingLocators.json compared with base:preview/2019-05-01-preview/StreamingPoliciesAndStreamingLocators.json
- current:stable/2021-06-01/streamingservice.json compared with base:stable/2020-05-01/streamingservice.json
- current:stable/2021-06-01/streamingservice.json compared with base:preview/2019-05-01-preview/streamingservice.json
Only 10 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"mediaservices/resource-manager/readme.md",
"tag":"package-2021-06",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Jun 24, 2021
This was referenced Jun 24, 2021
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Please go through and complete the checklist in the PR description prior to PR review |
giakas
changed the title
|
Hi, @giakas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
pilor
reviewed
Jun 28, 2021
...ation/mediaservices/resource-manager/Microsoft.Media/stable/2021-06-01/streamingservice.json
Outdated
Show resolved
Hide resolved
pilor
added
ARMSignedOff
giakas
commented
Jun 28, 2021
specification/mediaservices/resource-manager/Microsoft.Media/stable/2021-06-01/Accounts.json
Show resolved
Hide resolved
|
Hi @giakas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
This was referenced Jun 30, 2021
Closed
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ble/2021-06-01 Part-1 (Azure#14970) * Adds base for updating Microsoft.Media from version stable/2021-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * Update the branch with copy of all other services 2020-05-01 version files except encoding. * update AMS to 2021-06-01 Part1 (All swaggers except encoding) * fix some lint errors. * Fix an unreferenced file. * fix more linting errors * remove some unreferenced files. * Fix systemData in streamingservice * fix more linting errors * fix 404s * fix more lint errors * fix 204 issue for delete * fix definitions to use v2 common-types * remove type for the live event list list defenition * Revert "remove type for the live event list list defenition" This reverts commit 0f66253. * removed unused definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.