Changes to fix the Resource Provider name casing issue for Azure Postgres, MySQL and MariaDB #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gres, MySQL and MariaDB services
|
Hi, @shinilm Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L220:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForMariaDB/servers' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L256:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/restart' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L289:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/replicas' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L332:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/firewallRules/{firewallRuleName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L371:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/firewallRules' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L507:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/virtualNetworkRules/{virtualNetworkRuleName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L546:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/virtualNetworkRules' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L691:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMariaDB/servers/{serverName}/databases/{databaseName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L733:5 |
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 2 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/mariadb/resource-manager/readme.md tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01 |
|
| The default tag contains multiple API versions swaggers. readme: specification/mysql/resource-manager/readme.md tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- mariadb/resource-manager/readme.md#package-2018-06-01-preview
- mariadb/resource-manager/readme.md#package-2018-06-01
- mariadb/resource-manager/readme.md#package-2018-06-01-privatepreview
- mariadb/resource-manager/readme.md#package-2020-01-01
- mysql/resource-manager/readme.md#package-2017-12-01-preview
- mysql/resource-manager/readme.md#package-2017-12-01
- mysql/resource-manager/readme.md#package-2018-06-01-privatepreview
- mysql/resource-manager/readme.md#package-2018-06-01
- mysql/resource-manager/readme.md#package-2020-01-01
- postgresql/resource-manager/readme.md#package-2020-01-01
- postgresql/resource-manager/readme.md#package-2018-06-01
- postgresql/resource-manager/readme.md#package-2017-12-01-preview
- postgresql/resource-manager/readme.md#package-2017-12-01
|:speech_balloon: AutorestCore/Exception|"readme":"mariadb/resource-manager/readme.md",
"tag":"package-2018-06-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"mariadb/resource-manager/readme.md",
"tag":"package-2018-06-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:243" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:247" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"mariadb/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Duplicate Schema named CloudError -- properties.error.description: undefined => "Error message" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mariadb/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"mysql/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:265" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mysql/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:269" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mysql/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"mysql/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Duplicate Schema named CloudError -- properties.error.description: undefined => "Error message" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"mysql/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=229559&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 9.0.0❌azure-sdk-for-go - mariadb/mgmt/2020-01-01/mariadb - v55.5.0+ Const `FiveFullStopSeven` has been removed + Const `FiveFullStopSix` has been removed
❌azure-sdk-for-go - mariadb/mgmt/2018-06-01/mariadb - v55.5.0+ Const `FiveFullStopSeven` has been removed + Const `FiveFullStopSix` has been removed
️✔️azure-sdk-for-go - mysql/mgmt/2020-01-01/mysql - v55.5.0️✔️azure-sdk-for-go - mysql/mgmt/2017-12-01/mysql - v55.5.0️✔️azure-sdk-for-go - preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers - v55.5.0️✔️azure-sdk-for-go - preview/mysql/mgmt/2017-12-01-preview/mysql - v55.5.0️✔️azure-sdk-for-go - postgresql/mgmt/2021-06-01/postgresqlflexibleservers - v55.5.0️✔️azure-sdk-for-go - postgresql/mgmt/2020-01-01/postgresql - v55.5.0️✔️azure-sdk-for-go - postgresql/mgmt/2017-12-01/postgresql - v55.5.0️✔️azure-sdk-for-go - preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers - v55.5.0️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers - v55.5.0️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers - v55.5.0️✔️azure-sdk-for-go - preview/postgresql/mgmt/2017-12-01-preview/postgresql - v55.5.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 warn specification/postgresql/resource-manager/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.MariaDB [View full logs] [Release SDK Changes]warn Skip artifact folder because it doesn't exist: artifacts/packages
️✔️Microsoft.Azure.Management.MySQL [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/mysql/resource-manager/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-rdbms [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-07-02 15:13:13 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-mariadb;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2021-07-02 15:13:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2021-07-02 15:13:13 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md cmderr [generate.py] 2021-07-02 15:13:55 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-mariadb cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Skip] pom already has module azure-resourcemanager-mariadb cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Skip] pom already has module sdk/mariadb cmderr [generate.py] 2021-07-02 15:13:55 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-mariadb [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-mariadb-1.0.0-beta.2-javadoc.jar
- azure-resourcemanager-mariadb-1.0.0-beta.2.jar
- azure-resourcemanager-mariadb-1.0.0-beta.2-sources.jar
cmderr [Inst] 2021-07-02 15:15:32 DEBUG Got artifact_id: azure-resourcemanager-mariadb cmderr [Inst] 2021-07-02 15:15:32 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-02 15:15:32 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.2-javadoc.jar cmderr [Inst] 2021-07-02 15:15:32 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.2.jar cmderr [Inst] 2021-07-02 15:15:32 DEBUG Match jar package: azure-resourcemanager-mariadb-1.0.0-beta.2.jar cmderr [Inst] 2021-07-02 15:15:32 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15016/azure-sdk-for-java/azure-resourcemanager-mariadb/azure-resourcemanager-mariadb-1.0.0-beta.2.jar\" -o azure-resourcemanager-mariadb-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mariadb -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mariadb-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}️✔️azure-resourcemanager-mysql [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-mysql-1.1.0-beta.1-sources.jar
- azure-resourcemanager-mysql-1.1.0-beta.1-javadoc.jar
- azure-resourcemanager-mysql-1.1.0-beta.1.jar
cmderr [Inst] 2021-07-02 15:17:24 DEBUG Got artifact_id: azure-resourcemanager-mysql cmderr [Inst] 2021-07-02 15:17:24 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-02 15:17:24 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1-sources.jar cmderr [Inst] 2021-07-02 15:17:24 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1-javadoc.jar cmderr [Inst] 2021-07-02 15:17:24 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1.jar cmderr [Inst] 2021-07-02 15:17:24 DEBUG Match jar package: azure-resourcemanager-mysql-1.1.0-beta.1.jar cmderr [Inst] 2021-07-02 15:17:24 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15016/azure-sdk-for-java/azure-resourcemanager-mysql/azure-resourcemanager-mysql-1.1.0-beta.1.jar\" -o azure-resourcemanager-mysql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mysql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mysql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}️✔️azure-resourcemanager-postgresql [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-postgresql-1.1.0-beta.1-javadoc.jar
- azure-resourcemanager-postgresql-1.1.0-beta.1-sources.jar
- azure-resourcemanager-postgresql-1.1.0-beta.1.jar
cmderr [Inst] 2021-07-02 15:19:06 DEBUG Got artifact_id: azure-resourcemanager-postgresql cmderr [Inst] 2021-07-02 15:19:06 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-02 15:19:06 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1-javadoc.jar cmderr [Inst] 2021-07-02 15:19:06 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1-sources.jar cmderr [Inst] 2021-07-02 15:19:06 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1.jar cmderr [Inst] 2021-07-02 15:19:06 DEBUG Match jar package: azure-resourcemanager-postgresql-1.1.0-beta.1.jar cmderr [Inst] 2021-07-02 15:19:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15016/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.1.0-beta.1.jar\" -o azure-resourcemanager-postgresql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 10 items here, please refer to log for details.
️✔️mariadb/mgmt/2020-01-01/mariadb [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForReplica` info [Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForGeoRestore` info [Changelog] info [Changelog] Total 2 breaking change(s), 83 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️mariadb/mgmt/2018-06-01/mariadb [View full logs] Breaking Change Detectedinfo [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinimalTLSVersion` in struct `ServerUpdateParametersProperties` info [Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForCreate` info [Changelog] info [Changelog] Total 2 breaking change(s), 83 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️mysql/mgmt/2020-01-01/mysql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 69 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️mysql/mgmt/2017-12-01/mysql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 60 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers [View full logs]info [Changelog] - New struct `ConfigurationsBatchUpdateFuture` info [Changelog] - New field `Status` in struct `ServerVersionCapability` info [Changelog] - New field `Status` in struct `CapabilityProperties` info [Changelog] - New field `FileStorageSkuName` in struct `StorageProfile` info [Changelog] - New field `Status` in struct `VcoreCapability` info [Changelog] - New field `Status` in struct `ServerEditionCapability` info [Changelog] - New field `Status` in struct `StorageEditionCapability` info [Changelog] info [Changelog] Total 0 breaking change(s), 14 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️preview/mysql/mgmt/2017-12-01-preview/mysql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 60 additive change(s). info [Changelog]
️✔️postgresql/mgmt/2021-06-01/postgresqlflexibleservers [View full logs]info [Changelog] No exported changes
- Only show 10 items here, please refer to log for details.
️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 60 additive change(s). info [Changelog]
- Only show 10 items here, please refer to log for details.
️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 60 additive change(s). info [Changelog]
️✔️preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers [View full logs]info [Changelog] This is a new package
- Only show 10 items here, please refer to log for details.
️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments` info [Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties` info [Changelog] - New field `SourceSubscriptionID` in struct `ServerProperties` info [Changelog] - New field `SourceResourceGroupName` in struct `ServerProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 3 additive change(s). info [Changelog]
️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]info [Changelog] No exported changes
- Only show 10 items here, please refer to log for details.
️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]info [Changelog] - New struct `ServerSecurityAlertPolicyListResultPage` info [Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties` info [Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 60 additive change(s). info [Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
️✔️@azure/arm-mariadb [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/mariaDBManagementClient.js → ./dist/arm-mariadb.js... cmderr [npmPack] created ./dist/arm-mariadb.js in 482ms
️✔️@azure/arm-mysql [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/mySQLManagementClient.js → ./dist/arm-mysql.js... cmderr [npmPack] created ./dist/arm-mysql.js in 533ms
️✔️@azure/arm-postgresql-flexible [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql-flexible.js... cmderr [npmPack] created ./dist/arm-postgresql-flexible.js in 341ms
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️mariadb [View full logs] [Release Schema Changes]️✔️mysql [View full logs] [Release Schema Changes]️✔️postgresql [View full logs] [Release Schema Changes]
️⚠️ azure-sdk-for-python warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/mariadb/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk warn specification/postgresql/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-rdbms [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation MySQLManagementClientOperationsMixin.reset_query_performance_insight_data info [Changelog] - Added operation group ServerBasedPerformanceTierOperations info [Changelog] - Added operation group ServerParametersOperations info [Changelog] - Added operation group RecoverableServersOperations
ghost
added
the
customer-reported
|
Thank you for your contribution shinilm! We will review the pull request and get back to you soon. |
|
Hi @shinilm, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
This was referenced Jun 28, 2021
This was referenced Jun 28, 2021
QingqingYuan2
approved these changes
Jun 28, 2021
…gres, MySQL and MariaDB services
…ure Postgres, MySQL and MariaDB services" This reverts commit ecc38dc.
JeffreyRichter
added
the
Approved-BreakingChange
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PhoenixHe-NV
approved these changes
Jul 2, 2021
|
@jianyexi @shinilm Service swagger contains too much existing lint issue so the check could not be updated. |
This was referenced Jul 2, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…gres, MySQL and MariaDB (Azure#15016) * Changes to fix the Resource provided name casing issue for Azure Postgres, MySQL and MariaDB services * Changes to fix the Resource provided name casing issue for Azure Postgres, MySQL and MariaDB services * Revert "Changes to fix the Resource provided name casing issue for Azure Postgres, MySQL and MariaDB services" This reverts commit ecc38dc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to fix the Resource Provider name casing issue for Azure Postgres, MySQL and MariaDB
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.