Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus and EventHub : 2021-06-01-preview - Added optional Properties #15233

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Service Bus and EventHub : 2021-06-01-preview - Added optional Properties #15233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d39987
removing min/max, adding maxMessageSizeInKilobytes to queues and topics
Jul 16, 2021
921baf4
reverted maxSizeInMegabytes type to int32
Jul 19, 2021
e4579da
fixed the typo
Jul 19, 2021
02d87b1
reverted topic maxSizeInMegabytes to int32
Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...on/eventhub/resource-manager/Microsoft.EventHub/preview/2021-06-01-preview/eventhubs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,15 +248,11 @@
"intervalInSeconds": {
"format": "int32",
"type": "integer",
"maximum": 900,
"minimum": 60,
"description": "The time window allows you to set the frequency with which the capture to Azure Blobs will happen, value should between 60 to 900 seconds"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava The description also needs to be either removed or changed

"sizeLimitInBytes": {
"format": "int32",
"type": "integer",
"maximum": 524288000,
"minimum": 10485760,
"description": "The size window defines the amount of data built up in your Event Hub before an capture operation, value should be between 10485760 to 524288000 bytes"
},
v-Ajnava marked this conversation as resolved.
Show resolved Hide resolved
"destination": {
Expand Down
2 changes: 0 additions & 2 deletions ...ub/resource-manager/Microsoft.EventHub/preview/2021-06-01-preview/namespaces-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,6 @@
"maximumThroughputUnits": {
"format": "int32",
"type": "integer",
"maximum": 20,
"minimum": 0,
"description": "Upper limit of throughput units when AutoInflate is enabled, value should be within 0 to 20 throughput units. ( '0' if AutoInflateEnabled = true)"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava The description also needs to be either removed or changed

"kafkaEnabled": {
Expand Down
5 changes: 5 additions & 0 deletions ...on/servicebus/resource-manager/Microsoft.ServiceBus/preview/2021-06-01-preview/Queue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,11 @@
"type": "integer",
"description": "The maximum size of the queue in megabytes, which is the size of memory allocated for the queue. Default is 1024."
},
"maxMessageSizeInKilobytes": {
"format": "int64",
"type": "integer",
"description": "Maximum size (in KB) of the message payload that can be accepted by the queue. This property is only used in Premium today and default is 1024."
},
"requiresDuplicateDetection": {
"type": "boolean",
"description": "A value indicating if this queue requires duplicate detection."
Expand Down
3 changes: 0 additions & 3 deletions ...on/servicebus/resource-manager/Microsoft.ServiceBus/preview/2021-06-01-preview/Rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,6 @@
"compatibilityLevel": {
"format": "int32",
"type": "integer",
"default": 20,
"minimum": 20,
"maximum": 20,
"description": "This property is reserved for future use. An integer value showing the compatibility level, currently hard-coded to 20."
v-Ajnava marked this conversation as resolved.
Show resolved Hide resolved
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava Also for eventhubs since this is removed, would there be new examples reflecting the new change or thats optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its optional and we don't have min/max in examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as recommended, removed min/max and description will have the range.

"requiresPreprocessing": {
Expand Down
1 change: 1 addition & 0 deletions ...anager/Microsoft.ServiceBus/preview/2021-06-01-preview/examples/Queues/SBQueueCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"properties": {
"lockDuration": "PT1M",
"maxSizeInMegabytes": 163840,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"requiresSession": false,
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
Expand Down
1 change: 1 addition & 0 deletions ...e-manager/Microsoft.ServiceBus/preview/2021-06-01-preview/examples/Queues/SBQueueGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"properties": {
"lockDuration": "PT1M",
"maxSizeInMegabytes": 163840,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"requiresSession": false,
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
Expand Down
1 change: 1 addition & 0 deletions ...crosoft.ServiceBus/preview/2021-06-01-preview/examples/Queues/SBQueueListByNameSpace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"properties": {
"lockDuration": "PT1M",
"maxSizeInMegabytes": 163840,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"requiresSession": false,
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
Expand Down
1 change: 1 addition & 0 deletions ...anager/Microsoft.ServiceBus/preview/2021-06-01-preview/examples/Topics/SBTopicCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"properties": {
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
"maxSizeInMegabytes": 10240,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"duplicateDetectionHistoryTimeWindow": "PT10M",
"enableBatchedOperations": true,
Expand Down
1 change: 1 addition & 0 deletions ...e-manager/Microsoft.ServiceBus/preview/2021-06-01-preview/examples/Topics/SBTopicGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"properties": {
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
"maxSizeInMegabytes": 10240,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"duplicateDetectionHistoryTimeWindow": "PT10M",
"enableBatchedOperations": true,
Expand Down
1 change: 1 addition & 0 deletions ...crosoft.ServiceBus/preview/2021-06-01-preview/examples/Topics/SBTopicListByNameSpace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"properties": {
"defaultMessageTimeToLive": "P10675199DT2H48M5.4775807S",
"maxSizeInMegabytes": 10240,
"maxMessageSizeInKilobytes": 10240,
"requiresDuplicateDetection": false,
"duplicateDetectionHistoryTimeWindow": "PT10M",
"enableBatchedOperations": true,
Expand Down
5 changes: 5 additions & 0 deletions ...n/servicebus/resource-manager/Microsoft.ServiceBus/preview/2021-06-01-preview/topics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,11 @@
"type": "integer",
"description": "Maximum size of the topic in megabytes, which is the size of the memory allocated for the topic. Default is 1024."
},
"maxMessageSizeInKilobytes": {
"format": "int64",
"type": "integer",
"description": "Maximum size (in KB) of the message payload that can be accepted by the topic. This property is only used in Premium today and default is 1024."
},
"requiresDuplicateDetection": {
"type": "boolean",
"description": "Value indicating if this topic requires duplicate detection."
Expand Down