Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compute.json #15504

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Update compute.json #15504

merged 1 commit into from
Aug 3, 2021

Conversation

mimckitt
Copy link
Contributor

@mimckitt mimckitt commented Aug 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @mimckitt Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 3, 2021

    Swagger Validation Report

    ️⌛BreakingChange pending [Detail]
    ️⌛LintDiff pending [Detail]
    ️⌛Avocado pending [Detail]
    ️⌛ModelValidation pending [Detail]
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛[Staging] SDK Track2 Validation pending [Detail]
    ️⌛[Staging] PrettierCheck pending [Detail]
    ️⌛[Staging] SpellCheck pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Compute label Aug 3, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 3, 2021

    Swagger Generation Artifacts

    ️⌛[Staging] ApiDocPreview pending [Detail]
    ️⚠️[Staging] SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 22.1.0
    ️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v56.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v56.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v56.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v56.0.0
    ⚠️azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v56.0.0
    -	Package was removed
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ⚠️azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v56.0.0
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ⚠️azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v56.0.0
    -	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v56.0.0
    -	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
    ⚠️azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v56.0.0
    -	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
    ⚠️azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v56.0.0
    -	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
    ️✔️azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v56.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v56.0.0
    ️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v56.0.0
    ⚠️azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v56.0.0
    -	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v56.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1bb02ec. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1bb02ec. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-08-03 20:57:18 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-08-03 20:57:18 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-08-03 20:57:18 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.34 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-08-03 20:59:16 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] Traceback (most recent call last):
      cmderr	[generate.py]   File "eng/versioning/update_versions.py", line 126, in update_versions
      cmderr	[generate.py]     raise ValueError('Invalid version type: {} for module: {}.\nFile={}\nLine={}'.format(version_type, module_name, target_file, line))
      cmderr	[generate.py] ValueError: Invalid version type: external for module: org.apache.maven:maven-core.
      cmderr	[generate.py] File=./eng/bomgenerator/pom.xml
      cmderr	[generate.py] Line=      <version>3.5.4</version> <!-- {x-version-update;org.apache.maven:maven-core;external} -->
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-08-03 21:02:57 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15504/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1bb02ec. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
      cmderr	[npmPack] created ./dist/arm-compute.js in 1.7s
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1bb02ec. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-04-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2021-03-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `Name` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Tier` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Location` in struct `RestorePointSourceMetadata`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 21 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New function `DiskRestorePointClient.GrantAccessPreparer(context.Context, string, string, string, string, GrantAccessData) (*http.Request, error)`
      info	[Changelog] - New struct `DiskRestorePointGrantAccessFuture`
      info	[Changelog] - New struct `DiskRestorePointRevokeAccessFuture`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 14 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-30/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput`
      info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `RequestRateByIntervalInput`
      info	[Changelog] - New field `GroupByUserAgent` in struct `RequestRateByIntervalInput`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logsBreaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1bb02ec. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants