-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common types.json v2 #15735
Merged
Merged
Add common types.json v2 #15735
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
77 changes: 77 additions & 0 deletions
77
specification/securityinsights/resource-manager/common/2.0/types.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2.0", | ||
| "title": "Common types" | ||
| }, | ||
| "paths": {}, | ||
| "definitions": { | ||
| "ResourceWithEtag": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../../../common-types/resource-management/v3/types.json#/definitions/Resource" | ||
| } | ||
| ], | ||
| "description": "An azure resource object with an Etag property", | ||
| "properties": { | ||
| "etag": { | ||
| "description": "Etag of the azure resource", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "parameters": { | ||
| "OperationalInsightsResourceProvider": { | ||
| "description": "The namespace of workspaces resource provider- Microsoft.OperationalInsights.", | ||
| "in": "path", | ||
| "name": "operationalInsightsResourceProvider", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ODataFilter": { | ||
| "description": "Filters the results, based on a Boolean condition. Optional.", | ||
| "in": "query", | ||
| "name": "$filter", | ||
| "required": false, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ODataOrderBy": { | ||
| "description": "Sorts the results. Optional.", | ||
| "in": "query", | ||
| "name": "$orderby", | ||
| "required": false, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ODataSkipToken": { | ||
| "description": "Skiptoken is only used if a previous operation returned a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skiptoken parameter that specifies a starting point to use for subsequent calls. Optional.", | ||
| "in": "query", | ||
| "name": "$skipToken", | ||
| "required": false, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ODataTop": { | ||
| "description": "Returns only the first n results. Optional.", | ||
| "format": "int32", | ||
| "in": "query", | ||
| "name": "$top", | ||
| "required": false, | ||
| "type": "integer", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ODataSkip": { | ||
| "description": "Used to skip n elements in the OData query (offset). Returns a nextLink to the next page of results if there are any left.", | ||
| "in": "query", | ||
| "name": "$skip", | ||
| "required": false, | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "x-ms-parameter-location": "method" | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just added this params but are they used in any of the existing swaggers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgecotillo Not yet. They will be used in my coming PRs (in a new Stable and Preview versions). Wanted to keep my PRs small and simple.
The main purpose of this PR is removing our Resource definition and referencing the common-types one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's no API update involved, I just removed WaitForArmFeedback label.