Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PricingModel in Legacy and effectivePrice in Modern #15751

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Adding PricingModel in Legacy and effectivePrice in Modern #15751

merged 1 commit into from
Aug 31, 2021

Conversation

mitagarg
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@mitagarg mitagarg requested a review from kjeur as a code owner August 23, 2021 17:53
@openapi-workflow-bot
Copy link

Hi, @mitagarg Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 23, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1015 - ParameterInHasChanged How the parameter is passed has changed -- it used to be 'query', now it is 'path'.
    New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1146:9
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1146:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1557
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'Microsoft.Management, Microsoft.Billing' doesn't match the namespace.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1557
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L424
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1477
    R4037 - MissingTypeObject The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1739
    R4037 - MissingTypeObject The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1818
    R4037 - MissingTypeObject The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1856
    R4037 - MissingTypeObject The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2110
    R4037 - MissingTypeObject The schema 'ReservationSummariesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2815
    R4037 - MissingTypeObject The schema 'ReservationSummaryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2833
    R4037 - MissingTypeObject The schema 'ReservationDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2940
    R4037 - MissingTypeObject The schema 'ReservationDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2958
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3050
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3085
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3124
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3162
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsUsageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3200
    R4037 - MissingTypeObject The schema 'ReservationRecommendationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3233
    R4037 - MissingTypeObject The schema 'LegacyReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3306
    R4037 - MissingTypeObject The schema 'SkuProperty' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3395
    R4037 - MissingTypeObject The schema 'ModernReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3430
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3522
    R4037 - MissingTypeObject The schema 'LegacyReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3670
    R4037 - MissingTypeObject The schema 'ReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3795
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3813
    R4037 - MissingTypeObject The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3847
    R4037 - MissingTypeObject The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3869
    R4037 - MissingTypeObject The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3885
    R4037 - MissingTypeObject The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3919
    R4037 - MissingTypeObject The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3990
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Schema 'ReservationRecommendationDetailsModel' has a property 'etag' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ReservationRecommendationDetailsModel"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 23, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - 8.0.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2019-10-01/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2019-01-01/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-10-01/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-08-31/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-06-30/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-05-31/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-03-31/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-01-31/consumption - v56.3.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2017-11-30/consumption - v56.3.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-12-30-preview/consumption - v56.3.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-04-24-preview/consumption - v56.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 59303d7. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs]Release - Generate from 59303d7. SDK Automation 14.0.0
      Only show 11 items here, please refer to log for details.
        </body>
      </html>
      
      at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
      at processTicksAndRejections (internal/process/task_queues.js:95:5)
      at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:286:33)
      at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
      at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
      at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
      at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
      at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18</pre></li><li><div><span><code>️✔️</code><b>consumption/mgmt/2019-10-01/consumption</b>        [<a href="https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15751/azure-sdk-for-go/consumption_mgmt/2019-10-01/consumption/logs.txt">View full logs</a>]&nbsp;        [<a href="https://github.com/Azure/azure-sdk-for-go/pull/15070">Release SDK Changes</a>]      </span></div><pre>info	[Changelog] No exported changes</pre></li><li><div><span><code>️✔️</code><b>consumption/mgmt/2019-01-01/consumption</b>        [<a href="https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15751/azure-sdk-for-go/consumption_mgmt/2019-01-01/consumption/logs.txt">View full logs</a>]&nbsp;      </span></div><pre>info	[Changelog] No exported changes</pre></li><li><div><span><code>️✔️</code><b>consumption/mgmt/2018-10-01/consumption</b>        [<a href="https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15751/azure-sdk-for-go/consumption_mgmt/2018-10-01/consumption/logs.txt">View full logs</a>]&nbsp;      </span></div>      Only show 11 items here, please refer to log for details.<br><pre>error		consumption/mgmt/2019-10-01/consumption
      

      error consumption/mgmt/2019-01-01/consumption
      error consumption/mgmt/2018-10-01/consumption
      error consumption/mgmt/2018-08-31/consumption
      error consumption/mgmt/2018-06-30/consumption
      error consumption/mgmt/2018-05-31/consumption
      error consumption/mgmt/2018-03-31/consumption
      error consumption/mgmt/2018-01-31/consumption
      error consumption/mgmt/2017-11-30/consumption
      error preview/consumption/mgmt/2017-12-30-preview/consumption
      error preview/consumption/mgmt/2017-04-24-preview/consumption

    • ️✔️consumption/mgmt/2018-08-31/consumption
    • ️✔️consumption/mgmt/2018-06-30/consumption
    • ️✔️consumption/mgmt/2018-05-31/consumption
    • ️✔️consumption/mgmt/2018-03-31/consumption
    • ️✔️consumption/mgmt/2018-01-31/consumption
    • ️✔️consumption/mgmt/2017-11-30/consumption
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    • ⚠️Warning [Logs]Release - Generate from 59303d7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter adjustments_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter credit_expired_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter reseller
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_id
      info	[Changelog]   - Model EventSummary has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter charges_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_display_name
      info	[Changelog]   - Model EventSummary has a new parameter credit_currency
      info	[Changelog]   - Model EventSummary has a new parameter billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter lot_id
      info	[Changelog]   - Model EventSummary has a new parameter canceled_credit
      info	[Changelog]   - Model EventSummary has a new parameter new_credit_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter lot_source
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model UsageDetail has a new parameter etag
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
      info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model CreditSummary has a new parameter etag
      info	[Changelog]   - Model CreditSummary has a new parameter billing_currency
      info	[Changelog]   - Model CreditSummary has a new parameter credit_currency
      info	[Changelog]   - Model CreditSummary has a new parameter reseller
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
      info	[Changelog]   - Model CreditBalanceSummary has a new parameter estimated_balance_in_billing_currency
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter original_amount_in_billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter reseller
      info	[Changelog]   - Model LotSummary has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter credit_currency
      info	[Changelog]   - Model LotSummary has a new parameter purchase_date
      info	[Changelog]   - Model LotSummary has a new parameter billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter status
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_account
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_account
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_profile
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation LotsOperations.list
      info	[Changelog]   - Removed operation EventsOperations.list
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 59303d7. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-08-31 02:16:46 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-consumption;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-08-31 02:16:46 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-08-31 02:16:46 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Skip] pom already has module sdk/consumption
      cmderr	[generate.py] 2021-08-31 02:17:23 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG Got artifact_id: azure-resourcemanager-consumption
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3-javadoc.jar
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-08-31 02:19:05 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15751/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.3.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 59303d7. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
      cmderr	[npmPack] created ./dist/arm-consumption.js in 821ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 59303d7. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2532) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-01-31/Microsoft.Consumption.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2532) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2532) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️consumption [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @mitagarg mitagarg requested review from Lira-tron and removed request for kjeur August 23, 2021 17:54
    @openapi-workflow-bot
    Copy link

    Hi @mitagarg, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    Copy link
    Contributor

    @Lira-tron Lira-tron left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good to me

    @mitagarg
    Copy link
    Contributor Author

    @jianyexi - hello, this PR is stuck at breaking chnage. This PR is just adding two additional properties to an existing API.

    I have submitted similar PR in the past and had gotten approve. Will appreciate your help here.

    This PR cannot cause anything to break.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FalsePositive-BreakingChange
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants