Azure Site Recovery: New version/2021 08 01 #15841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ayfathim Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'DELETE' operation 'ReplicationFabrics_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L558 |
|
| 'DELETE' operation 'ReplicationProtectedItems_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L2819 |
|
| 'DELETE' operation 'ReplicationProtectionContainerMappings_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L4453 |
|
| 'DELETE' operation 'ReplicationRecoveryServicesProviders_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L4898 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L9532 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L9572 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L9617 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L9725 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L9776 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10133 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10186 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10217 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10237 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10260 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10288 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10325 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10451 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10497 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10682 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10724 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L10790 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L11073 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L11100 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L11286 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L16854 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L17147 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L17382 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L17424 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L17624 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-08-01/service.json#L17700 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2021-08-01/service.json compared with base:stable/2021-07-01/service.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservicessiterecovery/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservicessiterecovery/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservicessiterecovery/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Aug 29, 2021
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @ayfathim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
This was referenced Aug 29, 2021
ayfathim
changed the title
|
Is there any new API or change compared to previous version? |
|
@weidongxu-microsoft :Please check the following commit to review the changes compared to previous version. |
weidongxu-microsoft
approved these changes
Aug 30, 2021
ayfathim
changed the title
|
@weidongxu-microsoft : We have added one input class in swagger in the third commit. FYI |
ayfathim
commented
Aug 30, 2021
...vicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-08-01/service.json
Outdated
Show resolved
Hide resolved
|
Already approved. |
nit: As these are Azure APIs, adding prefix 'azure' is unnecessary. Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-08-01/service.json:17907 in d5a6170. [](commit_id = d5a6170, deletion_comment = False) |
As automation account type is repeated multiple times, you can create a common definition for it and refer in other places. Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-08-01/service.json:8056 in d5a6170. [](commit_id = d5a6170, deletion_comment = False) |
|
@ayfathim - PR changes LGTM. Left some minor comments. |
RamyasreeChakka
added
the
ARMSignedOff
RamyasreeChakka
removed
the
WaitForARMFeedback
|
@RamyasreeChakka : Wanted to check with you about how to create common definition for enum type - AutomationAccountAuthenticationType. Can you share some example for this. |
|
Hi, @ayfathim. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
ARM Manifest deployment for the new version will complete this week. post that we will complete this PR |
ayfathim
changed the title
|
@weidongxu-microsoft : Our service deployment has completed. Please merge this PR |
This was referenced Sep 22, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Sep 22, 2021
…sion/2021 08 01 (#1928) Create to sync Azure/azure-rest-api-specs#15841 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/recoveryservicessiterecovery?expand=1)
Hardell
pushed a commit
to Hardell/azure-rest-api-specs
that referenced
this pull request
Sep 27, 2021
* New Version 2021-08-01 * New Version 2021-08-01 * Adding new storage account input * Adding default value for automationAccount authentication type * Fixing indenation * removing new storage account changes Co-authored-by: Nilesh Gupta <nilgupta@microsoft.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* New Version 2021-08-01 * New Version 2021-08-01 * Adding new storage account input * Adding default value for automationAccount authentication type * Fixing indenation * removing new storage account changes Co-authored-by: Nilesh Gupta <nilgupta@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.