Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 #15861

Conversation

betrigg
Copy link
Contributor

@betrigg betrigg commented Aug 31, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @betrigg Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 31, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️❌LintDiff: 2 Errors, 1 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateEndpointConnections.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateEndpointConnections.json#L82
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'privateLinkPolicy', must have a list by immediate parent operation.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateEndpointConnections.json#L246


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkForAzureAD.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkForAzureAD.json#L226
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkForAzureAD.json#L265
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkResources.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkResources.json#L76
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L223
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L262
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L226
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L265
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkResources.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.aadiam' doesn't match the namespace.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkResources.json#L76
    R4035 - PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourceListResult' schema does not conform to the common type definition.
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkResources.json#L117
    R4035 - PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourceListResult' schema does not conform to the common type definition.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkResources.json#L117
    R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.aadiam/privateLinkForAzureAd/{policyName}/privateEndpointConnections/{privateEndpointConnectionName} is missing.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkResources.json#L36
    R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.aadiam/privateLinkForAzureAd/{policyName}/privateEndpointConnections is missing.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkResources.json#L36
    R4037 - MissingTypeObject The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/common/1.0/types.json#L18
    R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/common/1.0/types.json#L9
    R4037 - MissingTypeObject The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/common/1.0/types.json#L18
    R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/common/1.0/types.json#L9
    R4037 - MissingTypeObject The schema 'AzureADMetricsPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L339
    R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L370
    R4037 - MissingTypeObject The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L379
    R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L410
    R4037 - MissingTypeObject The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L419
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L329
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allTenants
    Location: Microsoft.Aadiam/stable/2020-03-01/privateLinkForAzureAD.json#L338
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allTenants
    Location: Microsoft.Aadiam/preview/2020-03-01-preview/privateLinkForAzureAD.json#L338
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'azureADMetricsConfig', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: Microsoft.Aadiam/preview/2020-07-01-preview/azureADMetrics.json#L325
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"Schema 'privateLinkPolicy' has a property 'name' that is already declared the parent schema 'AzureResourceBase' but 'readonly' has been changed -- this is not permitted. The property has been removed from privateLinkPolicy"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2017-04",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2017-04",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"Duplicate Schema named ErrorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:38" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"Duplicate Schema named ErrorDefinition -- properties.details.$ref: undefined => "#/components/schemas/schemas:41" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"Schema 'privateLinkPolicy' has a property 'name' that is already declared the parent schema 'AzureResourceBase' but 'readonly' has been changed -- this is not permitted. The property has been removed from privateLinkPolicy"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2017-04",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-preview-2020-07",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-2017-04-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"azureactivedirectory/resource-manager/readme.md",
    "tag":"package-2017-04-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 31, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - aad/mgmt/2017-04-01/aad - v57.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azureactivedirectory - first release
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7f3c455. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7f3c455. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-08 02:52:47 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-azureactivedirectory"
      cmderr	[generate.py] 2021-09-08 02:52:47 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-08 02:52:47 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/azureactivedirectory/azure-resourcemanager-azureactivedirectory --java.namespace=com.azure.resourcemanager.azureactivedirectory   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [POM][Skip] pom already has module azure-resourcemanager-azureactivedirectory
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-08 02:53:15 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-azureactivedirectory [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG Got artifact_id: azure-resourcemanager-azureactivedirectory
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG Got artifact: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG Got artifact: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG Match jar package: azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-08 02:54:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15861/azure-sdk-for-java/azure-resourcemanager-azureactivedirectory/azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar\" -o azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-azureactivedirectory -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-azureactivedirectory-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7f3c455. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️aad/mgmt/2017-04-01/aad [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7f3c455. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/azureactivedirectory/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7f3c455. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️azureactivedirectory [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @betrigg, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @betrigg betrigg marked this pull request as ready for review August 31, 2021 23:20
    @openapi-workflow-bot
    Copy link

    Hi, @betrigg your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 2, 2021
    @betrigg betrigg removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 2, 2021
    @qwordy qwordy merged commit 7f3c455 into Azure:main Sep 8, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 8, 2021
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Sep 10, 2021
    …into add_endpoint
    
    * 'main' of https://github.com/Azure/azure-rest-api-specs: (5079 commits)
      Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967)
      Updated SKU property to be read only (Azure#15965)
      Add Microsoft.Communication.UserDisconnected Event (Azure#15870)
      Add collection APIs (Azure#15221)
      [Cognitive Services - Personalizer] v1.1-preview.2 (Azure#15699)
      Adding default error response & updating basePath (Azure#15784)
      Update readme and readme.python (Azure#15973)
      add synapse batch tag package-composite-v1 (Azure#15974)
      Microsoft.BareMetalInfrastructure: add stable API version 2021-08-09 (Azure#15680)
      change readme.go.md template to track 2 (Azure#15972)
      [CosmosDB] Adding apiVersion 2021-07-01-preview (Azure#14817)
      Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954)
      DiskRP swagger for 2021-04-01 (Azure#15665)
      Use IncidentSeverity in IncidentInfo (Azure#15762)
      Add stable API version "2021-09-01" (Azure#15897)
      add-purview-typescript-file (Azure#15948)
      Swagger Completeness for Microsoft.Authorization (Azure#15253)
      [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 (Azure#15861)
      Add swagger for missing CheckPolicyRestrictions API version (Azure#15888)
      Add Red Hat OpenShift 2021-09-01-preview (Azure#15616)
      ...
    @betrigg betrigg deleted the dev-azureactivedirectory-Microsoft.Aadiam-2020-03-01-3 branch September 30, 2021 01:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants