extract SkuTier as seperate definition for common-types/v3.json

[zhenglaizhang]

This is per request from service team (#15662 (comment)) and I did a check on python track2 it's not a breaking change in PR #15876.

And need SDK owners review to check if it's a SDK breaking change

[openapi-workflow-bot]

Hi, @zhenglaizhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

[openapi-workflow-bot]

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

• Compared Swaggers (Based on Oad v0.9.0)
  • current:resource-management/v3/types.json compared with base:resource-management/v3/types.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger pipeline restarted successfully, please wait for status update in this comment.

[forteddyt]

This will address the issue in #15662, so thank you.

I just wanted to also point out that this same type of change could be applied to the other enum property types, as well. like "type", "origin", "actionType", "createdByType", "lastModifiedByType", "status", and "reason".

[weidongxu-microsoft]

@zhenglaizhang Do you need review from ARM?

[zhenglaizhang]

@msyyc @qiaozha @fengzhou-msft @ArcturusZhang could you help take a look from SDK perspective?

[weidongxu-microsoft]

One question not related to this change.

Why use "allOf"?

azure-rest-api-specs/specification/common-types/resource-management/v3/types.json

Lines 169 to 189 in 4749798

	"identity": {
	"allOf": [
	{
	"$ref": "#/definitions/Identity"
	}
	]
	},
	"sku": {
	"allOf": [
	{
	"$ref": "#/definitions/Sku"
	}
	]
	},
	"plan": {
	"allOf": [
	{
	"$ref": "#/definitions/Plan"
	}
	]
	}

[zhenglaizhang]

@zhenglaizhang Do you need review from ARM?

no need to do ARM review,

[zhenglaizhang]

One question not related to this change.

Why use "allOf"?

azure-rest-api-specs/specification/common-types/resource-management/v3/types.json

Lines 169 to 189 in 4749798

	"identity": {
	"allOf": [
	{
	"$ref": "#/definitions/Identity"
	}
	]
	},
	"sku": {
	"allOf": [
	{
	"$ref": "#/definitions/Sku"
	}
	]
	},
	"plan": {
	"allOf": [
	{
	"$ref": "#/definitions/Plan"
	}
	]
	}

good catch, ref should be better here.

[zhenglaizhang]

.net/python sdk owners are also ok with this change.

[zhenglaizhang]

@forteddyt I merged the PR, so you can try to reference it in v3 common types.json