Creating preview version 2021-10-01-preview with introduction to BaseResourceProperties and VmwareVMProperties #15936

SanjayHukumRana · 2021-09-07T13:17:30Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Introducing BaseResourceProperties in data source and data source set

Introducing VmwareVMProperties

openapi-workflow-bot · 2021-09-07T13:17:32Z

Hi, @SanjayHukumRana Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-09-07T13:17:32Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-09-07T13:17:33Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-09-07T13:17:34Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️⌛[Staging] SDK Breaking Change Tracking pending [Detail]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0f9a4a2. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/dataprotection/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataProtection [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataProtection.Backup.2.0.0.1.nupkg
- Microsoft.Azure.Management.DataProtection.Backup.2.0.0.1.symbols.nupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0f9a4a2. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.7.0 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-dataprotection [View full logs] [Release SDK Changes]
- azure_mgmt_dataprotection-1.0.0b1-py2.py3-none-any.whl
- azure-mgmt-dataprotection-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0f9a4a2. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-10-19 03:06:46 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-dataprotection"
cmderr	[generate.py] 2021-10-19 03:06:46 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-10-19 03:06:46 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.38 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/dataprotection/azure-resourcemanager-dataprotection --java.namespace=com.azure.resourcemanager.dataprotection   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/dataprotection/resource-manager/readme.md
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [POM][Skip] pom already has module azure-resourcemanager-dataprotection
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-10-19 03:07:26 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-dataprotection [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-10-19 03:09:06 DEBUG Got artifact_id: azure-resourcemanager-dataprotection
cmderr	[Inst] 2021-10-19 03:09:06 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-10-19 03:09:06 DEBUG Got artifact: azure-resourcemanager-dataprotection-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-10-19 03:09:06 DEBUG Got artifact: azure-resourcemanager-dataprotection-1.0.0-beta.1.jar
cmderr	[Inst] 2021-10-19 03:09:06 DEBUG Match jar package: azure-resourcemanager-dataprotection-1.0.0-beta.1.jar
cmderr	[Inst] 2021-10-19 03:09:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15936/azure-sdk-for-java/azure-resourcemanager-dataprotection/azure-resourcemanager-dataprotection-1.0.0-beta.1.jar\" -o azure-resourcemanager-dataprotection-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-dataprotection -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-dataprotection-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0f9a4a2. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️dataprotection/mgmt/2021-07-01/dataprotection [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️dataprotection/mgmt/2021-01-01/dataprotection [View full logs] Breaking Change Detected

Only show 30 items here, please refer to log for details.

info	[Changelog] - New function `JobsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `BackupInstancesClient.ValidateForRestore(context.Context, string, string, string, ValidateRestoreRequestObject) (BackupInstancesValidateForRestoreFuture, error)`
info	[Changelog] - New function `OperationStatusClient.GetResponder(*http.Response) (OperationResource, error)`
info	[Changelog] - New function `BackupVaultsClient.UpdateResponder(*http.Response) (BackupVaultResource, error)`
info	[Changelog] - New function `NewBackupVaultOperationResultsClientWithBaseURI(string, string) BackupVaultOperationResultsClient`
info	[Changelog] - New function `OperationStatusClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `BackupVaultsClient.GetInSubscriptionSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RecoveryPointsClient.Get(context.Context, string, string, string, string) (AzureBackupRecoveryPointResource, error)`
info	[Changelog] - New function `BackupVaultsClient.UpdatePreparer(context.Context, string, string, PatchResourceRequestInput) (*http.Request, error)`
info	[Changelog] - New function `Client.CheckFeatureSupportResponder(*http.Response) (FeatureValidationResponseBaseModel, error)`
info	[Changelog] - New function `NewRestorableTimeRangesClientWithBaseURI(string, string) RestorableTimeRangesClient`
info	[Changelog] - New function `BackupVaultOperationResultsClient.GetResponder(*http.Response) (BackupVaultResource, error)`
info	[Changelog] - New function `NewClientWithBaseURI(string, string) Client`
info	[Changelog] - New function `BackupVaultsClient.UpdateSender(*http.Request) (BackupVaultsUpdateFuture, error)`
info	[Changelog] - New function `BackupVaultsClient.GetInSubscriptionPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `BackupVaultsClient.GetInResourceGroupResponder(*http.Response) (BackupVaultResourceList, error)`
info	[Changelog] - New function `RecoveryPointsClient.ListComplete(context.Context, string, string, string, string, string) (AzureBackupRecoveryPointResourceListIterator, error)`
info	[Changelog] - New function `OperationStatusClient.Get(context.Context, string, string) (OperationResource, error)`
info	[Changelog] - New function `RecoveryPointsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `BackupVaultOperationResultsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RestorableTimeRangesClient.Find(context.Context, string, string, string, AzureBackupFindRestorableTimeRangesRequest) (AzureBackupFindRestorableTimeRangesResponseResource, error)`
info	[Changelog] - New struct `BackupInstancesValidateForRestoreFuture`
info	[Changelog] - New struct `BackupVaultOperationResultsClient`
info	[Changelog] - New struct `BackupVaultsUpdateFuture`
info	[Changelog] - New struct `Client`
info	[Changelog] - New struct `OperationStatusClient`
info	[Changelog] - New struct `RestorableTimeRangesClient`
info	[Changelog]
info	[Changelog] Total 65 breaking change(s), 69 additive change(s).
info	[Changelog]

️✔️preview/dataprotection/mgmt/2021-06-01-preview/dataprotection [View full logs]
```
info	[Changelog] This is a new package
```
️✔️preview/dataprotection/mgmt/2021-02-01-preview/dataprotection [View full logs]
```
info	[Changelog] This is a new package
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0f9a4a2. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/dataprotection/resource-manager/readme.md

️✔️@azure/arm-dataprotectionplatform [View full logs] [Release SDK Changes]

azure-arm-dataprotectionplatform-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/dataProtectionClient.js → ./dist/arm-dataprotectionplatform.js...
cmderr	[npmPack] created ./dist/arm-dataprotectionplatform.js in 612ms

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-09-07T13:19:29Z

Hi @SanjayHukumRana, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

Updating the version

Fixing lintdiff error

openapi-workflow-bot · 2021-09-07T14:22:18Z

Hi, @SanjayHukumRana your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

fixing readme.md

Adding input file in readme.md

majastrz

Signed off from ARM side.

...otection/preview/2021-10-01-preview/examples/BackupInstanceOperations/PutBackupInstance.json

...ction/preview/2021-10-01-preview/examples/BackupInstanceOperations/DeleteBackupInstance.json

...otection/preview/2021-10-01-preview/examples/BackupInstanceOperations/GetBackupInstance.json

specification/dataprotection/resource-manager/readme.md

Updating example with version and resource properties

specification/dataprotection/resource-manager/readme.md

Reverting input file change

BigCat20196 · 2021-10-19T03:01:08Z

/azp run

…ResourceProperties and VmwareVMProperties (Azure#15936) * BaseResourceProperties class Introducing BaseResourceProperties in data source and data source set * Introducing VmwareVMProperties Introducing VmwareVMProperties * Update dataprotection.json Updating the version * Update dataprotection.json Fixing lintdiff error * Update readme.md fixing readme.md * Update readme.md Adding input file in readme.md * Examples update Updating example with version and resource properties * Update readme.md Reverting input file change

SanjayHukumRana added 2 commits September 7, 2021 18:29

BaseResourceProperties class

c6b65f9

Introducing BaseResourceProperties in data source and data source set

Introducing VmwareVMProperties

0b654bd

Introducing VmwareVMProperties

openapi-assignment-bot bot assigned lirenhe Sep 7, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 7, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 7, 2021

SanjayHukumRana added 2 commits September 7, 2021 19:06

Update dataprotection.json

eec3fa0

Updating the version

Update dataprotection.json

44c609f

Fixing lintdiff error

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Sep 7, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 7, 2021

SanjayHukumRana added 2 commits September 7, 2021 19:58

Update readme.md

f571af8

fixing readme.md

Update readme.md

d404500

Adding input file in readme.md

majastrz approved these changes Sep 10, 2021

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2021

chandrasekarendran reviewed Sep 10, 2021

View reviewed changes

...otection/preview/2021-10-01-preview/examples/BackupInstanceOperations/PutBackupInstance.json Show resolved Hide resolved

chandrasekarendran approved these changes Sep 13, 2021

View reviewed changes

lirenhe reviewed Sep 14, 2021

View reviewed changes

...ction/preview/2021-10-01-preview/examples/BackupInstanceOperations/DeleteBackupInstance.json Outdated Show resolved Hide resolved

lirenhe reviewed Sep 14, 2021

View reviewed changes

...otection/preview/2021-10-01-preview/examples/BackupInstanceOperations/GetBackupInstance.json Outdated Show resolved Hide resolved

lirenhe reviewed Sep 14, 2021

View reviewed changes

specification/dataprotection/resource-manager/readme.md Outdated Show resolved Hide resolved

Examples update

5fc19d2

Updating example with version and resource properties

lirenhe reviewed Sep 14, 2021

View reviewed changes

specification/dataprotection/resource-manager/readme.md Show resolved Hide resolved

Update readme.md

5e646cb

Reverting input file change

lirenhe approved these changes Sep 16, 2021

View reviewed changes

lirenhe merged commit 0f9a4a2 into Azure:main Sep 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating preview version 2021-10-01-preview with introduction to BaseResourceProperties and VmwareVMProperties #15936

Creating preview version 2021-10-01-preview with introduction to BaseResourceProperties and VmwareVMProperties #15936

SanjayHukumRana commented Sep 7, 2021 •

edited

Loading

openapi-workflow-bot bot commented Sep 7, 2021

openapi-workflow-bot bot commented Sep 7, 2021

openapi-pipeline-app bot commented Sep 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2021 •

edited

Loading

openapi-workflow-bot bot commented Sep 7, 2021

openapi-workflow-bot bot commented Sep 7, 2021

majastrz left a comment

BigCat20196 commented Oct 19, 2021

Creating preview version 2021-10-01-preview with introduction to BaseResourceProperties and VmwareVMProperties #15936

Creating preview version 2021-10-01-preview with introduction to BaseResourceProperties and VmwareVMProperties #15936

Conversation

SanjayHukumRana commented Sep 7, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 7, 2021

openapi-workflow-bot bot commented Sep 7, 2021

openapi-pipeline-app bot commented Sep 7, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 7, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Sep 7, 2021

openapi-workflow-bot bot commented Sep 7, 2021

majastrz left a comment

Choose a reason for hiding this comment

BigCat20196 commented Oct 19, 2021

SanjayHukumRana commented Sep 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2021 •

edited

Loading