Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location not required for VM extensions in VirtualMachines_List #15940

Closed
wants to merge 3 commits into from

Conversation

chasevanb
Copy link
Contributor

I generated the C# SDK with my changes using dotnet build /t:GenerateCode, since it is changing an existing property from required to not required. The code diff yielded no code changes.

This property update addresses: #14459

Generation warning for not required property
autorestDiffWarn

Git diff output (only comment changes, unrelated to my change taken from main head):

diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/OSProfile.cs b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/OSProfile.cs
index a43219d5c3..a6805e3f48 100644
--- a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/OSProfile.cs
+++ b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/OSProfile.cs
@@ -26,7 +26,7 @@ public OSProfile()
         /// <param name="customData"> Specifies a base-64 encoded string of custom data. The base-64 encoded string is decoded to a binary array that is saved as a file on the Virtual Machine. The maximum length of the binary array is 65535 bytes. &lt;br&gt;&lt;br&gt; **Note: Do not pass any secrets or passwords in customData property** &lt;br&gt;&lt;br&gt; This property cannot be updated after the VM is created. &lt;br&gt;&lt;br&gt; customData is passed to the VM to be saved as a file, for more information see [Custom Data on Azure VMs](https://azure.microsoft.com/blog/custom-data-and-cloud-init-on-windows-azure/) &lt;br&gt;&lt;br&gt; For using cloud-init for your Linux VM, see [Using cloud-init to customize a Linux VM during creation](https://docs.microsoft.com/azure/virtual-machines/linux/using-cloud-init). </param>
         /// <param name="windowsConfiguration"> Specifies Windows operating system settings on the virtual machine. </param>
         /// <param name="linuxConfiguration"> Specifies the Linux operating system settings on the virtual machine. &lt;br&gt;&lt;br&gt;For a list of supported Linux distributions, see [Linux on Azure-Endorsed Distributions](https://docs.microsoft.com/azure/virtual-machines/linux/endorsed-distros). </param>
-        /// <param name="secrets"> Specifies set of certificates that should be installed onto the virtual machine. </param>
+        /// <param name="secrets"> Specifies set of certificates that should be installed onto the virtual machine. To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </param>
         /// <param name="allowExtensionOperations"> Specifies whether extension operations should be allowed on the virtual machine. &lt;br&gt;&lt;br&gt;This may only be set to False when no extensions are present on the virtual machine. </param>
         /// <param name="requireGuestProvisionSignal"> Specifies whether the guest provision signal is required to infer provision success of the virtual machine.  **Note: This property is for private testing only, and all customers must not set the property to false.**. </param>
         internal OSProfile(string computerName, string adminUsername, string adminPassword, string customData, WindowsConfiguration windowsConfiguration, LinuxConfiguration linuxConfiguration, IList<VaultSecretGroup> secrets, bool? allowExtensionOperations, bool? requireGuestProvisionSignal)
@@ -54,7 +54,7 @@ internal OSProfile(string computerName, string adminUsername, string adminPasswo
         public WindowsConfiguration WindowsConfiguration { get; set; }
         /// <summary> Specifies the Linux operating system settings on the virtual machine. &lt;br&gt;&lt;br&gt;For a list of supported Linux distributions, see [Linux on Azure-Endorsed Distributions](https://docs.microsoft.com/azure/virtual-machines/linux/endorsed-distros). </summary>
         public LinuxConfiguration LinuxConfiguration { get; set; }
-        /// <summary> Specifies set of certificates that should be installed onto the virtual machine. </summary>
+        /// <summary> Specifies set of certificates that should be installed onto the virtual machine. To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </summary>
         public IList<VaultSecretGroup> Secrets { get; }
         /// <summary> Specifies whether extension operations should be allowed on the virtual machine. &lt;br&gt;&lt;br&gt;This may only be set to False when no extensions are present on the virtual machine. </summary>
         public bool? AllowExtensionOperations { get; set; }
diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VaultCertificate.cs b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VaultCertificate.cs
index 426a214dad..aa0fca960f 100644
--- a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VaultCertificate.cs
+++ b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VaultCertificate.cs
@@ -16,7 +16,7 @@ public VaultCertificate()
         }
 
         /// <summary> Initializes a new instance of VaultCertificate. </summary>
-        /// <param name="certificateUrl"> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt;  &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt;  &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt;  &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;}. </param>
+        /// <param name="certificateUrl"> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt; &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt; &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt; &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;} &lt;br&gt; To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </param>
         /// <param name="certificateStore"> For Windows VMs, specifies the certificate store on the Virtual Machine to which the certificate should be added. The specified certificate store is implicitly in the LocalMachine account. &lt;br&gt;&lt;br&gt;For Linux VMs, the certificate file is placed under the /var/lib/waagent directory, with the file name &amp;lt;UppercaseThumbprint&amp;gt;.crt for the X509 certificate file and &amp;lt;UppercaseThumbprint&amp;gt;.prv for private key. Both of these files are .pem formatted. </param>
         internal VaultCertificate(string certificateUrl, string certificateStore)
         {
@@ -24,7 +24,7 @@ internal VaultCertificate(string certificateUrl, string certificateStore)
             CertificateStore = certificateStore;
         }
 
-        /// <summary> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt;  &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt;  &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt;  &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;}. </summary>
+        /// <summary> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt; &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt; &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt; &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;} &lt;br&gt; To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </summary>
         public string CertificateUrl { get; set; }
         /// <summary> For Windows VMs, specifies the certificate store on the Virtual Machine to which the certificate should be added. The specified certificate store is implicitly in the LocalMachine account. &lt;br&gt;&lt;br&gt;For Linux VMs, the certificate file is placed under the /var/lib/waagent directory, with the file name &amp;lt;UppercaseThumbprint&amp;gt;.crt for the X509 certificate file and &amp;lt;UppercaseThumbprint&amp;gt;.prv for private key. Both of these files are .pem formatted. </summary>
         public string CertificateStore { get; set; }
diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VirtualMachineScaleSetOSProfile.cs b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VirtualMachineScaleSetOSProfile.cs
index 5327647987..8928cf139a 100644
--- a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VirtualMachineScaleSetOSProfile.cs
+++ b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/VirtualMachineScaleSetOSProfile.cs
@@ -26,7 +26,7 @@ public VirtualMachineScaleSetOSProfile()
         /// <param name="customData"> Specifies a base-64 encoded string of custom data. The base-64 encoded string is decoded to a binary array that is saved as a file on the Virtual Machine. The maximum length of the binary array is 65535 bytes. &lt;br&gt;&lt;br&gt; For using cloud-init for your VM, see [Using cloud-init to customize a Linux VM during creation](https://docs.microsoft.com/azure/virtual-machines/linux/using-cloud-init). </param>
         /// <param name="windowsConfiguration"> Specifies Windows operating system settings on the virtual machine. </param>
         /// <param name="linuxConfiguration"> Specifies the Linux operating system settings on the virtual machine. &lt;br&gt;&lt;br&gt;For a list of supported Linux distributions, see [Linux on Azure-Endorsed Distributions](https://docs.microsoft.com/azure/virtual-machines/linux/endorsed-distros). </param>
-        /// <param name="secrets"> Specifies set of certificates that should be installed onto the virtual machines in the scale set. </param>
+        /// <param name="secrets"> Specifies set of certificates that should be installed onto the virtual machines in the scale set. To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </param>
         internal VirtualMachineScaleSetOSProfile(string computerNamePrefix, string adminUsername, string adminPassword, string customData, WindowsConfiguration windowsConfiguration, LinuxConfiguration linuxConfiguration, IList<VaultSecretGroup> secrets)
         {
             ComputerNamePrefix = computerNamePrefix;
@@ -50,7 +50,7 @@ internal VirtualMachineScaleSetOSProfile(string computerNamePrefix, string admin
         public WindowsConfiguration WindowsConfiguration { get; set; }
         /// <summary> Specifies the Linux operating system settings on the virtual machine. &lt;br&gt;&lt;br&gt;For a list of supported Linux distributions, see [Linux on Azure-Endorsed Distributions](https://docs.microsoft.com/azure/virtual-machines/linux/endorsed-distros). </summary>
         public LinuxConfiguration LinuxConfiguration { get; set; }
-        /// <summary> Specifies set of certificates that should be installed onto the virtual machines in the scale set. </summary>
+        /// <summary> Specifies set of certificates that should be installed onto the virtual machines in the scale set. To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </summary>
         public IList<VaultSecretGroup> Secrets { get; }
     }
 }
diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/WinRMListener.cs b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/WinRMListener.cs
index e1037ec16e..2f2843cb14 100644
--- a/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/WinRMListener.cs
+++ b/sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/WinRMListener.cs
@@ -17,7 +17,7 @@ public WinRMListener()
 
         /// <summary> Initializes a new instance of WinRMListener. </summary>
         /// <param name="protocol"> Specifies the protocol of WinRM listener. &lt;br&gt;&lt;br&gt; Possible values are: &lt;br&gt;**http** &lt;br&gt;&lt;br&gt; **https**. </param>
-        /// <param name="certificateUrl"> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt;  &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt;  &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt;  &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;}. </param>
+        /// <param name="certificateUrl"> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt; &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt; &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt; &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;} &lt;br&gt; To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </param>
         internal WinRMListener(ProtocolTypes? protocol, string certificateUrl)
         {
             Protocol = protocol;
@@ -26,7 +26,7 @@ internal WinRMListener(ProtocolTypes? protocol, string certificateUrl)
 
         /// <summary> Specifies the protocol of WinRM listener. &lt;br&gt;&lt;br&gt; Possible values are: &lt;br&gt;**http** &lt;br&gt;&lt;br&gt; **https**. </summary>
         public ProtocolTypes? Protocol { get; set; }
-        /// <summary> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt;  &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt;  &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt;  &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;}. </summary>
+        /// <summary> This is the URL of a certificate that has been uploaded to Key Vault as a secret. For adding a secret to the Key Vault, see [Add a key or secret to the key vault](https://docs.microsoft.com/azure/key-vault/key-vault-get-started/#add). In this case, your certificate needs to be It is the Base64 encoding of the following JSON Object which is encoded in UTF-8: &lt;br&gt;&lt;br&gt; {&lt;br&gt; &quot;data&quot;:&quot;&lt;Base64-encoded-certificate&gt;&quot;,&lt;br&gt; &quot;dataType&quot;:&quot;pfx&quot;,&lt;br&gt; &quot;password&quot;:&quot;&lt;pfx-file-password&gt;&quot;&lt;br&gt;} &lt;br&gt; To install certificates on a virtual machine it is recommended to use the [Azure Key Vault virtual machine extension for Linux](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-linux) or the [Azure Key Vault virtual machine extension for Windows](https://docs.microsoft.com/azure/virtual-machines/extensions/key-vault-windows). </summary>
         public string CertificateUrl { get; set; }
     }
 }
diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/autorest.md b/sdk/compute/Azure.ResourceManager.Compute/src/autorest.md
index fe7838cb70..b65b3e683f 100644
--- a/sdk/compute/Azure.ResourceManager.Compute/src/autorest.md
+++ b/sdk/compute/Azure.ResourceManager.Compute/src/autorest.md
@@ -10,7 +10,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
 azure-arm: true
 library-name: Compute
 namespace: Azure.ResourceManager.Compute
-require: https://github.com/Azure/azure-rest-api-specs/blob/654c237832960c2753b7a4a4459a434af6d57a4a/specification/compute/resource-manager/readme.md
+require: C:\azure-rest-api-specs\specification\compute\resource-manager\readme.md
 tag: package-2021-03-01
 clear-output-folder: true
 skip-csproj: true

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? n/a
  3. When do you expect to publish the swagger? August
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @chasevanb Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 7, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️🔄LintDiff inProgress [Detail]
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 3 Errors, 0 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-07-01-only",
    "details":"Error: Plugin prechecker reported failure."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-04-01-only",
    "details":"Error: Plugin prechecker reported failure."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-03-01-only",
    "details":"Error: Plugin prechecker reported failure."


    The following errors/warnings exist before current PR submission:

    Rule Message
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-07-01",
    "details":"Error: Plugin prechecker reported failure."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"Error: Plugin prechecker reported failure."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-04-01",
    "details":"Error: Plugin prechecker reported failure."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-03-01",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 7, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 23.0.0
    ️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v57.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v57.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v57.2.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2021-07-01/compute - v57.2.0
    azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v57.2.0
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v57.2.0
    +	Field `ConsistencyMode` of struct `RestorePoint` has been removed
    +	Field `ExcludeDisks` of struct `RestorePoint` has been removed
    +	Field `ProvisioningDetails` of struct `RestorePoint` has been removed
    +	Field `ProvisioningState` of struct `RestorePoint` has been removed
    +	Field `PublicIPAddressSkuName` of struct `PublicIPAddressSku` has been removed
    +	Field `PublicIPAddressSkuTier` of struct `PublicIPAddressSku` has been removed
    +	Field `SourceMetadata` of struct `RestorePoint` has been removed
    +	Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
    ️✔️azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v57.2.0
    azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v57.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v57.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v57.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v57.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v57.2.0
    +	Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed
    +	Field `FileName` of struct `UserArtifactSource` has been removed
    ️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v57.2.0
    ️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v57.2.0
    ️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v57.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v57.2.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v57.2.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-09 19:02:42 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-09-09 19:02:42 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-09 19:02:42 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-09 19:04:30 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-09 19:08:29 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15940/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
      cmderr	[npmPack] created ./dist/arm-compute.js in 1.3s
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-07-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `PublicNetworkAccess` in struct `DiskProperties`
      info	[Changelog] - New field `SupportedCapabilities` in struct `DiskProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2021-04-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `SupportedCapabilities` in struct `SnapshotProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `SnapshotProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2021-03-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `Name` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Tier` in struct `PublicIPAddressSku`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 21 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `DiskRestorePointGrantAccessFuture`
      info	[Changelog] - New struct `DiskRestorePointRevokeAccessFuture`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 14 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-30/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `LogAnalyticsInputBase`
      info	[Changelog] - New field `GroupByUserAgent` in struct `LogAnalyticsInputBase`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logsBreaking Change Detected
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from c53c80e867d5942d26c275f289460e7172dc3b15. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do we also need to correct other api-versions?

    @chasevanb
    Copy link
    Contributor Author

    @ArcturusZhang
    Updated the 2 latest API versions (in addition to the 3rd latest, 2021-03, which was in the bug report).
    What's the merge process?

    @ghost
    Copy link

    ghost commented Oct 3, 2021

    Hi, @chasevanb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Oct 3, 2021
    @Sandido Sandido added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 5, 2021
    @ghost ghost removed the no-recent-activity label Oct 5, 2021
    @Sandido
    Copy link
    Member

    Sandido commented Oct 5, 2021

    Hi @chasevanb , @ArcturusZhang ,

    As per the Azure Breaking Change requirements we have to follow (seen here: https://aka.ms/AzBreakingChangesPolicy), this is a change of
    'Change input/output required → optional'.
    This requires a breaking change request and approval before we can merge this change.
    The reason is because possibly 'Client code stops compiling due to change in SDK method parameters'.

    The Azure Breaking Change document does detail how to request this Breaking Change request. Please submit this and let us know when it is approved.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 18, 2021
    @cataggar
    Copy link
    Member

    cataggar commented Oct 21, 2021

    @Sandido & @ArcturusZhang, the breaking changes were approved.

    @chasevanb
    Copy link
    Contributor Author

    @Sandido @ArcturusZhang Can I get final review and merge unblocked for this?

    @ghost
    Copy link

    ghost commented Nov 14, 2021

    Hi, @chasevanb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Nov 14, 2021
    @chasevanb
    Copy link
    Contributor Author

    closing, this is going into 2021-11-01 release instead

    @chasevanb chasevanb closed this Nov 19, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go Compute DoNotMerge <valid label in PR review process> use to hold merge after approval FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants