-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
location not required for VM extensions in VirtualMachines_List #15940
Conversation
required in VM extension operations
Hi, @chasevanb Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
[Staging] SDK Track2 Validation: 3 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- compute/resource-manager/readme.md#package-2021-07-01
- compute/resource-manager/readme.md#package-2021-07-01-only
- compute/resource-manager/readme.md#package-2021-06-01-preview
- compute/resource-manager/readme.md#package-2021-04-01
- compute/resource-manager/readme.md#package-2021-04-01-only
- compute/resource-manager/readme.md#package-2021-03-01
- compute/resource-manager/readme.md#package-2021-03-01-only
Rule | Message |
---|---|
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01-only", "details":"Error: Plugin prechecker reported failure." |
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"Error: Plugin prechecker reported failure." |
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01-only", "details":"Error: Plugin prechecker reported failure." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Error: Plugin prechecker reported failure." |
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Error: Plugin prechecker reported failure." |
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Error: Plugin prechecker reported failure." |
AutorestCore/Exception |
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Error: Plugin prechecker reported failure." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to correct other api-versions?
@ArcturusZhang |
Hi, @chasevanb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi @chasevanb , @ArcturusZhang , As per the Azure Breaking Change requirements we have to follow (seen here: https://aka.ms/AzBreakingChangesPolicy), this is a change of The Azure Breaking Change document does detail how to request this Breaking Change request. Please submit this and let us know when it is approved. |
@Sandido & @ArcturusZhang, the breaking changes were approved. |
@Sandido @ArcturusZhang Can I get final review and merge unblocked for this? |
Hi, @chasevanb. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
closing, this is going into 2021-11-01 release instead |
I generated the C# SDK with my changes using
dotnet build /t:GenerateCode
, since it is changing an existing property from required to not required. The code diff yielded no code changes.This property update addresses: #14459
Generation warning for not required property
Git diff output (only comment changes, unrelated to my change taken from main head):
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.