Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 #15958

Conversation

mitagarg
Copy link
Contributor

@mitagarg mitagarg commented Sep 8, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@mitagarg mitagarg requested a review from kjeur as a code owner September 8, 2021 08:19
@openapi-workflow-bot
Copy link

Hi, @mitagarg Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L424
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1418
    R4037 - MissingTypeObject The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1787
    R4037 - MissingTypeObject The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1866
    R4037 - MissingTypeObject The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1904
    R4037 - MissingTypeObject The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2167
    R4037 - MissingTypeObject The schema 'ReservationSummariesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2901
    R4037 - MissingTypeObject The schema 'ReservationSummaryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2919
    R4037 - MissingTypeObject The schema 'ReservationDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3026
    R4037 - MissingTypeObject The schema 'ReservationDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3044
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3136
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3171
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3210
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3248
    R4037 - MissingTypeObject The schema 'ReservationRecommendationDetailsUsageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3286
    R4037 - MissingTypeObject The schema 'ReservationRecommendationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3319
    R4037 - MissingTypeObject The schema 'LegacyReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392
    R4037 - MissingTypeObject The schema 'SkuProperty' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3481
    R4037 - MissingTypeObject The schema 'ModernReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3516
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3608
    R4037 - MissingTypeObject The schema 'LegacyReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3756
    R4037 - MissingTypeObject The schema 'ReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3881
    R4037 - MissingTypeObject The schema 'ModernReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3899
    R4037 - MissingTypeObject The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3933
    R4037 - MissingTypeObject The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3955
    R4037 - MissingTypeObject The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3971
    R4037 - MissingTypeObject The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4005
    R4037 - MissingTypeObject The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4076
    R4037 - MissingTypeObject The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4094
    R4037 - MissingTypeObject The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4119
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 2 Errors, 41 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/forecasts' removed or restructured?
    Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1421:5
    1015 - ParameterInHasChanged How the parameter is passed has changed -- it used to be 'query', now it is 'path'.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1146:9
    Old: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9


    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Consumption/usageDetails/download' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L154:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/reservationRecommendations' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L876:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/forecasts' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1058:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1194:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1786:3
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1237:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Charges_ListByScope' to 'Charges_List'. This will impact generated code.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L480:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L533:7
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L467:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Usage' from the old version.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4008:9
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2238:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L131:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L119:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L218:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L275:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1316:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L958:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1382:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1023:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L571:13
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1873:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1313:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1839:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1290:5
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3342:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2071:5
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3326:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2097:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4464:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2724:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4470:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2730:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L571:13
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1848:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1298:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'filters' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4007:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2237:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4459:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4459:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4459:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4459:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4459:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3354:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2082:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4479:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'kind' that was not found in the old version.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1848:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1298:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - Approved - 8.0.0
    -	Operation ReservationRecommendationDetailsOperations.get has a new signature
    +	Removed operation group ForecastsOperations
    ️✔️azure-sdk-for-go - consumption/mgmt/2019-10-01/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2019-01-01/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-10-01/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-08-31/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-06-30/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-05-31/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-03-31/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2018-01-31/consumption - v57.4.0
    ️✔️azure-sdk-for-go - consumption/mgmt/2017-11-30/consumption - v57.4.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-12-30-preview/consumption - v57.4.0
    ️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-04-24-preview/consumption - v57.4.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 052bec2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 052bec2. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️consumption/mgmt/2019-10-01/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2019-01-01/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-10-01/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-08-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-06-30/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-05-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-03-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-01-31/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2017-11-30/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 052bec2. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter pricing_model
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter credit_currency
      info	[Changelog]   - Model LotSummary has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter original_amount_in_billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter purchased_date
      info	[Changelog]   - Model LotSummary has a new parameter status
      info	[Changelog]   - Model LotSummary has a new parameter reseller
      info	[Changelog]   - Model LotSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model LotSummary has a new parameter e_tag
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model ModernUsageDetail has a new parameter benefit_name
      info	[Changelog]   - Model ModernUsageDetail has a new parameter cost_allocation_rule_name
      info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
      info	[Changelog]   - Model ModernUsageDetail has a new parameter provider
      info	[Changelog]   - Model ModernUsageDetail has a new parameter effective_price
      info	[Changelog]   - Model ModernUsageDetail has a new parameter benefit_id
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pricing_model
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter credit_currency
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_display_name
      info	[Changelog]   - Model EventSummary has a new parameter lot_id
      info	[Changelog]   - Model EventSummary has a new parameter new_credit_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter canceled_credit
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_id
      info	[Changelog]   - Model EventSummary has a new parameter billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter credit_expired_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter reseller
      info	[Changelog]   - Model EventSummary has a new parameter closed_balance_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter charges_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter adjustments_in_billing_currency
      info	[Changelog]   - Model EventSummary has a new parameter e_tag
      info	[Changelog]   - Model EventSummary has a new parameter lot_source
      info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model CreditBalanceSummary has a new parameter estimated_balance_in_billing_currency
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model UsageDetail has a new parameter etag
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model CreditSummary has a new parameter credit_currency
      info	[Changelog]   - Model CreditSummary has a new parameter etag
      info	[Changelog]   - Model CreditSummary has a new parameter billing_currency
      info	[Changelog]   - Model CreditSummary has a new parameter reseller
      info	[Changelog]   - Model CreditSummary has a new parameter e_tag
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_account
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_account
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ReservationRecommendationDetailsOperations.get has a new signature
      info	[Changelog]   - Removed operation LotsOperations.list
      info	[Changelog]   - Removed operation EventsOperations.list
      info	[Changelog]   - Removed operation group ForecastsOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 052bec2. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-01 08:50:38 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-consumption;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-01 08:50:38 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-01 08:50:38 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Skip] pom already has module sdk/consumption
      cmderr	[generate.py] 2021-10-01 08:51:12 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2021-10-01 08:52:11 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-01 08:52:13 DEBUG Got artifact_id: azure-resourcemanager-consumption
      cmderr	[Inst] 2021-10-01 08:52:13 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-01 08:52:13 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-01 08:52:13 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-01 08:52:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15958/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.3.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 052bec2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
      cmderr	[npmPack] created ./dist/arm-consumption.js in 583ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 052bec2. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2866) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-01-31/Microsoft.Consumption.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2866) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2866) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️consumption [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost
    Copy link

    ghost commented Sep 8, 2021

    CLA assistant check
    All CLA requirements met.

    @mitagarg mitagarg requested a review from adwise3 September 8, 2021 17:54
    @mitagarg mitagarg requested a review from shrutis06 September 10, 2021 04:22
    @openapi-workflow-bot
    Copy link

    Hi, @mitagarg your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2021
    @msyyc
    Copy link
    Member

    msyyc commented Sep 24, 2021

    approve for python breaking change.

    @raosuhas
    Copy link

          "readOnly": true
    

    Consider using extendible enum


    Refers to: specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/consumption.json:2134 in baae8f0. [](commit_id = baae8f0, deletion_comment = False)

    @raosuhas
    Copy link

        },
    

    Same here. Consider using the same objet as well


    Refers to: specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/consumption.json:2176 in baae8f0. [](commit_id = baae8f0, deletion_comment = False)

    Copy link

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @raosuhas raosuhas added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2021
    @qwordy
    Copy link
    Member

    qwordy commented Sep 28, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @akning-ms akning-ms merged commit 052bec2 into Azure:main Oct 1, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Oct 1, 2021
    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    …on stable/2021-10-01 (Azure#15958)
    
    * Adds base for updating Microsoft.Consumption from version stable/2021-05-01 to version 2021-10-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * added benefitid and benefitname
    
    * adding descr for benefitid and benefitname
    
    * Deprecate Forecasts
    
    * added provider in modern
    
    * Adding description for the provider
    
    * 1) removed BenefitId and BenefitName from legacy 2) chnaged value of Publishertype fro 1pp to Microsoft 3) updated examples with ReservationName and BenefitId and BeneftName for modern
    
    * Make changes based on s360
    
    * Fix example errors
    
    * Missed an instance of purchaseDate type
    
    * No schema for 204
    
    * No schema for 204
    
    * No schema for 204
    
    * Ran prettier
    
    * Add changes to 10.01.21
    
    * Ran prettier
    
    * Revert "Ran prettier"
    
    This reverts commit 1a0fbfe.
    
    * Revert "No schema for 204"
    
    This reverts commit 181f6c5.
    
    * Revert "Missed an instance of purchaseDate type"
    
    This reverts commit d77898d.
    
    * Revert "Fix example errors"
    
    This reverts commit 06be042.
    
    * Revert "Make changes based on s360"
    
    This reverts commit 0960cc2.
    
    * Manually change 2021-05-01
    
    * removing reservationName
    
    * costAllocationRule
    
    * Adding missing fields
    
    * Operation scopeReservationRecommendationDetails had two params with the same name scope, so fixing it.
    
    * chnaging the casing for eTag
    
    * chnaging the casing for eTag
    
    * reservation api
    
    * Arm feedback - add enum to PricingModel
    
    * pretty check
    
    * linter check
    
    * pretty check
    
    Co-authored-by: Mita Garg <v-migarg@microsoft.com>
    Co-authored-by: Alex Goldschmidt <algoldsc@microsoft.com>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …on stable/2021-10-01 (Azure#15958)
    
    * Adds base for updating Microsoft.Consumption from version stable/2021-05-01 to version 2021-10-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * added benefitid and benefitname
    
    * adding descr for benefitid and benefitname
    
    * Deprecate Forecasts
    
    * added provider in modern
    
    * Adding description for the provider
    
    * 1) removed BenefitId and BenefitName from legacy 2) chnaged value of Publishertype fro 1pp to Microsoft 3) updated examples with ReservationName and BenefitId and BeneftName for modern
    
    * Make changes based on s360
    
    * Fix example errors
    
    * Missed an instance of purchaseDate type
    
    * No schema for 204
    
    * No schema for 204
    
    * No schema for 204
    
    * Ran prettier
    
    * Add changes to 10.01.21
    
    * Ran prettier
    
    * Revert "Ran prettier"
    
    This reverts commit 1a0fbfe.
    
    * Revert "No schema for 204"
    
    This reverts commit 181f6c5.
    
    * Revert "Missed an instance of purchaseDate type"
    
    This reverts commit d77898d.
    
    * Revert "Fix example errors"
    
    This reverts commit 06be042.
    
    * Revert "Make changes based on s360"
    
    This reverts commit 0960cc2.
    
    * Manually change 2021-05-01
    
    * removing reservationName
    
    * costAllocationRule
    
    * Adding missing fields
    
    * Operation scopeReservationRecommendationDetails had two params with the same name scope, so fixing it.
    
    * chnaging the casing for eTag
    
    * chnaging the casing for eTag
    
    * reservation api
    
    * Arm feedback - add enum to PricingModel
    
    * pretty check
    
    * linter check
    
    * pretty check
    
    Co-authored-by: Mita Garg <v-migarg@microsoft.com>
    Co-authored-by: Alex Goldschmidt <algoldsc@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants