Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api management events schema #15987
api management events schema #15987
Changes from 10 commits
179b4e3
f8bb8c6
95805dc
3534a76
220d282
f221e24
a1534e6
ef10a16
a99abd6
068fce1
4d9f58e
2f54f2f
5091d95
ead07f0
9daae81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that for some events
API
is capitalized, and in other cases, it's spellApi
(e.g.APIUpdated
vsApiReleaseUpdated
) I just want to confirm that the difference in casing between these event is expected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, curious about this - We would likely need to rename this via swagger transforms in .NET. It also seems odd that we have API (in whatever casing) twice in the name of the events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense but the casing should be consistent, right?
We will have to transform it anyway to use "Api" everywhere if we leave it as "API" in the swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApiManagement is the name of our service that hosts "API" entities. API is an abbreviation so we normally spell it with all caps.
Renaming "ApiManagementAPI" to "ApiManagementApi" requires an extra rollout train to all our services. We prefer to stay as it is.