Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CosmosDB] Fixing bug in CassandraView APIs #16052

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[CosmosDB] Fixing bug in CassandraView APIs #16052

merged 1 commit into from
Sep 17, 2021

Conversation

ajparule
Copy link
Contributor

@ajparule ajparule commented Sep 15, 2021

This PR adds viewDefinition as required property in CassandraViewResource object

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Added viewDefinition as required property
@openapi-workflow-bot
Copy link

Hi, @ajparule Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 15, 2021

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    1034 - AddedRequiredProperty The new version has new required property 'viewDefinition' that was not found in the old version.
    New: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L7831:9
    Old: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L7831:9
    1034 - AddedRequiredProperty The new version has new required property 'viewDefinition' that was not found in the old version.
    New: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L8587:5
    Old: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L8587:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L8673
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L8673
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L405
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L454
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L68
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L113
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L166
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L210
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L260
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L306
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/notebook.json#L352
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateEndpointConnection.json#L155
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateEndpointConnection.json#L199
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateEndpointConnection.json#L61
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateEndpointConnection.json#L100
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateLinkResources.json#L61
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/privateLinkResources.json#L100
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L180
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L1750
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L2091
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L2462
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L2640
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L2818
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L2972
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L3319
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L3660
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L3989
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L4330
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L4671
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5012
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 15, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-cosmosdb - 6.4.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-06-15/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-05-15/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-04-15/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-03-15/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2021-01-15/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2019-08-01/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - cosmos-db/mgmt/2015-04-08/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2021-07-01-preview/documentdb - v57.2.0
    azure-sdk-for-go - preview/cosmos-db/mgmt/2021-04-01-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2021-03-01-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-09-01-preview/documentdb - v57.2.0
    azure-sdk-for-go - preview/cosmos-db/mgmt/2020-06-01-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-04-01-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2020-03-01-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2019-12-12-preview/documentdb - v57.2.0
    ️✔️azure-sdk-for-go - preview/cosmos-db/mgmt/2019-08-01-preview/documentdb - v57.2.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f7bdc95. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model SqlContainerCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model CassandraTableGetResults has a new parameter identity
      info	[Changelog]   - Model SqlContainerGetResults has a new parameter identity
      info	[Changelog]   - Model MongoDBDatabaseCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model DatabaseAccountUpdateParameters has a new parameter diagnostic_log_settings
      info	[Changelog]   - Model MongoDBCollectionCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model TableGetResults has a new parameter identity
      info	[Changelog]   - Model GremlinGraphCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model DatabaseAccountCreateUpdateParameters has a new parameter diagnostic_log_settings
      info	[Changelog]   - Model CassandraKeyspaceGetResults has a new parameter identity
      info	[Changelog]   - Model SqlDatabaseGetResults has a new parameter identity
      info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter diagnostic_log_settings
      info	[Changelog]   - Model GremlinGraphGetResults has a new parameter identity
      info	[Changelog]   - Model SqlTriggerCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model MongoDBDatabaseGetResults has a new parameter identity
      info	[Changelog]   - Model GremlinDatabaseCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model SqlUserDefinedFunctionGetResults has a new parameter identity
      info	[Changelog]   - Model SqlUserDefinedFunctionCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model CassandraTableCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model MongoDBCollectionGetResults has a new parameter identity
      info	[Changelog]   - Model ARMResourceProperties has a new parameter identity
      info	[Changelog]   - Model CassandraKeyspaceCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model ThroughputSettingsGetResults has a new parameter identity
      info	[Changelog]   - Model SqlTriggerGetResults has a new parameter identity
      info	[Changelog]   - Model SqlStoredProcedureCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model ThroughputSettingsUpdateParameters has a new parameter identity
      info	[Changelog]   - Model GremlinDatabaseGetResults has a new parameter identity
      info	[Changelog]   - Model SqlDatabaseCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Model PeriodicModeProperties has a new parameter backup_storage_redundancy
      info	[Changelog]   - Model SqlStoredProcedureGetResults has a new parameter identity
      info	[Changelog]   - Model TableCreateUpdateParameters has a new parameter identity
      info	[Changelog]   - Added operation CassandraResourcesOperations.get_cassandra_view_throughput
      info	[Changelog]   - Added operation CassandraResourcesOperations.begin_migrate_cassandra_view_to_manual_throughput
      info	[Changelog]   - Added operation CassandraResourcesOperations.list_cassandra_views
      info	[Changelog]   - Added operation CassandraResourcesOperations.get_cassandra_view
      info	[Changelog]   - Added operation CassandraResourcesOperations.begin_create_update_cassandra_view
      info	[Changelog]   - Added operation CassandraResourcesOperations.begin_migrate_cassandra_view_to_autoscale
      info	[Changelog]   - Added operation CassandraResourcesOperations.begin_update_cassandra_view_throughput
      info	[Changelog]   - Added operation CassandraResourcesOperations.begin_delete_cassandra_view
      info	[Changelog]   - Added operation group CosmosDBManagementClientOperationsMixin
      info	[Changelog]   - Added operation group ServiceOperations
      info	[Changelog]   - Added operation group CassandraDataCentersOperations
      info	[Changelog]   - Added operation group CassandraClustersOperations
      info	[Changelog]   - Added operation group GraphResourcesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter create_mode of model DatabaseAccountCreateUpdateParameters is now required
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f7bdc95. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-17 04:50:32 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated"
      cmderr	[generate.py] 2021-09-17 04:50:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-17 04:50:32 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [POM][Skip] pom already has module sdk/cosmos
      cmderr	[generate.py] 2021-09-17 04:51:32 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-cosmos-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-17 04:57:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16052/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f7bdc95. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cosmos-db/mgmt/2021-06-15/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2021-05-15/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2021-04-15/documentdb [View full logs
      info	[Changelog] This is a new package
    • ️✔️cosmos-db/mgmt/2021-03-15/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2021-01-15/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2019-08-01/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2015-04-08/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2021-07-01-preview/documentdb [View full logs
      info	[Changelog] This is a new package
    • ️✔️preview/cosmos-db/mgmt/2021-04-01-preview/documentdb [View full logsBreaking Change Detected
      Only show 8 items here, please refer to log for details.
      info	[Changelog] - New const `ServiceTypeBasicServiceResourcePropertiesServiceTypeDataTransfer`
      info	[Changelog] - New function `ServiceResourceCreateUpdateParameters.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*ServiceResourceCreateUpdateParameters.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `ServiceResourceCreateUpdateParameters`
      info	[Changelog] - New struct `ServiceResourceCreateUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 8 additive change(s).
      info	[Changelog]
    • ️✔️preview/cosmos-db/mgmt/2021-03-01-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logsBreaking Change Detected
      Only show 8 items here, please refer to log for details.
      info	[Changelog] - New const `Local`
      info	[Changelog] - New const `Zone`
      info	[Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy`
      info	[Changelog] - New struct `CloudError`
      info	[Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties`
      info	[Changelog]
      info	[Changelog] Total 7 breaking change(s), 7 additive change(s).
      info	[Changelog]
    • ️✔️preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs
      info	[Changelog] No exported changes
    ️❌ azure-sdk-for-go-track2 failed [Detail]
    • Failed [Logs]Release - Generate from f7bdc95. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] package 'armcosmos' doesn't contain any exports
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f7bdc95. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js...
      cmderr	[npmPack] created ./dist/arm-cosmosdb.js in 1.2s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f7bdc95. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ajparule, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @MehaKaushik
    Copy link
    Contributor

    @ArcturusZhang please have a look from Go sdk perspective

    @ajparule
    Copy link
    Contributor Author

    @ArcturusZhang , @lei-msft can you please look into this PR

    Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
    Added viewDefinition as required property
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    Added viewDefinition as required property
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants