Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01 #16181

Merged
merged 3 commits into from
Oct 8, 2021
Merged

[Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01 #16181

merged 3 commits into from
Oct 8, 2021

Conversation

rarayudu
Copy link
Contributor

@rarayudu rarayudu commented Sep 27, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @rarayudu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 27, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 23 Errors, 2 Warnings failed [Detail]
    Rule Message
    ❌ 1010 - AddingRequiredParameter The required parameter 'integrationServiceEnvironmentManagedApi' was added in the new version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6219:11
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L7331:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L7319:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L7336:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L7323:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6455:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L6398:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8314:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8298:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8319:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8302:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8332:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8313:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8345:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8324:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8363:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8339:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8314:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8298:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8319:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8302:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8332:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8313:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8345:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8324:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8363:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8339:9
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6454:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sku' renamed or removed?
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6454:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6454:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6454:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'identity' in response that was not found in the old version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6474:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L6465:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'identity' in response that was not found in the old version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8833:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'deploymentParameters' in response that was not found in the old version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L9311:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8297:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'identity' that was not found in the old version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L6474:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L6465:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'identity' that was not found in the old version.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L8833:7
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8805:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L9371:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L9226:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Logic/stable/2019-05-01/logic.json#L9295:9
    Old: Microsoft.Logic/stable/2019-05-01/logic.json#L8577:9
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3017 - GuidUsage Guid used in model definition 'ManagedServiceIdentity' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L9152


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6291
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L7770
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L8056
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L8060
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Logic/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6367
    ❌ R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6405
    ❌ R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6437
    ❌ R4037 - MissingTypeObject The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12184
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'IntegrationServiceEnvironmentManagedApis_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6183
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L8174
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L8605
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L8834
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12762
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12863
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12951
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'WorkflowTriggers_Run' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L1096
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'WorkflowTriggerHistories_Resubmit' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L1543
    ⚠️ R2057 - InvalidSkuModel Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L7307
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationServiceEnvironmentNetworkHealthModel'. Consider using the plural form of 'IntegrationServiceEnvironmentNetworkHealth' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6025
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'versions' with immediate parent 'Workflow', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6587
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'triggers' with immediate parent 'Workflow', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6686
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'histories' with immediate parent 'WorkflowTrigger', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6857
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'runs' with immediate parent 'Workflow', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6978
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'actions' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L7103
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12552
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'requestHistories' with immediate parent 'WorkflowRunActionRepetitionDefinition', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12946
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'requestHistories' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12946
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12552
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L6978
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
    Location: Microsoft.Logic/stable/2019-05-01/logic.json#L12754
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 27, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-logic - 9.0.0
    +	Operation IntegrationServiceEnvironmentManagedApisOperations.begin_put has a new signature
    ❌azure-sdk-for-go - logic/mgmt/2019-05-01/logic - v58.0.0
    +	Field `autorest.Response` of struct `ManagedAPIListResult` has been removed
+	Field `autorest.Response` of struct `ManagedAPI` has been removed
+	Function `*ManagedAPIListResultIterator.NextWithContext` has been removed
+	Function `*ManagedAPIListResultIterator.Next` has been removed
+	Function `*ManagedAPIListResultPage.NextWithContext` has been removed
+	Function `*ManagedAPIListResultPage.Next` has been removed
+	Function `IntegrationServiceEnvironmentManagedApisClient.GetResponder` return value(s) have been changed from `(ManagedAPI, error)` to `(IntegrationServiceEnvironmentManagedAPI, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.Get` return value(s) have been changed from `(ManagedAPI, error)` to `(IntegrationServiceEnvironmentManagedAPI, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.ListComplete` return value(s) have been changed from `(ManagedAPIListResultIterator, error)` to `(IntegrationServiceEnvironmentManagedAPIListResultIterator, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.ListResponder` return value(s) have been changed from `(ManagedAPIListResult, error)` to `(IntegrationServiceEnvironmentManagedAPIListResult, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.List` return value(s) have been changed from `(ManagedAPIListResultPage, error)` to `(IntegrationServiceEnvironmentManagedAPIListResultPage, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.PutPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string, string, IntegrationServiceEnvironmentManagedAPI)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.PutResponder` return value(s) have been changed from `(ManagedAPI, error)` to `(IntegrationServiceEnvironmentManagedAPI, error)`
+	Function `IntegrationServiceEnvironmentManagedApisClient.Put` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string, string, IntegrationServiceEnvironmentManagedAPI)`
+	Function `ManagedAPIListResult.IsEmpty` has been removed
+	Function `ManagedAPIListResultIterator.NotDone` has been removed
+	Function `ManagedAPIListResultIterator.Response` has been removed
+	Function `ManagedAPIListResultIterator.Value` has been removed
+	Function `ManagedAPIListResultPage.NotDone` has been removed
+	Function `ManagedAPIListResultPage.Response` has been removed
+	Function `ManagedAPIListResultPage.Values` has been removed
+	Function `NewManagedAPIListResultIterator` has been removed
+	Function `NewManagedAPIListResultPage` has been removed
+	Function `OpenAuthenticationAccessPolicy.MarshalJSON` has been removed
+	Struct `ManagedAPIListResultIterator` has been removed
+	Struct `ManagedAPIListResultPage` has been removed
+	Type of `IntegrationAccountProperties.IntegrationServiceEnvironment` has been changed from `*IntegrationServiceEnvironment` to `*ResourceReference`
+	Type of `IntegrationServiceEnvironmentManagedApisPutFuture.Result` has been changed from `func(IntegrationServiceEnvironmentManagedApisClient) (ManagedAPI, error)` to `func(IntegrationServiceEnvironmentManagedApisClient) (IntegrationServiceEnvironmentManagedAPI, error)`
    ️✔️azure-sdk-for-go - logic/mgmt/2016-06-01/logic - v58.0.0
    ️✔️azure-sdk-for-go - preview/logic/mgmt/2018-07-01-preview/logic - v58.0.0
    ️✔️azure-sdk-for-go - preview/logic/mgmt/2015-08-01-preview/logic - v58.0.0
    ️✔️azure-sdk-for-go - preview/logic/mgmt/2015-02-01-preview/logic - v58.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 5cf3e4a. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/logic/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.Logic [View full logs]  [Release SDK Changes] 
      cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/Workflows.ScenarioTests.cs(120,39): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/Workflows.ScenarioTests.cs(160,39): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/ScenarioTestsBase.cs(69,17): error CS1739: The best overload for 'IntegrationAccount' does not have a parameter named 'properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(484,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(485,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(486,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(487,57): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(507,24): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/Workflows.ScenarioTests.cs(120,39): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/Workflows.ScenarioTests.cs(160,39): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/ScenarioTests/ScenarioTestsBase.cs(69,17): error CS1739: The best overload for 'IntegrationAccount' does not have a parameter named 'properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(484,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(485,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(486,54): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(487,57): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/InMemoryTests/Workflows.InMemoryTests.cs(507,24): error CS1929: 'IWorkflowsOperations' does not contain a definition for 'Update' and the best extension method overload 'IntegrationAccountsOperationsExtensions.Update(IIntegrationAccountsOperations, string, string, IntegrationAccount)' requires a receiver of type 'IIntegrationAccountsOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/logic/Microsoft.Azure.Management.Logic/tests/Microsoft.Azure.Management.Logic.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5cf3e4a. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-logic [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Workflow has a new parameter identity
info	[Changelog]   - Model IntegrationServiceEnvironment has a new parameter identity
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation IntegrationServiceEnvironmentManagedApisOperations.begin_put has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5cf3e4a. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-10-08 02:05:53 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-logic;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-10-08 02:05:53 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-10-08 02:05:53 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/logic/azure-resourcemanager-logic --java.namespace=com.azure.resourcemanager.logic   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/logic/resource-manager/readme.md
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-logic
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Skip] pom already has module azure-resourcemanager-logic
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Skip] pom already has module sdk/logic
cmderr	[generate.py] 2021-10-08 02:06:44 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-logic [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-10-08 02:14:31 DEBUG Got artifact_id: azure-resourcemanager-logic
cmderr	[Inst] 2021-10-08 02:14:31 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-10-08 02:14:31 DEBUG Got artifact: azure-resourcemanager-logic-1.0.0-beta.2.jar
cmderr	[Inst] 2021-10-08 02:14:31 DEBUG Match jar package: azure-resourcemanager-logic-1.0.0-beta.2.jar
cmderr	[Inst] 2021-10-08 02:14:31 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16181/azure-sdk-for-java/azure-resourcemanager-logic/azure-resourcemanager-logic-1.0.0-beta.2.jar\" -o azure-resourcemanager-logic-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-logic -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-logic-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5cf3e4a. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️logic/mgmt/2019-05-01/logic [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `UserAssignedIdentity.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IntegrationServiceEnvironmentManagedAPIListResultPage.Values() []IntegrationServiceEnvironmentManagedAPI`
info	[Changelog] - New function `PossibleManagedServiceIdentityTypeValues() []ManagedServiceIdentityType`
info	[Changelog] - New function `*IntegrationServiceEnvironmentManagedAPIListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `*IntegrationServiceEnvironmentManagedAPI.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `NewIntegrationServiceEnvironmentManagedAPIListResultPage(IntegrationServiceEnvironmentManagedAPIListResult, func(context.Context, IntegrationServiceEnvironmentManagedAPIListResult) (IntegrationServiceEnvironmentManagedAPIListResult, error)) IntegrationServiceEnvironmentManagedAPIListResultPage`
info	[Changelog] - New function `*IntegrationServiceEnvironmentManagedAPIListResultIterator.Next() error`
info	[Changelog] - New function `IntegrationServiceEnvironmentManagedAPIListResultIterator.NotDone() bool`
info	[Changelog] - New function `IntegrationServiceEnvironmentManagedAPIListResultIterator.Response() IntegrationServiceEnvironmentManagedAPIListResult`
info	[Changelog] - New function `*IntegrationServiceEnvironmentManagedAPIListResultPage.Next() error`
info	[Changelog] - New function `*IntegrationServiceEnvironmentManagedAPIListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPI`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPIDeploymentParameters`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPIListResult`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPIListResultIterator`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPIListResultPage`
info	[Changelog] - New struct `IntegrationServiceEnvironmentManagedAPIProperties`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `IntegrationServiceEnvironment`
info	[Changelog] - New field `Identity` in struct `Workflow`
info	[Changelog]
info	[Changelog] Total 30 breaking change(s), 41 additive change(s).
info	[Changelog]
    • ️✔️logic/mgmt/2016-06-01/logic [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/logic/mgmt/2018-07-01-preview/logic [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/logic/mgmt/2015-08-01-preview/logic [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/logic/mgmt/2015-02-01-preview/logic [View full logs]  
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5cf3e4a. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/logic/resource-manager/readme.md
    • ️✔️@azure/arm-logic [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/logicManagementClient.js → ./dist/arm-logic.js...
cmderr	[npmPack] created ./dist/arm-logic.js in 934ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5cf3e4a. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2317) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2317) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2317) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:2317) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2317) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
warn	No file changes detected after generation
warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @rarayudu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Sep 27, 2021
    Closed
    Closed
    This was referenced Sep 27, 2021
    Closed
    Closed
    @rarayudu
    Copy link
    Contributor Author

    Regarding the breaking change comment - This PR is to mainly fix the bugs that we found while generating the Terraform SDK. The API already has been released long time back and the API responds back with the updates response.

    @jianyexi jianyexi assigned raych1 and unassigned jianyexi Sep 29, 2021
    @raych1
    Copy link
    Member

    raych1 commented Sep 30, 2021

    Hi @rarayudu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @rarayudu , can you follow above action for breaking change review?

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 7, 2021
    @raych1 raych1 merged commit 5cf3e4a into Azure:main Oct 8, 2021
    This was referenced Oct 8, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @anthony-c-martin anthony-c-martin mentioned this pull request Oct 18, 2021
    Closed
    @tombuildsstuff tombuildsstuff mentioned this pull request Oct 19, 2021
    Closed
    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    @rarayudu @jovannikolov-msft
    [Hub Generated] Review request for Microsoft.Logic to add version sta…
    141b7a9 
    …ble/2019-05-01 (Azure#16181)

* Fixing bugs in Logic Apps swaggers

* Updating example

* Addressed feedback
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @rarayudu @LeiWang3
    [Hub Generated] Review request for Microsoft.Logic to add version sta…
    d3edcb1 
    …ble/2019-05-01 (Azure#16181)

* Fixing bugs in Logic Apps swaggers

* Updating example

* Addressed feedback
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @neil-yechenwei neil-yechenwei neil-yechenwei left review comments

    @raych1 raych1 raych1 approved these changes

    Assignees

    @raych1 raych1

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @rarayudu @raych1 @neil-yechenwei @JeffreyRichter @jianyexi