Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device discriminator model #16316

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

swatika
Copy link
Contributor

@swatika swatika commented Oct 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @swatika Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'azureStackEdge' renamed or removed?
    New: Microsoft.HybridNetwork/preview/2020-01-01-preview/device.json#L419:7
    Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/device.json#L400:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'azureStackEdge' renamed or removed?
    New: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L424:7
    Old: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L405:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.HybridNetwork/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/operation.json#L37
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.HybridNetwork/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.HybridNetwork/preview/2020-01-01-preview/operation.json#L37
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L38
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L82
    R4037 - MissingTypeObject The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L94
    R4037 - MissingTypeObject The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L128
    R4037 - MissingTypeObject The schema 'OsProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L203
    R4037 - MissingTypeObject The schema 'LinuxConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L225
    R4037 - MissingTypeObject The schema 'SshConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L234
    R4037 - MissingTypeObject The schema 'SshPublicKey' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L246
    R4037 - MissingTypeObject The schema 'NetworkFunction' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L333
    R4037 - MissingTypeObject The schema 'NetworkFunctionPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L357
    R4037 - MissingTypeObject The schema 'NetworkFunctionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L414
    R4037 - MissingTypeObject The schema 'NetworkFunctionUserConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L431
    R4037 - MissingTypeObject The schema 'osProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/networkFunction.json#L448
    R4037 - MissingTypeObject The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L128
    R4037 - MissingTypeObject The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L94
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L38
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L82
    R4037 - MissingTypeObject The schema 'Device' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L379
    R4037 - MissingTypeObject The schema 'DevicePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L418
    R4037 - MissingTypeObject The schema 'DeviceRegistrationKey' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L467
    R4037 - MissingTypeObject The schema 'DeviceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/device.json#L477
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L38
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/common.json#L82
    R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/operation.json#L82
    R4037 - MissingTypeObject The schema 'Vendor' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/vendor.json#L692
    R4037 - MissingTypeObject The schema 'VendorPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/vendor.json#L712
    R4037 - MissingTypeObject The schema 'VendorSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/vendor.json#L730
    R4037 - MissingTypeObject The schema 'VendorSkuPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.HybridNetwork/stable/2021-05-01/vendor.json#L750
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-hybridnetwork - Approved - 1.0.0
    +	Model Device no longer has parameter azure_stack_edge
    +	Model DevicePropertiesFormat no longer has parameter azure_stack_edge
    azure-sdk-for-go - preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork - Approved - v58.0.0
    +	Field `AzureStackEdge` of struct `DevicePropertiesFormat` has been removed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5f32b50. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-hybridnetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model Device no longer has parameter azure_stack_edge
      info	[Changelog]   - Model DevicePropertiesFormat no longer has parameter azure_stack_edge
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5f32b50. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-08 06:20:15 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hybridnetwork;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-10-08 06:20:15 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-10-08 06:20:15 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.38 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridnetwork/azure-resourcemanager-hybridnetwork --java.namespace=com.azure.resourcemanager.hybridnetwork   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hybridnetwork
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridnetwork
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Skip] pom already has module sdk/hybridnetwork
      cmderr	[generate.py] 2021-10-08 06:20:49 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-hybridnetwork [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG Got artifact_id: azure-resourcemanager-hybridnetwork
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG Match jar package: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-10-08 06:22:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16316/azure-sdk-for-java/azure-resourcemanager-hybridnetwork/azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\" -o azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridnetwork -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5f32b50. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `AzureStackEdge` of struct `DevicePropertiesFormat` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `DeviceTypeAzureStackEdge`
      info	[Changelog] - New function `AzureStackEdgeFormat.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `DevicePropertiesFormat.AsAzureStackEdgeFormat() (*AzureStackEdgeFormat, bool)`
      info	[Changelog] - New function `AzureStackEdgeFormat.AsAzureStackEdgeFormat() (*AzureStackEdgeFormat, bool)`
      info	[Changelog] - New function `AzureStackEdgeFormat.AsDevicePropertiesFormat() (*DevicePropertiesFormat, bool)`
      info	[Changelog] - New function `AzureStackEdgeFormat.AsBasicDevicePropertiesFormat() (BasicDevicePropertiesFormat, bool)`
      info	[Changelog] - New struct `AzureStackEdgeFormat`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 9 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5f32b50. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5f32b50. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2929) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2021-05-01/Microsoft.HybridNetwork.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2929) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2929) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️hybridnetwork [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @swatika, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @leni-msft
    Copy link
    Contributor

    Same changes have been merged in https://github.com/Azure/azure-rest-api-specs-pr/pull/4639

    @leni-msft leni-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 8, 2021
    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 8, 2021
    @msyyc msyyc merged commit 5f32b50 into Azure:main Oct 8, 2021
    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    Co-authored-by: swatikanaujia <swati.kanaujia@gmail.com>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    Co-authored-by: swatikanaujia <swati.kanaujia@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants