[Hub Generated] Public private branch 'ikanni/2021-04-30-preview_new' #16681
Conversation
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/4266 |
|
Hi, @ikanni Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
@chunyu3 I need your help in merging the above swagger. Please note the above PR was created based on the updates in the private branch. Questions: |
hi @ikanni The 'cross version breaking changes' which is compared to latest preview version, so it need 'breaking change' review and acquire approve. Even it is approved in private branch, it still need to acquired the approval here. Please acquire the 'breaking changes' approval. thanks. |
|
Hi @ikanni, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
…Azure#16681) * Copy the existing version 2020-06-30-preview as new version 2020-06-30-preview * [Automanage]Added new version 2021-04-30-preview * Fixed Hassan's commnet * Updated one example * Added report for Michele * Pushing for Michele * Pushing changes for Michele * Pushing changes for Michele * Pushing changes for Michele * Pushing changes for Michele * Pushing changes for Michele * Pushing changes for Michele * Fixed comments * Fixed comments
JackTn
deleted the
published/Azure/azure-rest-api-specs-pr/ikanni/2021-04-30-preview_new
branch
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.