Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TranslatorBatch API v1.1 #16705

Merged
merged 13 commits into from
Jan 12, 2022
Merged

Add TranslatorBatch API v1.1 #16705

merged 13 commits into from
Jan 12, 2022

Conversation

FadyEssam2
Copy link
Contributor

@FadyEssam2 FadyEssam2 commented Nov 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      • To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @FadyEssam2 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3017 - GuidUsage Guid used in model definition 'TranslationStatus' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: TranslatorText/stable/v1.1/TranslatorBatch.json#L1309
    ⚠️ R3017 - GuidUsage Guid used in model definition 'DocumentStatus' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: TranslatorText/stable/v1.1/TranslatorBatch.json#L1412
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 7 Errors, 7 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L46:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L107:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L147:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L119:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L158:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L144:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L182:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L573:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L610:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L585:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L621:11
    1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L610:11
    Old: TranslatorText/stable/v1.0/TranslatorBatch.json#L645:11


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L46:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L107:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L147:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L119:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L158:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L144:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L182:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L573:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L610:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L585:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L621:11
    ⚠️ 1028 - ArrayCollectionFormatChanged The new version has a different array collection format than the previous one.
    New: TranslatorText/stable/v1.1/TranslatorBatch.json#L610:11
    Old: TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json#L645:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 8, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - cognitiveservices/v3.0/translatortext - v61.1.0
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1f1d5b0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
      cmderr	[automation_generate.sh] npm notice
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 1f1d5b0. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Automation-Sdk-Generate.ps1] Could not execute because the application was not found or a compatible .NET SDK is not installed.
      cmderr	[Automation-Sdk-Generate.ps1] Possible reasons for this include:
      cmderr	[Automation-Sdk-Generate.ps1]   * You intended to execute a .NET program:
      cmderr	[Automation-Sdk-Generate.ps1]       The application 'msbuild' does not exist.
      cmderr	[Automation-Sdk-Generate.ps1]   * You intended to execute a .NET SDK command:
      cmderr	[Automation-Sdk-Generate.ps1]       A compatible installed .NET SDK for global.json version [6.0.100] from [/home/vsts/work/1/s/azure-sdk-for-net/global.json] was not found.
      cmderr	[Automation-Sdk-Generate.ps1]       Install the [6.0.100] .NET SDK or update [/home/vsts/work/1/s/azure-sdk-for-net/global.json] with an installed .NET SDK:
      cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.AI.Translation.Document
      cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • Azure.AI.Translation.Document [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1f1d5b0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-01-12 17:23:46 INFO [Skip] readme path does not format as specification/*/resource-manager/readme.md
      cmderr	[generate.py] 2022-01-12 17:23:46 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/readme.md
      cmderr	[generate.py] 2022-01-12 17:23:46 INFO [GENERATE] Autorest from JSON ../azure-rest-api-specs/specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/TranslatorBatch.json
      cmderr	[generate.py] 2022-01-12 17:23:46 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.44 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cognitiveservices/azure-cognitiveservices-TranslatorBatch --java.namespace=com.azure.cognitiveservices.TranslatorBatch --java --low-level-client --sdk-integration --generate-samples --input-file=../azure-rest-api-specs/specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/TranslatorBatch.json --java.credential-types=tokencredential --java.credential-scopes=https://cognitiveservices.azure.com/.default --artifact-id=azure-cognitiveservices-TranslatorBatch
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [VERSION][Not Found] cannot find version for "com.azure:azure-cognitiveservices-TranslatorBatch"
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [POM][Skip] pom already has module sdk/cognitiveservices
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2022-01-12 17:24:13 INFO mvn --no-transfer-progress clean verify package -f /home/vsts/work/1/s/azure-sdk-for-java/pom.xml -Dgpg.skip -Drevapi.skip -pl com.azure:azure-cognitiveservices-TranslatorBatch -am
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/batch.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/cancel.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/document.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/documents.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/format.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/glossary.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/operation.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/operations.json
      cmderr	[generate.py] 2022-01-12 17:26:41 INFO [Skip] changed file specification/cognitiveservices/data-plane/TranslatorText/stable/v1.1/examples/storage.json
    • ️✔️azure-cognitiveservices-TranslatorBatch [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Got artifact_id: azure-cognitiveservices-TranslatorBatch
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Got artifact: azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Got artifact: azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Got artifact: azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG Match jar package: azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-01-12 17:26:44 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16705/azure-sdk-for-java/azure-cognitiveservices-TranslatorBatch/azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1.jar\" -o azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure -DartifactId=azure-cognitiveservices-TranslatorBatch -Dversion=1.0.0-beta.0 -Dfile=azure-cognitiveservices-TranslatorBatch-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1f1d5b0. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cognitiveservices/v3.0/translatortext [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @FadyEssam2 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot
    Copy link

    Hi @FadyEssam2, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 16705 in repo Azure/azure-rest-api-specs

    @FadyEssam2 FadyEssam2 marked this pull request as ready for review January 3, 2022 21:06
    @FadyEssam2 FadyEssam2 requested a review from yangyuan as a code owner January 3, 2022 21:06
    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 16705 in repo Azure/azure-rest-api-specs

    @weidongxu-microsoft
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 16705 in repo Azure/azure-rest-api-specs

    @alexhcheng alexhcheng assigned JeffreyRichter and johanste and unassigned maririos Jan 6, 2022
    @alexhcheng
    Copy link
    Contributor

    As discussed in email, we can ignore the .net error (due to test bug).

    @alexhcheng
    Copy link
    Contributor

    @JeffreyRichter , @johanste : can you help with the merge please?

    @alexhcheng
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lmazuel lmazuel merged commit 1f1d5b0 into Azure:main Jan 12, 2022
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    * add API v1.1
    
    * Match v1.0 swagger
    
    * Remove unneeded changes
    
    * Address PR failures
    
    * Update readme
    
    * Update @failedDocumentStatusLink name
    
    * Fix swagger examples
    
    * Fixing swagger examples
    
    * Fix swagger
    
    * Address board review comments
    
    * move options to target level
    * remove the @ from failedDocumentStatusLink
    * switch the pdf output options to enum
    
    * Remove failedDocmentsStatusLink field from response
    
    * Update TranslatorText Readme file
    
    * Add collectionFormat
    
    Co-authored-by: Fady Essam <faanis@micrososft.com>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * add API v1.1
    
    * Match v1.0 swagger
    
    * Remove unneeded changes
    
    * Address PR failures
    
    * Update readme
    
    * Update @failedDocumentStatusLink name
    
    * Fix swagger examples
    
    * Fixing swagger examples
    
    * Fix swagger
    
    * Address board review comments
    
    * move options to target level
    * remove the @ from failedDocumentStatusLink
    * switch the pdf output options to enum
    
    * Remove failedDocmentsStatusLink field from response
    
    * Update TranslatorText Readme file
    
    * Add collectionFormat
    
    Co-authored-by: Fady Essam <faanis@micrososft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [Cognitive Services - Document Translator] REST API Review for Document Batch Translator API v1.1
    8 participants