Gallery 10-01 change (community gallery, CVM) #16824

kangsun-ctrl · 2021-11-19T21:23:05Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…pi-specs

…zure-rest-api-specs into gallery-10-01

ghost · 2021-12-26T16:02:39Z

Hi, @kangsun-ctrl. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-01-10T05:02:16Z

Hi, @kangsun-ctrl. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery.json

grizzlytheodore · 2022-02-01T17:54:10Z

specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery.json

+          ],
+          "x-ms-enum": {
+            "name": "ConfidentialVMEncryptionType",
+            "modelAsString": false


* Feature/cplat 2021 10 03 (#16512) * update new api version branch with base * change 2021-10-03 to 2021-10-01 * Update readme.md * fix folder structure * add community gallery * Feature/cplat 2021 10 03 (#16512) * update new api version branch with base * change 2021-10-03 to 2021-10-01 * Update readme.md * fix folder structure * add community gallery * remove sharedGallery and communityGallery * Gallery 10-01 change (community gallery, CVM) (#16824) * add new api version 2020-09-30 for gallery.json * add support for api change, sharing profile related * update, change post to patch * fix model validation error * fix typo * add shared gallery api * update * fix typo * update * update * update * chagne new api version to preview * update readme.md and nit * remove some required field and make groups readonly * add swagger support for Grace's and Tim's work * error fix * error fix * change api version name to 2020-09-30 withour 'preview' * update * fix typo * address pr comment * set modelAsString to true for gallery sharing-related enum * update, fix merge * remove duplicate entry * shared gallery, change id to identifier.uniqueId * fix typo * update, remove x-ms-azure-resource for shared gallery * change name of Permissions to avoid SDK code build error * update * add new line * correct reset * update * save * update * fix * update * update * update * resolve CI error * update * Edge zone (#17097) * added target extended locations to the caps gallery schema and added an example file * fixed a comma * Update readme.md * Rename specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json to specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/examples/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json * Update readme.md * update * address comment * resolve CI Co-authored-by: Andrew Sager <asager@microsoft.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> * save (#17600) Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Andrew Sager <asager@microsoft.com>

* Feature/cplat 2021 10 03 (Azure#16512) * update new api version branch with base * change 2021-10-03 to 2021-10-01 * Update readme.md * fix folder structure * add community gallery * Feature/cplat 2021 10 03 (Azure#16512) * update new api version branch with base * change 2021-10-03 to 2021-10-01 * Update readme.md * fix folder structure * add community gallery * remove sharedGallery and communityGallery * Gallery 10-01 change (community gallery, CVM) (Azure#16824) * add new api version 2020-09-30 for gallery.json * add support for api change, sharing profile related * update, change post to patch * fix model validation error * fix typo * add shared gallery api * update * fix typo * update * update * update * chagne new api version to preview * update readme.md and nit * remove some required field and make groups readonly * add swagger support for Grace's and Tim's work * error fix * error fix * change api version name to 2020-09-30 withour 'preview' * update * fix typo * address pr comment * set modelAsString to true for gallery sharing-related enum * update, fix merge * remove duplicate entry * shared gallery, change id to identifier.uniqueId * fix typo * update, remove x-ms-azure-resource for shared gallery * change name of Permissions to avoid SDK code build error * update * add new line * correct reset * update * save * update * fix * update * update * update * resolve CI error * update * Edge zone (Azure#17097) * added target extended locations to the caps gallery schema and added an example file * fixed a comma * Update readme.md * Rename specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json to specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/examples/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json * Update readme.md * update * address comment * resolve CI Co-authored-by: Andrew Sager <asager@microsoft.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> * save (Azure#17600) Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Andrew Sager <asager@microsoft.com>

kangsun-ctrl and others added 30 commits August 13, 2020 17:28

add new api version 2020-09-30 for gallery.json

d486942

add support for api change, sharing profile related

9e5b055

update, change post to patch

9b6d3b7

fix model validation error

ce522c0

fix typo

b9cb068

add shared gallery api

91e2ebf

update

c7bd944

fix typo

df04728

update

3984a1b

update

1511e27

update

6387f21

chagne new api version to preview

102e7e6

update readme.md and nit

02ee910

remove some required field and make groups readonly

d7dd703

add swagger support for Grace's and Tim's work

d06a615

error fix

33ac934

error fix

d7caf62

change api version name to 2020-09-30 withour 'preview'

b3d26ff

update

9bc78e1

Merge branch 'master' into master

62ac80a

fix typo

eb10543

Merge branch 'master' of https://github.com/kangsun-ctrl/azure-rest-a…

64ed1e5

…pi-specs

address pr comment

b752dbf

set modelAsString to true for gallery sharing-related enum

4ee4346

Merge branch 'master' into master

83ee500

update, fix merge

5cb2d3d

remove duplicate entry

24ba11f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

c5d5e8f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

f300000

shared gallery, change id to identifier.uniqueId

d3f40ca

kangsun-ctrl added 2 commits December 10, 2021 16:25

update

1c44da9

update

9c8cf50

openapi-pipeline-app bot removed the CI-BreakingChange-Go-V2 label Dec 11, 2021

openapi-sdkautomation bot mentioned this pull request Dec 11, 2021

[AutoPR track2_@azure/arm-compute] Gallery 10-01 change (community gallery, CVM) AzureSDKAutomation/azure-sdk-for-js#6840

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Dec 11, 2021

Merge branch 'feature/cplat-2021-10-01' of https://github.com/Azure/a…

e6228b9

…zure-rest-api-specs into gallery-10-01

ghost added the no-recent-activity label Dec 26, 2021

ghost closed this Jan 10, 2022

kangsun-ctrl reopened this Jan 19, 2022

ghost removed the no-recent-activity label Jan 19, 2022

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript and removed CI-BreakingChange-Python-Track2 CI-BreakingChange-Go labels Jan 19, 2022

update

a007ce7

grizzlytheodore approved these changes Jan 26, 2022

View reviewed changes

resolve CI error

fe57c98

grizzlytheodore reviewed Jan 27, 2022

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery.json Outdated Show resolved Hide resolved

update

05bc4a0

grizzlytheodore merged commit aa32a89 into Azure:feature/cplat-2021-10-01 Jan 28, 2022

grizzlytheodore mentioned this pull request Jan 31, 2022

Feature/cplat 2021 10 01 #17548

Merged

25 tasks

grizzlytheodore reviewed Feb 1, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gallery 10-01 change (community gallery, CVM) #16824

Gallery 10-01 change (community gallery, CVM) #16824

kangsun-ctrl commented Nov 19, 2021

ghost commented Dec 26, 2021

ghost commented Jan 10, 2022

grizzlytheodore Feb 1, 2022

Gallery 10-01 change (community gallery, CVM) #16824

Gallery 10-01 change (community gallery, CVM) #16824

Conversation

kangsun-ctrl commented Nov 19, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

ghost commented Dec 26, 2021

ghost commented Jan 10, 2022

grizzlytheodore Feb 1, 2022

Choose a reason for hiding this comment