Adding ReadOnlyDatabase object to Synapse model. #17213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @amirdach Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
|
The nested resource 'DataWarehouseUserActivities' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5687 |
|
The nested resource 'SqlPoolConnectionPolicy' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6626 |
|
The nested resource 'SqlPoolVulnerabilityAssessmentRuleBaseline' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6990 |
|
The nested resource 'DataMaskingPolicy' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L7236 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Synapse/stable/2021-06-01/operations.json#L163 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L191 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L550 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L615 |
|
The schema 'PrivateEndpointConnectionForPrivateLinkHub_ResourceCollectionResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: synapse/common/v1/privateEndpointConnection.json#L339 |
|
The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5416 |
|
The schema 'GeoBackupPolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5434 |
|
The schema 'GeoBackupPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5459 |
|
The schema 'GeoBackupPolicyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5487 |
|
The schema 'TopQueries' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5499 |
|
The schema 'QueryStatistic' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5582 |
|
The schema 'QueryInterval' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5600 |
|
The schema 'QueryMetric' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5625 |
|
The schema 'TopQueriesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5660 |
|
The schema 'ReplicationLinkProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5779 |
|
The schema 'ReplicationLink' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5866 |
|
The schema 'ReplicationLinkListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5891 |
|
The schema 'TransparentDataEncryptionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6024 |
|
The schema 'TransparentDataEncryption' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6040 |
|
The schema 'SqlPoolUsage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6287 |
|
The schema 'SqlPoolUsageListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L6330 |
|
The schema 'DataMaskingPolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L7202 |
|
The schema 'DataMaskingPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L7236 |
|
The schema 'DataMaskingRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L7367 |
|
The schema 'DataMaskingRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L7392 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
ghost
added
the
Swagger Generation Artifacts
|
|
Hi @amirdach, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 4, 2022
docohe
approved these changes
Jan 6, 2022
wonner
approved these changes
Jan 6, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ruowan
approved these changes
Jan 7, 2022
msyyc
reviewed
Jan 7, 2022
specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/sqlPool.json
Show resolved
Hide resolved
ruowan
approved these changes
Jan 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 7, 2022
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Adding ReadOnlyDatabase object to Synapse model. * Adding type:object to ReadOnlyDatabase and to its properties. * fix python pipeline failure * fix python pipeline failure Co-authored-by: Amir Dachabash <adachabash@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
This PR updates an existing API version and adds a missing object.
It adds ReadOnlyDatabase (and its properties object) to the Synapse model which is similar to the ReadOnlyDatabase in Kusto model.