Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[DO NOT MERGE ] Introduce new scanners resource type" #17232

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Revert "[DO NOT MERGE ] Introduce new scanners resource type" #17232

merged 1 commit into from
Jan 11, 2022

Conversation

ruowan
Copy link
Member

@ruowan ruowan commented Jan 5, 2022

Reverts #17107

@openapi-workflow-bot
Copy link

Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Security/scanners' removed or restructured?
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L37:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/scanners' removed or restructured?
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L76:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/scanners/{scannerName}' removed or restructured?
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L118:5
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Scanner' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L37:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L244:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L37:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L244:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ScannerName' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L38:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L282:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ScannerBody' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L38:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L282:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupName' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L38:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L282:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionId' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L38:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L282:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersion' removed or renamed?
    New: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L38:3
    Old: Microsoft.Security/preview/2021-12-01-preview/scanners.json#L282:3
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @ruowan ruowan closed this Jan 5, 2022
    @ruowan ruowan reopened this Jan 11, 2022
    @openapi-workflow-bot
    Copy link

    Hi @ruowan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 11, 2022
    This was referenced Jan 11, 2022
    Closed
    Closed
    Closed
    Closed
    @ruowan ruowan merged commit e6a2296 into main Jan 11, 2022
    This was referenced Jan 11, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @ruowan @mstrisoline
    Revert "[DO NOT MERGE ] Introduce new scanners resource type (Azure#1…
    6102627 
    …7107)" (Azure#17232)

This reverts commit 30fca88.
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @ruowan @LeiWang3
    Revert "[DO NOT MERGE ] Introduce new scanners resource type (Azure#1…
    843e2b2 
    …7107)" (Azure#17232)

This reverts commit 30fca88.
    @JackTn JackTn deleted the revert-17107-main branch June 16, 2022 00:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    Assignees

    @ruowan ruowan

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go-V2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @ruowan @raych1