Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview #17252

Merged
merged 17 commits into from
Feb 17, 2022
Merged

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview #17252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a903c75
Adds base for updating Microsoft.SqlVirtualMachine from version previ…
rchlkm Jan 6, 2022
53cd979
Updates readme
rchlkm Jan 6, 2022
e30f1cc
Updates API version in new specs and examples
rchlkm Jan 6, 2022
7399d77
add 2021-11-01 swagger
rchlkm Jan 6, 2022
a1409e7
add missing files, spellcheck, add MAXDOP to custom-words
rchlkm Jan 6, 2022
3456490
prettier check
rchlkm Jan 6, 2022
594e66c
fix model validation errors
rchlkm Jan 6, 2022
8b27a83
fix swagger avocado failures, SDK azure-sdk-for-net failures due to D…
rchlkm Jan 6, 2022
55aa373
add system data to AvailabilityGroupListener, SqlVirtualMachineGroup,…
rchlkm Jan 15, 2022
69cdcb3
update list operation for 2021-11-01
rchlkm Feb 11, 2022
39bb683
add ms-identifier to address lintdiff R4041
rchlkm Feb 11, 2022
0a0308a
remove x-ms-identifiers property as it is not available yet on .net sdk
rchlkm Feb 15, 2022
1c0ff3d
add SqlVirtualMachines_StartAssessment
rchlkm Feb 15, 2022
2eaacc8
update ResourceIdentity enum from IdentityTypeWithNone to IdentityType
rchlkm Feb 15, 2022
a64f356
update list operations json
rchlkm Feb 15, 2022
5961ab2
prettier check
rchlkm Feb 16, 2022
ef8d3ea
re-add ms-identifier to address lintdiff R4041
rchlkm Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,6 +1180,7 @@ marketplacecatalog
marketplaceordering
maxclients
maxcoordinates
MAXDOP
MAXERRORS
maxfragmentationmemory
maximumblobsize
Expand Down
77 changes: 77 additions & 0 deletions ...lMachine/preview/2021-11-01-preview/examples/CreateOrUpdateAvailabilityGroupListener.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"availabilityGroupListenerName": "agl-test",
"api-version": "2021-11-01-preview",
"parameters": {
"properties": {
"availabilityGroupName": "ag-test",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"loadBalancerResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb-test",
"probePort": 59983,
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "Updating",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.113",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
}
}
}
96 changes: 96 additions & 0 deletions ...iew/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineAutomatedBackupWeekly.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineName": "testvm",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"properties": {
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full",
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"serverConfigurationsManagementSettings": {
"sqlConnectivityUpdateSettings": {
"connectivityType": "PRIVATE",
"port": 1433,
"sqlAuthUpdateUserName": "sqllogin",
"sqlAuthUpdatePassword": "<password>"
},
"sqlStorageUpdateSettings": {
"diskCount": 1,
"startingDeviceId": 2,
"diskConfigurationType": "NEW"
},
"sqlWorkloadTypeUpdateSettings": {
"sqlWorkloadType": "OLTP"
},
"additionalFeaturesServerConfigurations": {
"isRServicesEnabled": false
}
},
"keyVaultCredentialSettings": {
"enable": false
},
"autoPatchingSettings": {
"enable": true,
"dayOfWeek": "Sunday",
"maintenanceWindowStartingHour": 2,
"maintenanceWindowDuration": 60
},
"autoBackupSettings": {
"enable": true,
"retentionPeriod": 17,
"enableEncryption": true,
"password": "<Password>",
"backupScheduleType": "Manual",
"backupSystemDbs": true,
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
"storageContainerName": "testcontainer",
"storageAccessKey": "<primary storage access key>",
"fullBackupFrequency": "Weekly",
"daysOfWeek": [
"Monday",
"Friday"
],
"fullBackupStartTime": 6,
"fullBackupWindowHours": 11,
"logBackupFrequency": 10
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Updating",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
},
"201": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Provisioning",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Unknown",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
}
}
}
67 changes: 67 additions & 0 deletions ...tualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"properties": {
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"domainFqdn": "testdomain.com",
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
"clusterBootstrapAccount": "testrpadmin",
"clusterOperatorAccount": "testrp@testdomain.com",
"sqlServiceAccount": "sqlservice@testdomain.com",
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
"storageAccountPrimaryKey": "<primary storage access key>"
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "UpdatingDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "ProvisioningDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
}
}
}
110 changes: 110 additions & 0 deletions ...irtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineMAX.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineName": "testvm",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"properties": {
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full",
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"serverConfigurationsManagementSettings": {
"sqlConnectivityUpdateSettings": {
"connectivityType": "PRIVATE",
"port": 1433,
"sqlAuthUpdateUserName": "sqllogin",
"sqlAuthUpdatePassword": "<password>"
},
"sqlStorageUpdateSettings": {
"diskCount": 1,
"startingDeviceId": 2,
"diskConfigurationType": "NEW"
},
"sqlWorkloadTypeUpdateSettings": {
"sqlWorkloadType": "OLTP"
},
"additionalFeaturesServerConfigurations": {
"isRServicesEnabled": false
},
"sqlInstanceSettings": {
"collation": "SQL_Latin1_General_CP1_CI_AS",
"maxDop": 8,
"isOptimizeForAdHocWorkloadsEnabled": true,
"minServerMemoryMB": 0,
"maxServerMemoryMB": 128
}
},
"keyVaultCredentialSettings": {
"enable": false
},
"autoPatchingSettings": {
"enable": true,
"dayOfWeek": "Sunday",
"maintenanceWindowStartingHour": 2,
"maintenanceWindowDuration": 60
},
"autoBackupSettings": {
"enable": true,
"retentionPeriod": 17,
"enableEncryption": true,
"password": "<Password>",
"backupScheduleType": "Manual",
"backupSystemDbs": true,
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
"storageContainerName": "testcontainer",
"storageAccessKey": "<primary storage access key>",
"fullBackupFrequency": "Daily",
"fullBackupStartTime": 6,
"fullBackupWindowHours": 11,
"logBackupFrequency": 10
},
"assessmentSettings": {
"enable": true,
"runImmediately": true,
"schedule": {
"enable": true,
"weeklyInterval": 1,
"monthlyOccurrence": null,
"dayOfWeek": "Sunday",
"startTime": "23:17"
}
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Updating",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
},
"201": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Provisioning",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Unknown",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
}
}
}
Loading