Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the incorrect description of a field #17262

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Fixing the incorrect description of a field #17262

merged 2 commits into from
Jan 13, 2022

Conversation

anantshankar17
Copy link
Contributor

@anantshankar17 anantshankar17 commented Jan 6, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: updating incorrect description of the input format for a field.

  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    Already deployed.

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    already published.

  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • [ x] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @anantshankar17 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L166
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L364
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L617
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L876
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L166
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L364
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L614
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L873
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Clusters_ListByResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L241
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Clusters_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L281
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L318
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_GetByEnvironment' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L361
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L407
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_ListByEnvironment' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L447
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ApplicationTypes_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L183
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ApplicationTypeVersions_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L381
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Applications_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L634
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Services_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L893
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Clusters_ListByResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L241
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Clusters_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L281
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L318
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_GetByEnvironment' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L361
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L407
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ClusterVersions_ListByEnvironment' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L447
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ApplicationTypes_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L183
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ApplicationTypeVersions_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L381
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Applications_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L631
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Services_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/application.json#L890
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listupgradableversions' in:'ListUpgradableVersions_Post'. Consider updating the operationId
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L491
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2020-12-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L6
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armservicefabric - 0.2.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-servicefabric - 2.0.0
    ️✔️azure-sdk-for-go - servicefabric/mgmt/2021-06-01/servicefabric - v61.1.0
    ️✔️azure-sdk-for-go - servicefabric/mgmt/2019-03-01/servicefabric - v61.1.0
    ️✔️azure-sdk-for-go - servicefabric/mgmt/2016-09-01/servicefabric - v61.1.0
    ️✔️azure-sdk-for-go - preview/servicefabric/mgmt/2019-03-01-preview/servicefabric - v61.1.0
    ️✔️azure-sdk-for-go - preview/servicefabric/mgmt/2018-02-01-preview/servicefabric - v61.1.0
    ️✔️azure-sdk-for-go - preview/servicefabric/mgmt/2017-07-01-preview/servicefabric - v61.1.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 8e47463. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabric/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.ServiceFabric [View full logs]  [Release SDK Changes] 
      cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Tests/ManagedClusters/ServiceFabricManagedTestBase.cs(41,19): error CS0246: The type or namespace name 'ManagedCluster' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Microsoft.Azure.Management.ServiceFabric.Test.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Tests/ManagedClusters/ServiceFabricManagedTestBase.cs(78,19): error CS0246: The type or namespace name 'NodeType' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Microsoft.Azure.Management.ServiceFabric.Test.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Tests/ManagedClusters/ServiceFabricManagedTestBase.cs(41,19): error CS0246: The type or namespace name 'ManagedCluster' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Microsoft.Azure.Management.ServiceFabric.Test.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Tests/ManagedClusters/ServiceFabricManagedTestBase.cs(78,19): error CS0246: The type or namespace name 'NodeType' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/tests/Microsoft.Azure.Management.ServiceFabric.Test.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8e47463. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicefabric [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8e47463. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-01-13 02:28:53 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-servicefabric;1.0.0-beta.2;1.0.0-beta.3"
cmderr	[generate.py] 2022-01-13 02:28:53 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
cmderr	[generate.py] 2022-01-13 02:28:53 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.44 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/servicefabric/azure-resourcemanager-servicefabric --java.namespace=com.azure.resourcemanager.servicefabric   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/servicefabric/resource-manager/readme.md
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-servicefabric
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Skip] pom already has module azure-resourcemanager-servicefabric
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Skip] pom already has module sdk/servicefabric
cmderr	[generate.py] 2022-01-13 02:29:23 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-servicefabric [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2022-01-13 02:31:18 DEBUG Got artifact_id: azure-resourcemanager-servicefabric
cmderr	[Inst] 2022-01-13 02:31:18 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-01-13 02:31:18 DEBUG Got artifact: azure-resourcemanager-servicefabric-1.0.0-beta.3-javadoc.jar
cmderr	[Inst] 2022-01-13 02:31:18 DEBUG Got artifact: azure-resourcemanager-servicefabric-1.0.0-beta.3.jar
cmderr	[Inst] 2022-01-13 02:31:18 DEBUG Match jar package: azure-resourcemanager-servicefabric-1.0.0-beta.3.jar
cmderr	[Inst] 2022-01-13 02:31:18 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17262/azure-sdk-for-java/azure-resourcemanager-servicefabric/azure-resourcemanager-servicefabric-1.0.0-beta.3.jar\" -o azure-resourcemanager-servicefabric-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-servicefabric -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-servicefabric-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8e47463. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️servicefabric/mgmt/2021-06-01/servicefabric [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️servicefabric/mgmt/2019-03-01/servicefabric [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️servicefabric/mgmt/2016-09-01/servicefabric [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/servicefabric/mgmt/2019-03-01-preview/servicefabric [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/servicefabric/mgmt/2018-02-01-preview/servicefabric [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/servicefabric/mgmt/2017-07-01-preview/servicefabric [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8e47463. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armservicefabric [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `ServicesClientDeletePoller`
info	[Changelog] - New struct `ServicesClientDeletePollerResponse`
info	[Changelog] - New struct `ServicesClientDeleteResponse`
info	[Changelog] - New struct `ServicesClientGetOptions`
info	[Changelog] - New struct `ServicesClientGetResponse`
info	[Changelog] - New struct `ServicesClientGetResult`
info	[Changelog] - New struct `ServicesClientListOptions`
info	[Changelog] - New struct `ServicesClientListResponse`
info	[Changelog] - New struct `ServicesClientListResult`
info	[Changelog] - New struct `ServicesClientUpdatePoller`
info	[Changelog] - New struct `ServicesClientUpdatePollerResponse`
info	[Changelog] - New struct `ServicesClientUpdateResponse`
info	[Changelog] - New struct `ServicesClientUpdateResult`
info	[Changelog] - New field `Type` in struct `ApplicationTypeResource`
info	[Changelog] - New field `Location` in struct `ApplicationTypeResource`
info	[Changelog] - New field `Tags` in struct `ApplicationTypeResource`
info	[Changelog] - New field `Etag` in struct `ApplicationTypeResource`
info	[Changelog] - New field `ID` in struct `ApplicationTypeResource`
info	[Changelog] - New field `Name` in struct `ApplicationTypeResource`
info	[Changelog] - New field `SystemData` in struct `ApplicationTypeResource`
info	[Changelog] - New field `CorrelationScheme` in struct `ServiceResourceUpdateProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `ServiceResourceUpdateProperties`
info	[Changelog] - New field `PlacementConstraints` in struct `ServiceResourceUpdateProperties`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `ServiceResourceUpdateProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `ServiceResourceUpdateProperties`
info	[Changelog] - New field `Location` in struct `ApplicationResource`
info	[Changelog] - New field `Etag` in struct `ApplicationResource`
info	[Changelog] - New field `SystemData` in struct `ApplicationResource`
info	[Changelog] - New field `Type` in struct `ApplicationResource`
info	[Changelog] - New field `Tags` in struct `ApplicationResource`
info	[Changelog] - New field `ID` in struct `ApplicationResource`
info	[Changelog] - New field `Name` in struct `ApplicationResource`
info	[Changelog] - New field `Name` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `SystemData` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `Type` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `Location` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `Tags` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `Etag` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `ID` in struct `ServiceResourceUpdate`
info	[Changelog] - New field `PlacementConstraints` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `ServiceKind` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `CorrelationScheme` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `StatefulServiceUpdateProperties`
info	[Changelog] - New field `PartitionScheme` in struct `UniformInt64RangePartitionSchemeDescription`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `ServiceKind` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `CorrelationScheme` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `PlacementConstraints` in struct `StatelessServiceUpdateProperties`
info	[Changelog] - New field `CorrelationScheme` in struct `ServiceResourceProperties`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `ServiceResourceProperties`
info	[Changelog] - New field `PlacementConstraints` in struct `ServiceResourceProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `ServiceResourceProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `ServiceResourceProperties`
info	[Changelog] - New field `PartitionScheme` in struct `NamedPartitionSchemeDescription`
info	[Changelog] - New field `Etag` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `ID` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `Name` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `SystemData` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `Type` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `Location` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `Tags` in struct `ApplicationTypeVersionResource`
info	[Changelog] - New field `Tags` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `Etag` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `ID` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `Name` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `SystemData` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `Type` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `Location` in struct `ApplicationResourceUpdate`
info	[Changelog] - New field `SystemData` in struct `ServiceResource`
info	[Changelog] - New field `Type` in struct `ServiceResource`
info	[Changelog] - New field `Location` in struct `ServiceResource`
info	[Changelog] - New field `Tags` in struct `ServiceResource`
info	[Changelog] - New field `Etag` in struct `ServiceResource`
info	[Changelog] - New field `ID` in struct `ServiceResource`
info	[Changelog] - New field `Name` in struct `ServiceResource`
info	[Changelog] - New field `Name` in struct `Cluster`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `Type` in struct `Cluster`
info	[Changelog] - New field `Location` in struct `Cluster`
info	[Changelog] - New field `Tags` in struct `Cluster`
info	[Changelog] - New field `Etag` in struct `Cluster`
info	[Changelog] - New field `ID` in struct `Cluster`
info	[Changelog] - New field `ServiceTypeName` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ServiceDNSName` in struct `StatefulServiceProperties`
info	[Changelog] - New field `CorrelationScheme` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ProvisioningState` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `StatefulServiceProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ServicePackageActivationMode` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `StatefulServiceProperties`
info	[Changelog] - New field `ServiceKind` in struct `StatefulServiceProperties`
info	[Changelog] - New field `PartitionDescription` in struct `StatefulServiceProperties`
info	[Changelog] - New field `PlacementConstraints` in struct `StatefulServiceProperties`
info	[Changelog] - New field `PartitionScheme` in struct `SingletonPartitionSchemeDescription`
info	[Changelog] - New field `Error` in struct `ErrorModel`
info	[Changelog] - New field `MaximumNodes` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `Parameters` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `MinimumNodes` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `TypeVersion` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `ManagedIdentities` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `Metrics` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `RemoveApplicationCapacity` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `UpgradePolicy` in struct `ApplicationResourceProperties`
info	[Changelog] - New field `ServicePlacementPolicies` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ProvisioningState` in struct `StatelessServiceProperties`
info	[Changelog] - New field `DefaultMoveCost` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ServiceTypeName` in struct `StatelessServiceProperties`
info	[Changelog] - New field `PartitionDescription` in struct `StatelessServiceProperties`
info	[Changelog] - New field `PlacementConstraints` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ServiceDNSName` in struct `StatelessServiceProperties`
info	[Changelog] - New field `CorrelationScheme` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ServiceLoadMetrics` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ServicePackageActivationMode` in struct `StatelessServiceProperties`
info	[Changelog] - New field `ServiceKind` in struct `StatelessServiceProperties`
info	[Changelog]
info	[Changelog] Total 340 breaking change(s), 313 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8e47463. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicefabric [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @anantshankar17, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Jan 6, 2022
    Closed
    Closed
    Closed
    Closed
    @anantshankar17
    Copy link
    Contributor Author

    @samedder: This is pending your review. Can you please take a look ? We need to fix this incorrect description ASAP.

    @anantshankar17
    Copy link
    Contributor Author

    #sign-off

    @ruowan ruowan merged commit 8e47463 into Azure:main Jan 13, 2022
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 13, 2022
    Closed
    This was referenced Jan 13, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @anantshankar17 @mstrisoline
    Fixing the incorrect description of a field (Azure#17262)
    f4ee780 
    * Fixing the incorrect description of a field

* Revrting change for older apis
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @anantshankar17 @LeiWang3
    Fixing the incorrect description of a field (Azure#17262)
    f6b5c6f 
    * Fixing the incorrect description of a field

* Revrting change for older apis
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ruowan ruowan ruowan approved these changes

    @a-santamaria a-santamaria a-santamaria approved these changes

    @samedder samedder Awaiting requested review from samedder samedder is a code owner

    Assignees

    @ruowan ruowan

    Labels
    CI-BreakingChange-Go-V2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @anantshankar17 @a-santamaria @ruowan