-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language API for TA (2022-03-01-preview) #17281
Merged
lmazuel
merged 76 commits into
Azure:dev-cognitiveservices-Language-2022-03-01-preview
from
abhahn:abhahn/language-ta-20220301
Mar 17, 2022
Merged
Changes from 75 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
1bcc20d
Add blockchain to latest profile
markcowl 7b46097
Add additional types
markcowl d141546
WIP for language api spec for TA
45fff3b
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …
382b4ab
Updated preview version number; finished up async definitions
478b59b
Finished first draft of full spec
b9c5551
Finished first draft of full spec, minus FHIR structuring in HC output
5541ae2
Removed features not included in 2021-11-01 preview
054c150
Update custom text tasks TODOs
kayousef 61e358d
Moved common definitions to TA-specific definitions
31e30a8
Added custom text tasks to JobManifest
113da22
Merge branch 'abhahn/language-ta-20211101' of https://github.com/abha…
c2b44e5
Addressing feedback from PR comments and internal review
971c0c9
Addressed some PR comments
6603e9f
Updated some remaining references to documents
9603885
PR comments
00611d6
Updated a previous change
dae7e0c
Reverted references to 'records' back to 'documents'
3dec90a
Fixed merge conflict
ef4ca82
A few small updates to examples; removed base Task type to simplify s…
9de0612
PR comments
37afdf2
Addressed TODO items; removed LD-related objects (will be added in an…
b129a0c
Fixed anonymous types
6589b0e
Removed required field for body in POST request
61c4920
Fix prettier check
341d6c2
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
b2c0887
Added a few more details; experimental change for documents property
b6d9fb1
Ran prettier
b0fbc2e
Correction to AnalysisInput object
191433c
Merged changes from 2021-11-01-preview and moved new changes to 2022-…
225ad44
PR comments
6656695
Updates to the design for tasks
d484571
Fixed merge conflict
4276f71
Added custom entities task to examples
d20e7d2
Fixed merge conflict
d6ae3d5
Fixed merge conflict
87a8b00
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …
e49956a
Merged with changes from 2021-11-01-preview branch
7b86031
Updates
5c8492c
Finished implementation of discriminator pattern and added some exmaples
70703d6
Updates
5c5e55f
Updates to objects, and addressing some PR comments
0c0b3ae
Prettier
c08b59f
Fixed semantic validation errors
6b4471f
Fixed model validation
02eafda
Another model validation fix
9044dc2
Debugging model validation errors
7b7fbf7
Using a different discriminator enum for output schemas
ea89ef1
Fixed some missing discriminator updates
c4cdc3e
More semantic validation fixes
f6b4fff
Fixed model validation errors; updated sample names
83538c0
Fixed linting errors and addressed some warnings in the linter output
5a6374b
Ran prettier on examples
12f8dbe
PR comments and some minor restructuring
2e719a3
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …
b8cb4b6
Ran prettier
bf7d331
Removed a duplicate schema from CustomEntitiesTaskParameters
1ab4845
PR comments
b4b462e
PR comments
b1f3b5c
PR comments
b66d2c9
Added missing job task status 'partiallySucceeded'
0130ca6
Added preview folder for 2022-03-01-preview
5b069f7
Added delete and cancel operations for jobs
40fe511
Added some examples for delete and cancel; updated samples for new pr…
b14982a
Incorporating feedback from the API review
989e24f
fix naming consistency (#1)
mshaban93 6170ff0
Merge branch 'main' of https://github.com/abhahn/azure-rest-api-specs…
cb2c9d5
Fixed merge conflicts with main
b425996
Merge branch 'abhahn/language-ta-20220301' of https://github.com/abha…
64a41e3
Fixed more merge conflicts with the feature branch
cff0d92
Fixed one last merge conflict
d7c4aa2
naming fix (#2)
mshaban93 3605fef
Fixed a ref
5881d12
Merge branch 'abhahn/language-ta-20220301' of https://github.com/abha…
0d53d75
Ran prettier on all files
0643faa
Merge branch 'dev-cognitiveservices-Language-2022-03-01-preview' of h…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
.../Language/preview/2022-03-01-preview/examples/SuccessfulAnalyzeTextJobsCancelRequest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"parameters": { | ||
"Ocp-Apim-Subscription-Key": "{API key}", | ||
"ApiVersion": "2022-03-01-preview", | ||
"Endpoint": "{Endpoint}", | ||
"jobId": "c0f2a446-05d9-48fc-ba8f-3ef4af8d0b18" | ||
}, | ||
"responses": { | ||
"202": { | ||
"headers": { | ||
"Operation-Location": "{Endpoint}/language/analyze-text/jobs/{jobId}?api-version=2022-03-01-preview" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is what various clients will call this (since
class
is often a reserved/keyword). I don't think I thought about this in the REST API discussion. But we should be able to specifyx-ms-client-name
to rename/quantify the name in client libraries.