[Azure Maps] Fix a typo in Render 1.0 #17290

alankashiwa · 2022-01-10T00:37:31Z

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- Other, please clarify: Fix a typo
When are you targeting to deploy the new service/feature to public regions?
When do you expect to publish the swagger?
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

openapi-workflow-bot · 2022-01-10T00:37:33Z

Hi, @alankashiwa Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2022-01-10T00:37:34Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/1.0/render.json compared with base:preview/1.0/render.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- data-plane/Render/readme.md tag:1.0-preview
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- data-plane/Render/readme.md tag:1.0-preview

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

maps/data-plane/Render/readme.md#1.0-preview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-01-10T00:37:34Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3715b1e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 8.1.2 -> 8.3.0
cmderr	[automation_generate.sh]  Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
cmderr	[automation_generate.sh]  Run `npm install -g npm@8.3.0` to update!
cmderr	[automation_generate.sh]
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 3715b1e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-01-10 16:12:48 INFO [Skip] readme path does not format as specification/*/resource-manager/readme.md
cmderr	[generate.py] 2022-01-10 16:12:48 INFO [GENERATE] Autorest from JSON ../azure-rest-api-specs/specification/maps/data-plane/Render/preview/1.0/render.json
cmderr	[generate.py] 2022-01-10 16:12:48 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.44 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/maps/azure-maps-render --java.namespace=com.azure.maps.render --java --low-level-client --sdk-integration --generate-samples --input-file=../azure-rest-api-specs/specification/maps/data-plane/Render/preview/1.0/render.json --java.credential-types=tokencredential --java.credential-scopes=https://maps.azure.com/.default --artifact-id=azure-maps-render
cmderr	[generate.py] 2022-01-10 16:13:34 INFO [VERSION][Not Found] cannot find version for "com.azure:azure-maps-render"
cmderr	[generate.py] 2022-01-10 16:13:34 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-01-10 16:13:34 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-01-10 16:13:35 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-01-10 16:13:35 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-01-10 16:13:35 INFO [POM][Skip] pom already has module sdk/maps
cmderr	[generate.py] 2022-01-10 16:13:35 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2022-01-10 16:13:35 INFO mvn --no-transfer-progress clean verify package -f /home/vsts/work/1/s/azure-sdk-for-java/pom.xml -pl com.azure:azure-maps-render -am
cmderr	[generate.py] 2022-01-10 16:16:20 ERROR [COMPILE] Maven build fail

️✔️azure-maps-render [View full logs] [Release SDK Changes]

pom.xml

cmderr	[Inst] 2022-01-10 16:16:22 DEBUG Got artifact_id: azure-maps-render
cmderr	[Inst] 2022-01-10 16:16:22 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-01-10 16:16:22 ERROR Unmatch any jar in artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3715b1e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Render/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Azure.Maps.Render [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-01-10T00:37:34Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2022-01-10T00:39:21Z

Hi @alankashiwa, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

fix x-ms-client-name

1df2fab

alankashiwa requested review from tjprescott and kairu-ms January 10, 2022 00:37

alankashiwa self-assigned this Jan 10, 2022

alankashiwa mentioned this pull request Jan 10, 2022

[Azure Maps] Restore operationId for documentation #16742

Merged

8 tasks

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 10, 2022

alankashiwa changed the title ~~[Azure Maps] Fix typos in Render 1.0~~ [Azure Maps] Fix a typo in Render 1.0 Jan 10, 2022

openapi-sdkautomation bot mentioned this pull request Jan 10, 2022

[AutoPR Azure.Maps.Render] [Azure Maps] Fix a typo in Render 1.0 AzureSDKAutomation/azure-sdk-for-net#7041

Closed

tjprescott approved these changes Jan 10, 2022

View reviewed changes

tjprescott merged commit 3715b1e into Azure:main Jan 10, 2022

This was referenced Jan 10, 2022

[ReleasePR Azure.Maps.Render] Fix billing information in Render Azure/azure-sdk-for-net#22740

Closed

[ReleasePR azure-maps-render] Fix billing information in Render Azure/azure-sdk-for-java#26384

Closed

mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022

fix x-ms-client-name (Azure#17290)

d76b4b0

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022

fix x-ms-client-name (Azure#17290)

ae16bbf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Azure Maps] Fix a typo in Render 1.0 #17290

[Azure Maps] Fix a typo in Render 1.0 #17290

alankashiwa commented Jan 10, 2022

openapi-workflow-bot bot commented Jan 10, 2022

openapi-pipeline-app bot commented Jan 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 10, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jan 10, 2022

openapi-workflow-bot bot commented Jan 10, 2022

[Azure Maps] Fix a typo in Render 1.0 #17290

[Azure Maps] Fix a typo in Render 1.0 #17290

Conversation

alankashiwa commented Jan 10, 2022

Changelog

Contribution checklist:

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 10, 2022

openapi-pipeline-app bot commented Jan 10, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 10, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jan 10, 2022

openapi-workflow-bot bot commented Jan 10, 2022

openapi-pipeline-app bot commented Jan 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 10, 2022 •

edited

Loading