[Storage] move CloudError to common.json to resolve the duplicate schema issue
#17336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/ListAccountSas' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L635 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/ListServiceSas' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L680 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/blobServices/{BlobServicesName}' Location: Microsoft.Storage/stable/2021-08-01/blob.json#L58 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/fileServices/{FileServicesName}' Location: Microsoft.Storage/stable/2021-08-01/file.json#L61 |
|
The response of operation:'BlobContainers_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/blob.json#L320 |
|
The response of operation:'BlobContainers_GetImmutabilityPolicy' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/blob.json#L562 |
|
The response of operation:'FileShares_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/file.json#L362 |
|
The response of operation:'Queue_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/queue.json#L266 |
|
The response of operation:'Table_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/table.json#L245 |
|
The response of operation:'BlobContainers_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/blob.json#L215 |
|
The response of operation:'BlobContainers_CreateOrUpdateImmutabilityPolicy' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/blob.json#L498 |
|
The response of operation:'FileShares_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/file.json#L235 |
|
The response of operation:'Queue_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/queue.json#L159 |
|
The response of operation:'Table_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/table.json#L159 |
|
The response of operation:'BlobContainers_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/blob.json#L273 |
|
The response of operation:'FileShares_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/file.json#L306 |
|
The response of operation:'Queue_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/queue.json#L214 |
|
The response of operation:'Table_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-08-01/table.json#L202 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L36 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L69 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L111 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L180 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L218 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L270 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L334 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L449 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L485 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L537 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L585 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-08-01/storage.json#L622 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Jan 13, 2022
tadelesh
approved these changes
Jan 13, 2022
|
@priyapansrp , @HimanshuChhabra |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM |
This was referenced Jan 21, 2022
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
…chema issue (Azure#17336) * move cloud error to common.json * remove definition of Clouderror
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…chema issue (Azure#17336) * move cloud error to common.json * remove definition of Clouderror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.