Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation - Fix Client Name #17475

Closed

Conversation

royrein
Copy link
Contributor

@royrein royrein commented Jan 24, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

joshdmcc and others added 30 commits December 9, 2021 10:15
* Adding swagger for version 2020-12-01

* Reverting new version

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2018-10-01 to version 2018-04-02

* Updates readme

* Updates API version in new specs and examples

* Swagger for 2018-04-02

* Updating readme

* Adding new versions to readme

* ???

* Small json change to rebuild

Co-authored-by: jmccarthy <jmccarthy@microsoft.com>
* [Go] Track2 modify readme.go.md 9

* fix
* [Go] track2 modify readme.go.md 10

* add go batch tag multiapi

* version to version_with_hyphens

* remove videoindexer

* fix

* output-folder add mgmt
…-03-01 (Azure#16882)

* fix api

* add name property

* update OP Channels_ListWithKeys

* update type

* mark the parameter value as x-ms-secret

* allow null in value

* '

* sync changes to 2021-05-01-preview

Co-authored-by: FAREAST\hond <hond@microsoft.com>
* [Go] Add other resources module name

* fix
* update api name

* add x-ms-client-name to fix the generated sdk method name

* fix prettier fail

* add Search category to geocoding apis

* remove preview in the operationId and add it to description
* add x-ms-enum for sql

* fix to make sure track 1 generator is happy
…5496)

* Adds base for updating Microsoft.Migrate from version stable/2021-01-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Added systemData property in Move Collection & Move Resource object

* Update resourcemovercollection.json

Added Tags and User-Managed Identities Properties

* Update resourcemovercollection.json

Made changes for removing tags property for document resources and resource group.

* Removed additional empty line

* Swagger PrettierCheck

* Updating examples for 2021-08-01 version.

* CI Fix

Co-authored-by: Anany Shah <anashah@microsoft.com>
Co-authored-by: yashjain4 <87814230+yashjain4@users.noreply.github.com>
…perties (Azure#17042)

* Added group IDs array to PrivateEndpointConnection in v4 common type

* Added private endpoint connections to the top level resource

* Updated examples

* Added types.json to commopn-types/v4

* Moved new version of privatelinks.json into our directory

* Wrong level

* Added period to the end of description for consistency

* Updated version in privatelinks.json

* Removed duplicate resource from privatelinks.json

* Made PrivateEndpointConnection.properties required, added PEC payload to examples

* Added Operations List example

* Referenced Operations example file from the swagger

* Reduce number of operations in the Operations_List example

* Fixed Operations List example

* Removed PrivateEnpointConnection from Account update example
…ure#16715)

* Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added support for GraphQL API type (Azure#14851)

* Added support for GraphQL API type

* Added missing enum value for GraphQL APIs.

* add schema definition fix from 2021-01-01-preview (Azure#14883)

Co-authored-by: Alan Feng <alanfeng@microsoft.com>

* Vanguard: Get Outbound Network Dependency (Azure#14900)

* outbound dependency

* fix resource

* Update backup/restore API for managed identities (Azure#14973)

* Update backup/restore API for system-assigned and user-assigned identities

* Fix formatting issue

* Rename user-assigned-msi-client-id with client-id

* SystemData implemenation on API Management Control Plane (Azure#14899)

* system-data

* fix spec

* remove unreferenced file

* APIM - Network Watcher Connectivity Check integration specs (Azure#15056)

* Connectivity Check API Specs

* Fix

* Fix errors

* style fixs

* Fix 202 code

* HTTPConnect request parameters

* Fix errors

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Parameter examples added (Azure#14836)

* platformversion (Azure#15114)

* fix update service (Azure#15478)

* HttpConnect example (Azure#15493)

* HttpConnect example

* Prettifier fix

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Rename from SchemaContract to ApiSchemaContract

* apimschema.json added to last apim preview version

* Completing specification for Schema resource.
Fixing changes in SchemaContract.

* Value field added to Schema resource specification.

* path fixed.
Renamed from ApiSchema to Schema.
Adding suppression rule to readme.md
Custom word added for spellcheck

* Fixing PR observations.

* Added properties of difference API spec format for "SchemaDocumentProperties" (Azure#15703)

* add schema definition fix from 2021-01-01-preview

* added properties for SchemaDocumentProperties

* updated the fix

* updated fix

* [APIM]Add private endpoint connection APIs (Azure#15115)

* Add private endpoint connection apis

* add readme

* quick fixes

* fix to PE contract

* Small fixes

* small fixes

* small fixes

* Small fixes

* small fixes

* small fix

* small fixes

* small fixes

* small fixes

* Update readme.md

* fix error

* small fix

* fix format

* address comments

* small fixes

* Change to lower case

* small fixes

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* Adds base for updating Microsoft.ApiManagement from version preview/2021-04-01-preview to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Merge main

* Modifications to Schema definition to add "description" field.
Updating examples of Schema.

* Fixing apimanagement.json

* Prettier applied in files

* Fixing PR comments

* fixing x-ms-long-running-operation.

* x-ms-long-running-operation : true in apischema.

* Removing "Resource" type from apimanagement.json

* Apimschema.json updated to point to types.json for ErrorResponse.

* Merging from 2021-04-01-preview to 2021-08-01 stable version.

* undoing change of responseBody

* Updating ErrorResponse.

* Fixing definitions merge.

* Changing definitions to fix output of examples.

* Changes in definitions

* Updating response in some examples.

* Rolling back
ApiSchema -> Schema
Schema -> GlobalSchema

* Changes to undo apimapis.json and adding prefix for Global example Schemas.

* Setting x-ms-long-running-operation-options to location.

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com>
Co-authored-by: DreamlessA <DreamlessA@users.noreply.github.com>
Co-authored-by: Alan Feng <alanfeng@microsoft.com>
Co-authored-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
Co-authored-by: Nicolás Barrera <nicolasbarrera@outlook.com>
Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>
Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com>
Co-authored-by: Christian Palomares <cpalomar@microsoft.com>
Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
…le (Azure#16906)

* [Azure SignalR Service]changes introduced by new version of Swashbuckle

* add back default value

* revert parameter orders

* Update settings.json
* Adding UAMI properties to the swagger

* Update readme.go.md

* fixing invalid exmaples of uuid

* Update readme.go.md

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
…view (Azure#16963)

* Add swagger for new API version

* Add new API version to autorest config

* Relax parameter by removing enum restriction

* Fix Go and Python config

* Add config for Java SDK

* Fix spacing

* Add back enum value
* fix

* make these two sealed enums
* Revert namespace list keys

* Changing results to proper type
…ble/2021-06-01 (Azure#15828)

* Adds base for updating Microsoft.Cache from version stable/2020-12-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* Adding managed identities param

* lint correction

* Introduce common-types definitions useful for services that support ManagedIdentity.

* Refactor latest redis.json to be the first usage of the new ManagedServiceIdentity definition from common-types.

* Fix spellCheck failures

* Fix model, redis service identity should be modeled as updatable.

* modifying example response

* ManagedServiceIdentityType should be modeled as string for extensibility.

* Add commontypes/resource-management/v3/managedidentity which models managed identity for services supporting both SystemAssignedIdentity and UserAssignedIdentity.

* fixing ROUNDTRIP_ADDITIONAL_PROPERTY s360 issue

* redisConfiguration changes, Add Identity to resp

* Fixing swagger lintdiff error

* Add a canonical SystemAssignedServiceIdentityType type definition which supports 'None', since that is required going forward. Also make the 'type' property required, since omitting it from the request would not be clear in intent.

* adding back additional properties

* prettier fix

* Add principalId and tenantId.

* Update patch responses to include 202 when requests are longrunning

* Adding swagger issue fixes made in last version

* adding space in System&UserAssigned identity type

* revert 78a8a87

* updating managedidentity type version

* adding example for 202 status code

* reverting 202 status code addition

Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com>
Co-authored-by: Tim Lovell-Smith <tilovell@microsoft.com>
Co-authored-by: Chantal Olieman <choliema@microsoft.com>
* add x-ms-enum to storage

* add name

* fix again

* change one parameter name back to see if it breaks

* change the parameter name back
This was referenced Jan 24, 2022
@royrein royrein closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.