Adding xms-ids for Botservice #17617

agalerrotaru · 2022-02-02T04:50:45Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-02T04:50:47Z

Hi, @agalerrotaru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2022-02-02T04:50:47Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-workflow-bot · 2022-02-02T04:50:48Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-02T04:50:48Z

Swagger pipeline can not start as the pull request has merge conflicts.

ghost · 2022-02-02T04:50:50Z

Thank you for your contribution agalerrotaru! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2022-02-02T04:53:29Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-03-01/botservice.json compared with base:stable/2021-03-01/botservice.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- botservice/resource-manager/readme.md tag:package-2021-03-01
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- botservice/resource-manager/readme.md tag:package-2021-03-01

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L742
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1147
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1200
`❌` R4037 - MissingTypeObject	The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1267
`❌` R4037 - MissingTypeObject	The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1452
`❌` R4037 - MissingTypeObject	The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1609
`❌` R4037 - MissingTypeObject	The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1652
`❌` R4037 - MissingTypeObject	The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1692
`❌` R4037 - MissingTypeObject	The schema 'EmailChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1725
`❌` R4037 - MissingTypeObject	The schema 'MsTeamsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1762
`❌` R4037 - MissingTypeObject	The schema 'SkypeChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1812
`❌` R4037 - MissingTypeObject	The schema 'KikChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1876
`❌` R4037 - MissingTypeObject	The schema 'WebChatChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1917
`❌` R4037 - MissingTypeObject	The schema 'DirectLineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1956
`❌` R4037 - MissingTypeObject	The schema 'TelegramChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1991
`❌` R4037 - MissingTypeObject	The schema 'SmsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2028
`❌` R4037 - MissingTypeObject	The schema 'SlackChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2075
`❌` R4037 - MissingTypeObject	The schema 'LineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2146
`❌` R4037 - MissingTypeObject	The schema 'LineRegistration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2174
`❌` R4037 - MissingTypeObject	The schema 'DirectLineSpeechChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2213
`❌` R4037 - MissingTypeObject	The schema 'ChannelResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2247
`❌` R4037 - MissingTypeObject	The schema 'WebChatSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2264
`❌` R4037 - MissingTypeObject	The schema 'DirectLineSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2311
`❌` R4037 - MissingTypeObject	The schema 'ConnectionItemName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2426
`❌` R4037 - MissingTypeObject	The schema 'ConnectionSettingParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2436
`❌` R4037 - MissingTypeObject	The schema 'ConnectionSettingProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2450
`❌` R4037 - MissingTypeObject	The schema 'ConnectionSettingResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2518
`❌` R4037 - MissingTypeObject	The schema 'ServiceProviderResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2535
`❌` R4037 - MissingTypeObject	The schema 'ServiceProviderParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2555
`❌` R4037 - MissingTypeObject	The schema 'ServiceProviderProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L2607

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️❌CredScan: 0 Errors, 0 Warnings failed [Detail]

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

botservice/resource-manager/readme.md#package-2021-03-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-02T04:53:30Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armbotservice - 0.3.0

+	Struct `ConnectionItemName` has been removed
+	Struct `ErrorBody` has been removed
+	Struct `Error` has been removed
+	Type of `OperationEntity.Properties` has been changed from `map[string]interface{}` to `interface{}`

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-botservice - 2.0.0b1
❌azure-sdk-for-go - botservice/mgmt/2021-03-01/botservice - v61.4.0

+	Field `EnablePreview` of struct `WebChatSite` has been removed
+	Field `IsIsolated` of struct `BotProperties` has been removed
+	Function `ChannelsClient.ListWithKeysResponder` return value(s) have been changed from `(BotChannel, error)` to `(ListChannelWithKeysResponse, error)`
+	Function `ChannelsClient.ListWithKeys` return value(s) have been changed from `(BotChannel, error)` to `(ListChannelWithKeysResponse, error)`

️✔️azure-sdk-for-go - preview/botservice/mgmt/2021-05-01-preview/botservice - v61.4.0
️✔️azure-sdk-for-go - preview/botservice/mgmt/2018-07-12/botservice - v61.4.0
️✔️azure-sdk-for-go - preview/botservice/mgmt/2017-12-01/botservice - v61.4.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.BotService [View full logs] [Release SDK Changes]

cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.1 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm  Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DirectLineSpeechChannel has a new parameter location
info	[Changelog]   - Model DirectLineSpeechChannel has a new parameter provisioning_state
info	[Changelog]   - Model DirectLineSpeechChannel has a new parameter etag
info	[Changelog]   - Model Channel has a new parameter location
info	[Changelog]   - Model Channel has a new parameter provisioning_state
info	[Changelog]   - Model Channel has a new parameter etag
info	[Changelog]   - Model EmailChannel has a new parameter location
info	[Changelog]   - Model EmailChannel has a new parameter provisioning_state
info	[Changelog]   - Model EmailChannel has a new parameter etag
info	[Changelog]   - Model FacebookChannel has a new parameter location
info	[Changelog]   - Model FacebookChannel has a new parameter provisioning_state
info	[Changelog]   - Model FacebookChannel has a new parameter etag
info	[Changelog]   - Model LineChannel has a new parameter location
info	[Changelog]   - Model LineChannel has a new parameter provisioning_state
info	[Changelog]   - Model LineChannel has a new parameter etag
info	[Changelog]   - Model DirectLineChannel has a new parameter location
info	[Changelog]   - Model DirectLineChannel has a new parameter provisioning_state
info	[Changelog]   - Model DirectLineChannel has a new parameter etag
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter provisioning_state
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter id
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter name
info	[Changelog]   - Model AlexaChannel has a new parameter location
info	[Changelog]   - Model AlexaChannel has a new parameter provisioning_state
info	[Changelog]   - Model AlexaChannel has a new parameter etag
info	[Changelog]   - Model DirectLineSite has a new parameter is_block_user_upload_enabled
info	[Changelog]   - Model BotChannel has a new parameter zones
info	[Changelog]   - Model Resource has a new parameter zones
info	[Changelog]   - Model TelegramChannel has a new parameter location
info	[Changelog]   - Model TelegramChannel has a new parameter provisioning_state
info	[Changelog]   - Model TelegramChannel has a new parameter etag
info	[Changelog]   - Model ServiceProviderParameter has a new parameter metadata
info	[Changelog]   - Model BotProperties has a new parameter open_with_hint
info	[Changelog]   - Model BotProperties has a new parameter cmek_encryption_status
info	[Changelog]   - Model BotProperties has a new parameter is_streaming_supported
info	[Changelog]   - Model BotProperties has a new parameter msa_app_type
info	[Changelog]   - Model BotProperties has a new parameter manifest_url
info	[Changelog]   - Model BotProperties has a new parameter migration_token
info	[Changelog]   - Model BotProperties has a new parameter msa_app_tenant_id
info	[Changelog]   - Model BotProperties has a new parameter app_password_hint
info	[Changelog]   - Model BotProperties has a new parameter disable_local_auth
info	[Changelog]   - Model BotProperties has a new parameter all_settings
info	[Changelog]   - Model BotProperties has a new parameter storage_resource_id
info	[Changelog]   - Model BotProperties has a new parameter provisioning_state
info	[Changelog]   - Model BotProperties has a new parameter private_endpoint_connections
info	[Changelog]   - Model BotProperties has a new parameter parameters
info	[Changelog]   - Model BotProperties has a new parameter msa_app_msi_resource_id
info	[Changelog]   - Model BotProperties has a new parameter public_network_access
info	[Changelog]   - Model BotProperties has a new parameter schema_transformation_version
info	[Changelog]   - Model BotProperties has a new parameter is_developer_app_insights_api_key_set
info	[Changelog]   - Model BotProperties has a new parameter publishing_credentials
info	[Changelog]   - Model ConnectionSetting has a new parameter zones
info	[Changelog]   - Model SmsChannel has a new parameter location
info	[Changelog]   - Model SmsChannel has a new parameter provisioning_state
info	[Changelog]   - Model SmsChannel has a new parameter etag
info	[Changelog]   - Model SkypeChannel has a new parameter location
info	[Changelog]   - Model SkypeChannel has a new parameter provisioning_state
info	[Changelog]   - Model SkypeChannel has a new parameter etag
info	[Changelog]   - Model SlackChannel has a new parameter location
info	[Changelog]   - Model SlackChannel has a new parameter provisioning_state
info	[Changelog]   - Model SlackChannel has a new parameter etag
info	[Changelog]   - Model SkypeChannelProperties has a new parameter incoming_call_route
info	[Changelog]   - Model MsTeamsChannelProperties has a new parameter accepted_terms
info	[Changelog]   - Model MsTeamsChannelProperties has a new parameter deployment_environment
info	[Changelog]   - Model MsTeamsChannelProperties has a new parameter incoming_call_route
info	[Changelog]   - Model KikChannel has a new parameter location
info	[Changelog]   - Model KikChannel has a new parameter provisioning_state
info	[Changelog]   - Model KikChannel has a new parameter etag
info	[Changelog]   - Model SlackChannelProperties has a new parameter scopes
info	[Changelog]   - Model Bot has a new parameter zones
info	[Changelog]   - Model WebChatChannel has a new parameter location
info	[Changelog]   - Model WebChatChannel has a new parameter provisioning_state
info	[Changelog]   - Model WebChatChannel has a new parameter etag
info	[Changelog]   - Model MsTeamsChannel has a new parameter location
info	[Changelog]   - Model MsTeamsChannel has a new parameter provisioning_state
info	[Changelog]   - Model MsTeamsChannel has a new parameter etag
info	[Changelog]   - Model DirectLineChannelProperties has a new parameter direct_line_embed_code
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group HostSettingsOperations
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group OperationResultsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
info	[Changelog]   - Model WebChatSite no longer has parameter enable_preview
info	[Changelog]   - Model WebChatSite has a new required parameter is_webchat_preview_enabled

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ListChannelWithKeysResponse has a new parameter changed_time
info	[Changelog]   - Model ListChannelWithKeysResponse has a new parameter entity_tag
info	[Changelog]   - Model ListChannelWithKeysResponse has a new parameter provisioning_state

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️botservice/mgmt/2021-03-01/botservice [View full logs] [Release SDK Changes]

Only show 30 items here, please refer to log for details.

info	[Changelog] - New field `Name` in struct `ConnectionSettingProperties`
info	[Changelog] - New field `Location` in struct `TelegramChannel`
info	[Changelog] - New field `Etag` in struct `TelegramChannel`
info	[Changelog] - New field `ProvisioningState` in struct `TelegramChannel`
info	[Changelog] - New field `Etag` in struct `LineChannel`
info	[Changelog] - New field `ProvisioningState` in struct `LineChannel`
info	[Changelog] - New field `Location` in struct `LineChannel`
info	[Changelog] - New field `IsBlockUserUploadEnabled` in struct `DirectLineSite`
info	[Changelog] - New field `Location` in struct `MsTeamsChannel`
info	[Changelog] - New field `Etag` in struct `MsTeamsChannel`
info	[Changelog] - New field `ProvisioningState` in struct `MsTeamsChannel`
info	[Changelog] - New field `MigrationToken` in struct `BotProperties`
info	[Changelog] - New field `MsaAppMSIResourceID` in struct `BotProperties`
info	[Changelog] - New field `AppPasswordHint` in struct `BotProperties`
info	[Changelog] - New field `StorageResourceID` in struct `BotProperties`
info	[Changelog] - New field `Parameters` in struct `BotProperties`
info	[Changelog] - New field `PublicNetworkAccess` in struct `BotProperties`
info	[Changelog] - New field `ProvisioningState` in struct `BotProperties`
info	[Changelog] - New field `MsaAppType` in struct `BotProperties`
info	[Changelog] - New field `ManifestURL` in struct `BotProperties`
info	[Changelog] - New field `OpenWithHint` in struct `BotProperties`
info	[Changelog] - New field `PublishingCredentials` in struct `BotProperties`
info	[Changelog] - New field `AllSettings` in struct `BotProperties`
info	[Changelog] - New field `MsaAppTenantID` in struct `BotProperties`
info	[Changelog] - New field `IsStreamingSupported` in struct `BotProperties`
info	[Changelog] - New field `DisableLocalAuth` in struct `BotProperties`
info	[Changelog] - New field `IsDeveloperAppInsightsAPIKeySet` in struct `BotProperties`
info	[Changelog] - New field `CmekEncryptionStatus` in struct `BotProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 46 additive change(s).

️✔️preview/botservice/mgmt/2021-05-01-preview/botservice [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `ChangedTime` in struct `ListChannelWithKeysResponse`
info	[Changelog] - New field `ProvisioningState` in struct `ListChannelWithKeysResponse`
info	[Changelog] - New field `EntityTag` in struct `ListChannelWithKeysResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).

️✔️preview/botservice/mgmt/2018-07-12/botservice [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/botservice/mgmt/2017-12-01/botservice [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armbotservice [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `OperationEntity.Properties` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Struct `ConnectionItemName` has been removed
info	[Changelog] - Struct `Error` has been removed
info	[Changelog] - Struct `ErrorBody` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `ChangedTime` in struct `ListChannelWithKeysResponse`
info	[Changelog] - New field `EntityTag` in struct `ListChannelWithKeysResponse`
info	[Changelog] - New field `ProvisioningState` in struct `ListChannelWithKeysResponse`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 1 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 87bd0df. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️botservice [View full logs]

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 87bd0df. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-botservice [View full logs] [Release SDK Changes]
- azure-arm-botservice-4.0.0-beta.3.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

lirenhe · 2022-02-08T09:03:24Z

/azp run

azure-pipelines · 2022-02-08T09:03:34Z

Azure Pipelines successfully started running 1 pipeline(s).

lirenhe · 2022-02-09T04:50:42Z

/azp run

azure-pipelines · 2022-02-09T04:50:51Z

Azure Pipelines successfully started running 1 pipeline(s).

* Adding xms-ids for Botservice * corrections after rebase

Adding xms-ids for Botservice

204e496

openapi-assignment-bot bot assigned lirenhe Feb 2, 2022

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 2, 2022

Merge branch 'main' into agalerrotaru/xms-ids-botservice

509ffe5

openapi-sdkautomation bot mentioned this pull request Feb 2, 2022

[AutoPR azure-mgmt-botservice] Adding xms-ids for Botservice AzureSDKAutomation/azure-sdk-for-python#8893

Closed

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Go-V2 labels Feb 2, 2022

corrections after rebase

2ffa5f3

agalerrotaru closed this Feb 9, 2022

agalerrotaru reopened this Feb 9, 2022

lirenhe approved these changes Feb 9, 2022

View reviewed changes

lirenhe merged commit 87bd0df into Azure:main Feb 9, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

Adding xms-ids for Botservice (Azure#17617)

7851843

* Adding xms-ids for Botservice * corrections after rebase

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding xms-ids for Botservice #17617

Adding xms-ids for Botservice #17617

agalerrotaru commented Feb 2, 2022 •

edited

Loading

openapi-workflow-bot bot commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022

openapi-workflow-bot bot commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022

ghost commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2022 •

edited

Loading

Breaking Changes Tracking

lirenhe commented Feb 8, 2022

azure-pipelines bot commented Feb 8, 2022

lirenhe commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

Adding xms-ids for Botservice #17617

Adding xms-ids for Botservice #17617

Conversation

agalerrotaru commented Feb 2, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022

openapi-workflow-bot bot commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022

ghost commented Feb 2, 2022

openapi-pipeline-app bot commented Feb 2, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 2, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

lirenhe commented Feb 8, 2022

azure-pipelines bot commented Feb 8, 2022

lirenhe commented Feb 9, 2022

azure-pipelines bot commented Feb 9, 2022

agalerrotaru commented Feb 2, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2022 •

edited

Loading