[Hub Generated] Review request for Microsoft.HybridNetwork to add version preview/2022-01-01-preview #17665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @congl-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=276714&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go-track2 - armhybridnetwork - 0.3.0+ Field `OperationList` of struct `OperationsClientListResult` has been removed
+ Function `ErrorDetail.MarshalJSON` has been removed
+ Function `OperationList.MarshalJSON` has been removed
+ Struct `ErrorAdditionalInfo` has been removed
+ Struct `ErrorDetail` has been removed
+ Struct `ErrorResponse` has been removed
+ Struct `OperationList` has been removed
+ Type of `NetworkFunctionPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionPropertiesFormat.NetworkFunctionContainerConfigurations` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionRoleConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionRoleConfiguration.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionSKURoleDetails.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionSKURoleDetails.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionUserConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionVendorConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `VendorSKUPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `VendorSKUPropertiesFormat.ManagedApplicationTemplate` has been changed from `map[string]interface{}` to `interface{}`❌azure-sdk-for-go - preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork - v61.4.0+ Field `AzureStackEdge` of struct `DevicePropertiesFormat` has been removed
❌azure-sdk-for-python-track2 - track2_azure-mgmt-hybridnetwork - 1.0.0️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from a2536a5ca6cfe594386db558c95de6a244ab3c38. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2022-02-09 18:34:51 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hybridnetwork;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2022-02-09 18:34:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2022-02-09 18:34:51 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridnetwork/azure-resourcemanager-hybridnetwork --java.namespace=com.azure.resourcemanager.hybridnetwork --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md cmderr [generate.py] 2022-02-09 18:35:22 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hybridnetwork cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridnetwork cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Skip] pom already has module sdk/hybridnetwork cmderr [generate.py] 2022-02-09 18:35:22 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-hybridnetwork [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-hybridnetwork-1.0.0-beta.2-sources.jar
- azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar
cmderr [Inst] 2022-02-09 18:37:07 DEBUG Got artifact_id: azure-resourcemanager-hybridnetwork cmderr [Inst] 2022-02-09 18:37:07 DEBUG Got artifact: pom.xml cmderr [Inst] 2022-02-09 18:37:07 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2-sources.jar cmderr [Inst] 2022-02-09 18:37:07 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar cmderr [Inst] 2022-02-09 18:37:07 DEBUG Match jar package: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar cmderr [Inst] 2022-02-09 18:37:07 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17665/azure-sdk-for-java/azure-resourcemanager-hybridnetwork/azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\" -o azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridnetwork -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⌛ azure-sdk-for-go pending [Detail]
️⌛ azure-sdk-for-go-track2 pending [Detail]
️🔄 azure-sdk-for-js inProgress [Detail]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from a2536a5ca6cfe594386db558c95de6a244ab3c38. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️hybridnetwork [View full logs] [Preview Schema Changes]
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @congl-microsoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @chunyu3 , since the same change is already checked into RPSaaSMaster branch (https://github.com/Azure/azure-rest-api-specs-pr/pull/6030), would you please help us merge it to Main branch as well? For any questions please refer to the API reviewers' comments in the other PR above. Thank you! |
raosuhas
reviewed
Feb 4, 2022
| }, | ||
| "httpMethod": { | ||
| "type": "string", | ||
| "description": "The http method of the request." |
There was a problem hiding this comment.
consider making this an extensible enum with the httpmethod params
There was a problem hiding this comment.
Thank you for the suggestion. Will consider this idea.
There was a problem hiding this comment.
Changed it to enum.
raosuhas
reviewed
Feb 4, 2022
| "info": { | ||
| "title": "HybridNetworkManagementClient", | ||
| "description": "The resources in this swagger specification will be used to manage the operations.", | ||
| "version": "2022-01-01-preview" |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=4)
Consider using the common-type for this : https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v3/types.json#L358
There was a problem hiding this comment.
Thank you for the suggestion. Since this time we only add two APIs on top of the existing stable API version for public preview, for definitions other than the two APIs do you mind if we just keep the same to the stable API version at this moment?
There was a problem hiding this comment.
Changed it to refer to the one defined in the common-type.
raosuhas
reviewed
Feb 4, 2022
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.HybridNetwork/vendors/{vendorName}/vendorSkus/{skuName}/generateCredential": { |
There was a problem hiding this comment.
Note if you want to use this in an ARM template then this needs to be called as list*
You can see other examples here : https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-functions-resource#list
There was a problem hiding this comment.
Thank you for the suggestion. We do not need to use it in an ARM template. Is it a strict requirement to call it as "list*"? If yes, I think we need to update the APIs in the private repo as well.
There was a problem hiding this comment.
Well once these are released then customers might want to deploy them in ARM templates since all azure resources are typically deployed using ARM templates. For example if they want to generate the credential and then pass it into another deploymentscript to configure things. It is a strict requirement to call it list* only is you need to call it in ARM template otherwise it is fine.
There was a problem hiding this comment.
Thank you for the explaination. Renamed it to "listCredential".
raosuhas
added
ARMSignedOff
|
Signing off on this , with a few comments. Please fix as appropriate before checkin. Send a mail to armapireview for any clarifications are required. |
|
Hi @chunyu3 , we already updated the PR following the API reviewer's comments. Would you please help us complete this PR? Besides, we have another PR with the same content to check into the private repo main branch. In that PR (https://github.com/Azure/azure-rest-api-specs-pr/pull/6105), @lirenhe said we need to add a reference in this PR then the other one can be merged. So would you please help us complete the other one in one shot? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @congl-microsoft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=276714&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go-track2 - armhybridnetwork - 0.3.0+ Field `OperationList` of struct `OperationsClientListResult` has been removed
+ Function `ErrorDetail.MarshalJSON` has been removed
+ Function `OperationList.MarshalJSON` has been removed
+ Struct `ErrorAdditionalInfo` has been removed
+ Struct `ErrorDetail` has been removed
+ Struct `ErrorResponse` has been removed
+ Struct `OperationList` has been removed
+ Type of `NetworkFunctionPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionPropertiesFormat.NetworkFunctionContainerConfigurations` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionRoleConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionRoleConfiguration.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionSKURoleDetails.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionSKURoleDetails.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionUserConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `NetworkFunctionVendorConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `VendorSKUPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}`
+ Type of `VendorSKUPropertiesFormat.ManagedApplicationTemplate` has been changed from `map[string]interface{}` to `interface{}`❌azure-sdk-for-go - preview/hybridnetwork/mgmt/2020-01-01-preview/hybridnetwork - v61.4.0+ Field `AzureStackEdge` of struct `DevicePropertiesFormat` has been removed
❌azure-sdk-for-python-track2 - track2_azure-mgmt-hybridnetwork - 1.0.0️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-hybridnetwork [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation NetworkFunctionsOperations.begin_execute_request info [Changelog] - Added operation VendorSkusOperations.list_credential info [Changelog] - Model Operation has a new parameter action_type info [Changelog] - Model Operation has a new parameter is_data_action info [Changelog] - Model Operation has a new parameter origin info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model Device no longer has parameter azure_stack_edge info [Changelog] - Model DevicePropertiesFormat no longer has parameter azure_stack_edge
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2022-02-10 05:37:28 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hybridnetwork;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2022-02-10 05:37:28 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2022-02-10 05:37:28 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hybridnetwork/azure-resourcemanager-hybridnetwork --java.namespace=com.azure.resourcemanager.hybridnetwork --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hybridnetwork/resource-manager/readme.md cmderr [generate.py] 2022-02-10 05:38:04 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hybridnetwork cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Skip] pom already has module azure-resourcemanager-hybridnetwork cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Skip] pom already has module sdk/hybridnetwork cmderr [generate.py] 2022-02-10 05:38:04 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-hybridnetwork [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-hybridnetwork-1.0.0-beta.2-sources.jar
- azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar
cmderr [Inst] 2022-02-10 05:39:19 DEBUG Got artifact_id: azure-resourcemanager-hybridnetwork cmderr [Inst] 2022-02-10 05:39:19 DEBUG Got artifact: pom.xml cmderr [Inst] 2022-02-10 05:39:19 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2-sources.jar cmderr [Inst] 2022-02-10 05:39:19 DEBUG Got artifact: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar cmderr [Inst] 2022-02-10 05:39:19 DEBUG Match jar package: azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar cmderr [Inst] 2022-02-10 05:39:19 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17665/azure-sdk-for-java/azure-resourcemanager-hybridnetwork/azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\" -o azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hybridnetwork -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hybridnetwork-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️🔄 azure-sdk-for-go inProgress [Detail]
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armhybridnetwork [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `NetworkFunctionRoleConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionRoleConfiguration.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionUserConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionPropertiesFormat.NetworkFunctionContainerConfigurations` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionVendorConfiguration.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `VendorSKUPropertiesFormat.ManagedApplicationParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `VendorSKUPropertiesFormat.ManagedApplicationTemplate` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionSKURoleDetails.UserDataTemplate` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Type of `NetworkFunctionSKURoleDetails.UserDataParameters` has been changed from `map[string]interface{}` to `interface{}` info [Changelog] - Function `ErrorDetail.MarshalJSON` has been removed info [Changelog] - Function `OperationList.MarshalJSON` has been removed info [Changelog] - Struct `ErrorAdditionalInfo` has been removed info [Changelog] - Struct `ErrorDetail` has been removed info [Changelog] - Struct `ErrorResponse` has been removed info [Changelog] - Struct `OperationList` has been removed info [Changelog] - Field `OperationList` of struct `OperationsClientListResult` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `HTTPMethodGet` info [Changelog] - New const `HTTPMethodUnknown` info [Changelog] - New const `OriginUser` info [Changelog] - New const `HTTPMethodDelete` info [Changelog] - New const `HTTPMethodPut` info [Changelog] - New const `OriginSystem` info [Changelog] - New const `HTTPMethodPatch` info [Changelog] - New const `ActionTypeInternal` info [Changelog] - New const `HTTPMethodPost` info [Changelog] - New const `OriginUserSystem` info [Changelog] - New function `PossibleActionTypeValues() []ActionType` info [Changelog] - New function `*NetworkFunctionsClientExecuteRequestPoller.Done() bool` info [Changelog] - New function `*NetworkFunctionsClientExecuteRequestPoller.ResumeToken() (string, error)` info [Changelog] - New function `PossibleHTTPMethodValues() []HTTPMethod` info [Changelog] - New function `Origin.ToPtr() *Origin` info [Changelog] - New function `NetworkFunctionsClientExecuteRequestPollerResponse.PollUntilDone(context.Context, time.Duration) (NetworkFunctionsClientExecuteRequestResponse, error)` info [Changelog] - New function `ActionType.ToPtr() *ActionType` info [Changelog] - New function `*SKUCredential.UnmarshalJSON([]byte) error` info [Changelog] - New function `PossibleOriginValues() []Origin` info [Changelog] - New function `*NetworkFunctionsClientExecuteRequestPollerResponse.Resume(context.Context, *NetworkFunctionsClient, string) error` info [Changelog] - New function `*NetworkFunctionsClientExecuteRequestPoller.Poll(context.Context) (*http.Response, error)` info [Changelog] - New function `OperationListResult.MarshalJSON() ([]byte, error)` info [Changelog] - New function `*NetworkFunctionsClient.BeginExecuteRequest(context.Context, string, string, ExecuteRequestParameters, *NetworkFunctionsClientBeginExecuteRequestOptions) (NetworkFunctionsClientExecuteRequestPollerResponse, error)` info [Changelog] - New function `SKUCredential.MarshalJSON() ([]byte, error)` info [Changelog] - New function `*VendorSKUsClient.ListCredential(context.Context, string, string, *VendorSKUsClientListCredentialOptions) (VendorSKUsClientListCredentialResponse, error)` info [Changelog] - New function `*NetworkFunctionsClientExecuteRequestPoller.FinalResponse(context.Context) (NetworkFunctionsClientExecuteRequestResponse, error)` info [Changelog] - New function `HTTPMethod.ToPtr() *HTTPMethod` info [Changelog] - New struct `ExecuteRequestParameters` info [Changelog] - New struct `NetworkFunctionsClientBeginExecuteRequestOptions` info [Changelog] - New struct `NetworkFunctionsClientExecuteRequestPoller` info [Changelog] - New struct `NetworkFunctionsClientExecuteRequestPollerResponse` info [Changelog] - New struct `NetworkFunctionsClientExecuteRequestResponse` info [Changelog] - New struct `OperationListResult` info [Changelog] - New struct `RequestMetadata` info [Changelog] - New struct `SKUCredential` info [Changelog] - New struct `VendorSKUsClientListCredentialOptions` info [Changelog] - New struct `VendorSKUsClientListCredentialResponse` info [Changelog] - New struct `VendorSKUsClientListCredentialResult` info [Changelog] - New field `ActionType` in struct `Operation` info [Changelog] - New field `IsDataAction` in struct `Operation` info [Changelog] - New field `Origin` in struct `Operation` info [Changelog] - New anonymous field `OperationListResult` in struct `OperationsClientListResult` info [Changelog] info [Changelog] Total 17 breaking change(s), 51 additive change(s).
️🔄 azure-sdk-for-js inProgress [Detail]
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️hybridnetwork [View full logs] [Release Schema Changes]
lirenhe
approved these changes
Feb 10, 2022
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-resource-manager-schemas
that referenced
this pull request
Feb 10, 2022
[Hub Generated] Review request for Microsoft.HybridNetwork to add version preview/2022-01-01-preview (#17665) * Adds base for updating Microsoft.HybridNetwork from version stable/2021-05-01 to version 2022-01-01-preview * Updates readme * Updates API version in new specs and examples * Updated new preview swagger APIs. * Update example label. * Updated swaggers based on API reviewer's comments in PR Azure/azure-rest-api-specs#17665. * Updated dummy token value in example. * Updated keyData in example files to pass credential scan. * Renamed token/key to PLACEHOLDER. * Revert "Renamed token/key to PLACEHOLDER." This reverts commit 276039ee60fd526539b029026fcb56052f478aa6. * Revert "Updated keyData in example files to pass credential scan." This reverts commit 6f09a30cb4a45828ca2a5ddbbcd8bcf3b73f7fb6. * Revert "Updated dummy token value in example." This reverts commit 8b09a86edee5ebd756b70b513e6d6ab41640dbd2.
This was referenced Feb 10, 2022
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 10, 2022
[Hub Generated] Review request for Microsoft.HybridNetwork to add version preview/2022-01-01-preview (Azure#17665) * Adds base for updating Microsoft.HybridNetwork from version stable/2021-05-01 to version 2022-01-01-preview * Updates readme * Updates API version in new specs and examples * Updated new preview swagger APIs. * Update example label. * Updated swaggers based on API reviewer's comments in PR Azure/azure-rest-api-specs#17665. * Updated dummy token value in example. * Updated keyData in example files to pass credential scan. * Renamed token/key to PLACEHOLDER. * Revert "Renamed token/key to PLACEHOLDER." This reverts commit 276039ee60fd526539b029026fcb56052f478aa6. * Revert "Updated keyData in example files to pass credential scan." This reverts commit 6f09a30cb4a45828ca2a5ddbbcd8bcf3b73f7fb6. * Revert "Updated dummy token value in example." This reverts commit 8b09a86edee5ebd756b70b513e6d6ab41640dbd2.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Feb 10, 2022
[Hub Generated] Review request for Microsoft.HybridNetwork to add version preview/2022-01-01-preview (Azure#17665) * Adds base for updating Microsoft.HybridNetwork from version stable/2021-05-01 to version 2022-01-01-preview * Updates readme * Updates API version in new specs and examples * Updated new preview swagger APIs. * Update example label. * Updated swaggers based on API reviewer's comments in PR Azure/azure-rest-api-specs#17665. * Updated dummy token value in example. * Updated keyData in example files to pass credential scan. * Renamed token/key to PLACEHOLDER. * Revert "Renamed token/key to PLACEHOLDER." This reverts commit 276039ee60fd526539b029026fcb56052f478aa6. * Revert "Updated keyData in example files to pass credential scan." This reverts commit 6f09a30cb4a45828ca2a5ddbbcd8bcf3b73f7fb6. * Revert "Updated dummy token value in example." This reverts commit 8b09a86edee5ebd756b70b513e6d6ab41640dbd2.
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Feb 10, 2022
…t.HybridNetwork to add version preview/2022-01-01-preview (#2200) Create to sync Azure/azure-rest-api-specs#17665 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/hybridnetwork?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…sion preview/2022-01-01-preview (Azure#17665) * Adds base for updating Microsoft.HybridNetwork from version stable/2021-05-01 to version 2022-01-01-preview * Updates readme * Updates API version in new specs and examples * Updated new preview swagger APIs. * Update example label. * Updated swaggers based on API reviewer's comments in PR Azure#17665. * Updated dummy token value in example. * Updated keyData in example files to pass credential scan. * Renamed token/key to PLACEHOLDER. * Revert "Renamed token/key to PLACEHOLDER." This reverts commit 276039e. * Revert "Updated keyData in example files to pass credential scan." This reverts commit 6f09a30. * Revert "Updated dummy token value in example." This reverts commit 8b09a86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.