-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding force delete flag for Network Manager resources #17692
Conversation
Hi, @jago2136 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Since operation 'ListActiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L67 |
|
Since operation 'ListActiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L120 |
|
Since operation 'ListActiveSecurityUserRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerActiveConfiguration.json#L173 |
|
Since operation 'ListNetworkManagerEffectiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerEffectiveConfiguration.json#L67 |
|
Since operation 'ListNetworkManagerEffectiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerEffectiveConfiguration.json#L120 |
|
Since operation 'ListEffectiveVirtualNetworks_ByNetworkGroup' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L232 |
|
'PATCH' operation 'NetworkManagers_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L156 |
|
The operation 'NetworkManagerCommits_Post' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L205 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkManagerDeploymentStatusModel'. Consider using the plural form of 'NetworkManagerDeploymentStatus' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L262 |
|
OperationId should contain the verb: 'commit' in:'NetworkManagerCommits_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L209 |
|
OperationId should contain the verb: 'listdeploymentstatus' in:'NetworkManagerDeploymentStatus_List'. Consider updating the operationId Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L262 |
|
OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'EffectiveVirtualNetworks_ListByNetworkManager'. Consider updating the operationId Location: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L394 |
|
OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'ListEffectiveVirtualNetworks_ByNetworkGroup'. Consider updating the operationId Location: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L232 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L301 |
R4037 - MissingTypeObject |
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L38 |
R4037 - MissingTypeObject |
The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L55 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L83 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L93 |
R4037 - MissingTypeObject |
The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L118 |
R4037 - MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L140 |
R4037 - MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L140 |
R4037 - MissingTypeObject |
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L198 |
R4037 - MissingTypeObject |
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L208 |
R4037 - MissingTypeObject |
The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L273 |
R4037 - MissingTypeObject |
The schema 'ExtendedLocation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2022-02-01-preview/network.json#L395 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
Cross-Version Breaking Changes: 56 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-02-01-preview/network.json compared with base:stable/2021-05-01/network.json
- current:preview/2022-02-01-preview/network.json compared with base:preview/2021-05-01-preview/network.json
- current:preview/2022-02-01-preview/networkManager.json compared with base:preview/2021-05-01-preview/networkManager.json
- current:preview/2022-02-01-preview/networkManagerActiveConfiguration.json compared with base:preview/2021-05-01-preview/networkManagerActiveConfiguration.json
- current:preview/2022-02-01-preview/networkManagerConnection.json compared with base:preview/2021-05-01-preview/networkManagerConnection.json
- current:preview/2022-02-01-preview/networkManagerConnectivityConfiguration.json compared with base:preview/2021-05-01-preview/networkManagerConnectivityConfiguration.json
- current:preview/2022-02-01-preview/networkManagerEffectiveConfiguration.json compared with base:preview/2021-05-01-preview/networkManagerEffectiveConfiguration.json
- current:preview/2022-02-01-preview/networkManagerGroup.json compared with base:preview/2021-05-01-preview/networkManagerGroup.json
- current:preview/2022-02-01-preview/networkManagerScopeConnection.json compared with base:preview/2021-05-01-preview/networkManagerScopeConnection.json
- current:preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json compared with base:preview/2021-05-01-preview/networkManagerSecurityAdminConfiguration.json
- current:preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json compared with base:preview/2021-05-01-preview/networkManagerSecurityUserConfiguration.json
Only 30 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @jago2136, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
Hi @jago2136, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@jago2136 , could you fix the swagger examples for model validation errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from ARM side.
LGTM |
Spoke with Mikhail, and he confirmed this is the correct target branch given we are still in preview. Thanks! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
* base commit for PR reviewer * add force delete flags and remove recursive delete flags * security configuration split into admin/user * split rule collection into admin/user rule collection * updating examples for security config resources * update api version * fix parameter types for security admin conf/rule collection * removing display name from all definitions and examples * fix properties of security config examples * fix network manager connection path * update readme with complete spec list Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
February/asap
2/11 or asap
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.